From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFjKy-0008NJ-K4 for guix-patches@gnu.org; Mon, 07 May 2018 12:50:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFjKs-000189-Pl for guix-patches@gnu.org; Mon, 07 May 2018 12:50:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFjKs-00017n-Lt for guix-patches@gnu.org; Mon, 07 May 2018 12:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fFjKs-0004Ta-DI for guix-patches@gnu.org; Mon, 07 May 2018 12:50:02 -0400 Subject: [bug#31342] [PATCH 2/2] gnu: services: Add Enlightenment desktop service. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180502164723.13994-1-efraim@flashner.co.il> <20180502164723.13994-2-efraim@flashner.co.il> Date: Mon, 07 May 2018 18:49:43 +0200 In-Reply-To: <20180502164723.13994-2-efraim@flashner.co.il> (Efraim Flashner's message of "Wed, 2 May 2018 19:47:23 +0300") Message-ID: <87bmdr5s2g.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 31342@debbugs.gnu.org Efraim Flashner skribis: > * gnu/services/desktop.scm (, > enlightenment-desktop-service-type): New variables. > (enlightenment-desktop-service): New public variable. > * doc/guix.texi (Desktop Services): Document the service. In guix.texi, could you document =E2=80=98enlightenment-desktop-service-typ= e=E2=80=99 and =E2=80=98enlightenment-desktop-configuration=E2=80=99? [...] > +(define-record-type* > + enlightenment-desktop-configuration > + make-enlightenment-desktop-configuration > + enlightenment-desktop-configuration > + (enlightenment enlightenment-package (default enlightenment))) Actually, unless you expect more configuration elements to be added to this record eventually, you might be better off without a record and simply using the package as the value for that service. WDYT? > +(define (enlightenment-setuid-programs enlightenment-desktop-configurati= on) > + (match-record enlightenment-desktop-configuration > + > + (enlightenment) > + (list (file-append enlightenment > + "/lib/enlightenment/utils/enlightenment_sys") > + (file-append enlightenment > + "/lib/enlightenment/utils/enlightenment_backlight= ") > + ;; TODO: Move this binary to a screen-locker service. > + (file-append enlightenment > + "/lib/enlightenment/utils/enlightenment_ckpasswd") Perhaps enlightenment_ckpasswd needs a PAM entry as well, like =E2=80=98screen-locker-service-type=E2=80=99 does? > + (file-append enlightenment > + (string-append > + "/lib/enlightenment/modules/cpufreq/linux-gnu-" > + (string-drop-right (%current-system) 6) ; drop = '-linux' Rather: (match (string-tokenize (%current-system) (char-set-complement (char-set = #\-))) ((arch "linux") (string-append "linux-gnu-" arch)) ((arch "gnu") (string-append "gnu-" arch))) > +(define* (enlightenment-desktop-service > + #:key (config (enlightenment-desktop-configuration))) > + "Return a service that adds the @code{enlightenment} package to the sy= stem > +profile, and extends dbus with the ability for @code{efl} to generate > +thumbnails and makes setuid the programs which enlightenment expects to = have > +their setuid bit set." > + (service enlightenment-desktop-service-type config)) Not needed! :-) Thank you, Ludo=E2=80=99.