From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGh2Y-0007J3-OZ for guix-patches@gnu.org; Thu, 10 May 2018 04:35:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGh2U-0008Vh-QO for guix-patches@gnu.org; Thu, 10 May 2018 04:35:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGh2U-0008Va-MN for guix-patches@gnu.org; Thu, 10 May 2018 04:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fGh2U-0002HS-DE for guix-patches@gnu.org; Thu, 10 May 2018 04:35:02 -0400 Subject: [bug#31386] [PATCH 3/3] gnu: Add tensorflow-core. Resent-Message-ID: References: <20180508145909.25354-1-ricardo.wurmus@mdc-berlin.de> <20180508145909.25354-3-ricardo.wurmus@mdc-berlin.de> <87k1scv3wl.fsf@gnu.org> From: Ricardo Wurmus In-Reply-To: <87k1scv3wl.fsf@gnu.org> Date: Thu, 10 May 2018 10:34:16 +0200 Message-ID: <87bmdngb93.fsf@mdc-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31386@debbugs.gnu.org Ludovic Court=C3=A8s writes: > Ricardo Wurmus skribis: > >> * gnu/packages/machine-learning.scm (tensorflow-core): New variable. > > [...] > >> + #:make-flags >> + (list "-f" "tensorflow/contrib/makefile/Makefile" >> + "CC=3Dgcc") > > Perhaps we should add a comment on why not Bazel. > >> + (native-inputs >> + `(("protobuf" ,protobuf) ; protoc >> + ;; "You may use, copy, modify this code for any purpose and with= out >> + ;; fee. You may distribute this ORIGINAL package." >> + ("fft2d" > > Doesn=E2=80=99t that make fft2d non-free, if we cannot redistribute modif= ied copies? I really don=E2=80=99t understand the second sentence. The first sentence = says that =E2=80=9Cthis code=E2=80=9D may be copied and modified =E2=80=9Cfor an= y purpose=E2=80=9D. The second sentence doesn=E2=80=99t seem to add anything, but that depends on h= ow you read it. You may *only* distribute this [source archive]. You may *also* distribute this [unmodified package]. I wrote an email to the author=E2=80=99s email address, but I don=E2=80=99t= know if that address is still in use. Anyway: I just went to http://www.kurims.kyoto-u.ac.jp/~ooura/fft.html, where this sentence has been removed. The license notice now looks like this: Copyright Takuya OOURA, 1996-2001 You may use, copy, modify and distribute this code for any purpose (include commercial use) and without fee. Please refer to this package when you modify this code. The notice in the readme.txt is unchanged, though. >> + ,(origin >> + (method url-fetch) >> + (uri "https://mirror.bazel.build/www.kurims.kyoto-u.ac.jp/~o= oura/fft.tgz") > > Unversioned URL. :-/ Yeah :( The upstream URL is also unversioned, but it looks like development has ceased in 2006. -- Ricardo