From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51024)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fID1K-00059A-Vu
	for guix-patches@gnu.org; Mon, 14 May 2018 08:56:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fID1G-00021t-Qe
	for guix-patches@gnu.org; Mon, 14 May 2018 08:56:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:53720)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fID1G-00021j-Mm
	for guix-patches@gnu.org; Mon, 14 May 2018 08:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fID1G-0000vU-CV
	for guix-patches@gnu.org; Mon, 14 May 2018 08:56:02 -0400
Subject: [bug#31449] [PATCH 1/3] gnu: Add guile-simple-zmq.
Resent-Message-ID: <handler.31449.B31449.15263025153508@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180514090751.1021-1-pierre-antoine.rouby@inria.fr>
Date: Mon, 14 May 2018 14:55:01 +0200
In-Reply-To: <20180514090751.1021-1-pierre-antoine.rouby@inria.fr> (Rouby
	Pierre-Antoine's message of "Mon, 14 May 2018 11:07:51 +0200")
Message-ID: <87bmdi8kii.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Rouby Pierre-Antoine <pierre-antoine.rouby@inria.fr>
Cc: 31449@debbugs.gnu.org

Hello!

Rouby Pierre-Antoine <pierre-antoine.rouby@inria.fr> skribis:

> * gnu/package/guile.scm (guile-simple-zmq): New variable.

[...]

> +(define-public guile-simple-zmq
> +  (package
> +    (name "guile-simple-zmq")
> +    (version "0.0.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/jerry40/guile-simple-zmq")
> +             (commit "d76657aeb1cd10ef8136edc06bb90999914c7c3c")))

Nitpick: since there=E2=80=99s no release, I think the version number shoul=
d be
like:

  (string-append "0-" (string-take commit 7))

along the lines of what the manual suggests (info "(guix) Version
Numbers").

> +    (description
> +     "This package is Guile wrapper over ZeroMQ library.")

What about:

  "This package provides a Guile programming interface to the ZeroMQ
  messaging library."

?

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.