all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 31490@debbugs.gnu.org, 31490-done@debbugs.gnu.org
Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode.
Date: Tue, 22 May 2018 17:21:28 +0200	[thread overview]
Message-ID: <87bmd7g1hj.fsf@fastmail.com> (raw)
In-Reply-To: <87bmd7bwd4.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
> […]
>
>>> +             (substitute* "Auxiliary/CMakeLists.txt"
>>> +               (("install\\(FILES cmake-mode.el \
>>> +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") ""))))
>>
>> Nitpick: I'd use a regexp to match the text following cmake-mode.el on
>> the line to make it more resilient to any future changes. Otherwise this
>> LGTM :)
>
> Agree, pushed as f037673c3133ae7453794f1f62eecebf9d06b092

'core-updates' is currently live on Hydra:

https://hydra.gnu.org/jobset/gnu/core-updates

Since we already have substitutes for CMake and many dependents, this
commit will have to wait until the next rebuild cycle.  Can you revert
it on 'core-updates' and resubmit the patch to 'core-updates-next'?

PS: Please also end the phase on #t ;-)

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      parent reply	other threads:[~2018-05-22 15:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 12:27 [bug#31490] [PATCH] gnu: Add emacs-cmake-mode Oleg Pykhalov
2018-05-18 13:07 ` Maxim Cournoyer
2018-05-22  5:43   ` Oleg Pykhalov
2018-05-22 13:16     ` Maxim Cournoyer
2018-05-22 14:25       ` bug#31490: " Oleg Pykhalov
2018-05-22 14:40         ` [bug#31490] " Oleg Pykhalov
2018-05-22 15:21         ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmd7g1hj.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=31490-done@debbugs.gnu.org \
    --cc=31490@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.