From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57207)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fRIcX-0000tS-TP
	for guix-patches@gnu.org; Fri, 08 Jun 2018 10:44:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fRIcU-00062e-If
	for guix-patches@gnu.org; Fri, 08 Jun 2018 10:44:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:60076)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fRIcU-00062B-DV
	for guix-patches@gnu.org; Fri, 08 Jun 2018 10:44:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fRIcU-0006i3-4E
	for guix-patches@gnu.org; Fri, 08 Jun 2018 10:44:02 -0400
Subject: [bug#31687] [PATCH] services: Add dnsmasq-service-type.
Resent-Message-ID: <handler.31687.B31687.152846903325769@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180602152814.14217-1-iyzsong@member.fsf.org>
Date: Fri, 08 Jun 2018 16:43:40 +0200
In-Reply-To: <20180602152814.14217-1-iyzsong@member.fsf.org>
	("=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?="'s
	message of "Sat, 2 Jun 2018 23:28:14 +0800")
Message-ID: <87bmcll4o3.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
Cc: 31687@debbugs.gnu.org

Hello!

Thanks for this patch, that looks like a useful service to have!

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@member.fsf.org> skribis:

> +@item @code{no-negcache?} (default: @code{#f})
> +When true, disable negative caching.

Minor issues:

  =E2=80=A2 The general guideline is to avoid abbreviations in identifiers=
=E2=80=94we=E2=80=99re
    using the language that comes with =E2=80=98call-with-current-continuat=
ion=E2=80=99,
    after all.  ;-)

  =E2=80=A2 Another guideline is to avoid double-negations and the likes.

So in this example, I would recommend:

  =E2=80=98negative-caching?=E2=80=99 (default: #t)

I think there=E2=80=99s a couple of other abbreviations.

Ludo=E2=80=99.