From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@member.fsf.org>
Cc: 31687@debbugs.gnu.org
Subject: [bug#31687] [PATCH] services: Add dnsmasq-service-type.
Date: Fri, 08 Jun 2018 16:43:40 +0200 [thread overview]
Message-ID: <87bmcll4o3.fsf@gnu.org> (raw)
In-Reply-To: <20180602152814.14217-1-iyzsong@member.fsf.org> ("宋文武"'s message of "Sat, 2 Jun 2018 23:28:14 +0800")
Hello!
Thanks for this patch, that looks like a useful service to have!
宋文武 <iyzsong@member.fsf.org> skribis:
> +@item @code{no-negcache?} (default: @code{#f})
> +When true, disable negative caching.
Minor issues:
• The general guideline is to avoid abbreviations in identifiers—we’re
using the language that comes with ‘call-with-current-continuation’,
after all. ;-)
• Another guideline is to avoid double-negations and the likes.
So in this example, I would recommend:
‘negative-caching?’ (default: #t)
I think there’s a couple of other abbreviations.
Ludo’.
next prev parent reply other threads:[~2018-06-08 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 15:28 [bug#31687] [PATCH] services: Add dnsmasq-service-type 宋文武
2018-06-05 12:07 ` bug#31687: " 宋文武
2018-06-08 14:43 ` Ludovic Courtès [this message]
2018-06-08 15:45 ` [bug#31687] " 宋文武
2018-06-08 19:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmcll4o3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31687@debbugs.gnu.org \
--cc=iyzsong@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.