From: Vagrant Cascadian <vagrant@debian.org>
To: Marius Bakke <mbakke@fastmail.com>, 31957@debbugs.gnu.org
Subject: [bug#31957] [PATCH] gnu: Add python-libusb1.
Date: Mon, 25 Jun 2018 13:54:15 -0700 [thread overview]
Message-ID: <87bmbyoadk.fsf@aikidev.net> (raw)
In-Reply-To: <877emmejjg.fsf@fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 2619 bytes --]
On 2018-06-25, Marius Bakke wrote:
> Vagrant Cascadian <vagrant@debian.org> writes:
>
>> Add new package definition for python-libusb1, needed to upgrade
>> python-trezor to newer versions.
>
> Thanks! I have some minor nitpicks:
>
> [...]
>
>> * gnu/packages/libusb.scm (python-libusb1): New variable.
>
> Can you also add yourself to the copyright header in this file?
Sure.
>> +(define-public python-libusb1
>> + (package
>> + (name "python-libusb1")
>> + (version "1.6.4")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (pypi-uri "libusb1" version))
>> + (sha256
>> + (base32
>> + "03b7xrz8vqg8w0za5r503jhcmbd1ls5610jcja1rqz833nf0v4wc"))))
>> + (build-system python-build-system)
>> + (arguments
>> + `(#:modules ((srfi srfi-1)
>> + (srfi srfi-26)
>
> Is srfi-26 actually used here?
No idea, I admittedly cargo-culted this from python-pyusb...
fix-libusb-reference didn't work until I added the modules block, and I
didn't narrow-down which of the specific modules were actually needed.
>> + (guix build utils)
>> + (guix build python-build-system))
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'fix-libusb-reference
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (substitute* "usb1/libusb1.py"
>> + (("libusb_path = ctypes.util.find_library\\(base_name\\)")
>> + (string-append
>> + "libusb_path = \""
>> + (find (negate symbolic-link?)
>> + (find-files (assoc-ref inputs "libusb")
>> + "^libusb.*\\.so\\..*"))
>> + "\"")))
>> + #t)))))
>> + (inputs `(("libusb" ,libusb)))
>> + (home-page
>> + "http://github.com/vpelletier/python-libusb1")
>
> This line break is unnecessary :-)
Ok.
>> + (synopsis "Pure-python wrapper for libusb-1.0")
>> + (description
>> + "Pure-python wrapper for libusb-1.0")
>
> This description is rather thin. Can you try to make it into one or
> more full sentences?
Will try.
>> + (license lgpl2.1+)))
>
> I noticed the source contains GPL2 in COPYING, and LGPL2.1 as
> "COPYING.LESSER". Can you make sure we don't install the former?
I was a bit confused by that, but looking at all the actual code, it
only appears to be LGPL2.1. So you're saying to explicitly remove
COPYING from the package?
> Can you send an updated patch? Thanks in advance!
Sure. Thanks for the review!
live well,
vagrant
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-06-25 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 20:04 [bug#31957] [PATCH] gnu: Add python-libusb1 Vagrant Cascadian
2018-06-25 19:46 ` Marius Bakke
2018-06-25 20:54 ` Vagrant Cascadian [this message]
2018-06-25 21:26 ` Marius Bakke
2018-06-26 5:35 ` Vagrant Cascadian
2018-06-26 21:39 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmbyoadk.fsf@aikidev.net \
--to=vagrant@debian.org \
--cc=31957@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.