From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43522)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1frqV3-0008SJ-1Y
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:10:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1frqV1-0007KM-Vl
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:10:04 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50907)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1frqV0-0007Ij-Da
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:10:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1frqV0-0002De-26
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:10:02 -0400
Subject: [bug#32346] [PATCH 6/6] services: tor: Make it easier to use UNIX
	sockets.
Resent-Message-ID: <handler.32346.B32346.15347957828490@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180802064520.20273-1-cmmarusich@gmail.com>
	<20180802065159.20413-1-cmmarusich@gmail.com>
	<20180802065159.20413-6-cmmarusich@gmail.com>
Date: Mon, 20 Aug 2018 22:09:27 +0200
In-Reply-To: <20180802065159.20413-6-cmmarusich@gmail.com> (Chris Marusich's
	message of "Wed, 1 Aug 2018 23:51:59 -0700")
Message-ID: <87bm9wdclk.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 32346@debbugs.gnu.org

Chris Marusich <cmmarusich@gmail.com> skribis:

> * doc/guix.texi (Networking Services): Document it, and mention that
> tor-service is deprecated.
> * gnu/services/networking.scm (<tor-configuration>) <socks-socket-type>:
> New field.
> (tor-configuration->torrc): When socks-socket-type is 'unix, set
> SocksPort to UNIX domain socket /var/run/tor/socks-sock and set
> UnixSocksGroupWritable to 1.
> * gnu/tests/networking.scm (%tor-os/unix-socks-socket): Instead of using
> a custom config file, just set socks-socket-type to 'unix.

[...]

> +This is the type for a service that runs the @uref{https://torproject.or=
g,
> +Tor} anonymous networking daemon.  The service is configured using a
> +@code{<tor-configuration>} record.  By default, the TOR daemon runs as t=
he

Please s/TOR/Tor/ in this file.

> +@deftp {Data Type} tor-configuration
> +@table @asis
> +@item @code{tor} (default: @code{tor})
> +The package that provides the TOR daemon.  This package is expected to p=
rovide
> +the daemon at @file{bin/tor} relative to its output directory.  The defa=
ult
> +package is the @uref{https://www.torproject.org, TOR Project's}
> +implementation.
> +@item @code{config-file} (default: @code{(plain-file "empty" "")})

You could skip a line between between each @item for clarity.

Otherwise LGTM.

Thank you for this nice patch series!

Ludo=E2=80=99.