From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fuklT-0002c4-D0 for guix-patches@gnu.org; Tue, 28 Aug 2018 16:39:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fuklS-0002kh-BP for guix-patches@gnu.org; Tue, 28 Aug 2018 16:39:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59229) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fuklS-0002kN-6i for guix-patches@gnu.org; Tue, 28 Aug 2018 16:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fuklR-0001lp-So for guix-patches@gnu.org; Tue, 28 Aug 2018 16:39:01 -0400 Subject: [bug#32370] [PATCH 2/4] gnu: Add ruby-oj. Resent-Message-ID: References: <20180805144322.4705-1-mail@cbaines.net> <20180805144322.4705-2-mail@cbaines.net> <20180807003007.0b3769ef@alma-ubu> From: Christopher Baines In-reply-to: <20180807003007.0b3769ef@alma-ubu> Date: Tue, 28 Aug 2018 21:38:25 +0100 Message-ID: <87bm9mb51a.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 32370@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bj=C3=B6rn H=C3=B6fling writes: > On Sun, 5 Aug 2018 15:43:20 +0100 > Christopher Baines wrote: > >> From: Ben Woodcroft >> >> * gnu/packages/ruby.scm (ruby-oj): New variable. >> >> Signed-off-by: Christopher Baines >> --- >> gnu/packages/ruby.scm | 36 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> >> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm >> index a06be3e26..508bbe8c3 100644 >> --- a/gnu/packages/ruby.scm >> +++ b/gnu/packages/ruby.scm >> @@ -3161,6 +3161,42 @@ unacceptable HTML and/or CSS from a string.") >> (home-page "https://github.com/rgrove/sanitize/") >> (license license:expat))) >> >> +(define-public ruby-oj >> + (package >> + (name "ruby-oj") >> + (version "3.6.0") > > 3.6.5 is already available. I've sent some updated patches now, and I've updated to the latest version. >> + (source >> + (origin >> + (method url-fetch) >> + ;; Version on rubygems.org does not contain Rakefile, so >> download from >> + ;; GitHub instead. >> + (uri (string-append "https://github.com/ohler55/oj/archive/v" >> + version ".tar.gz")) >> + (file-name (string-append name "-" version ".tar.gz")) >> + (sha256 >> + (base32 >> + "1vhjkmnyllkiwpwqh6swbam826ch2vhrjqmbys2ki6wh48vzknlb")))) > > I forgot: Is this checksum-stable or should we switch to > git-fetch here? I'm not sure either. >> + (build-system ruby-build-system) >> + (arguments >> + '(#:test-target "test_all" >> + #:phases >> + (modify-phases %standard-phases >> + (add-before 'check 'disable-bundler >> + (lambda _ >> + (substitute* "Rakefile" >> + (("Bundler\\.with_clean_env") "1.times") >> + (("bundle exec ") ""))))))) >> + (native-inputs >> + `(("bundler" ,bundler) >> + ("ruby-rspec" ,ruby-rspec) >> + ("ruby-rake-compiler" ,ruby-rake-compiler))) >> + (synopsis "JSON parser for Ruby optimized for speed") >> + (description >> + "Oj is a JSON parser and generator for Ruby, where the encoding >> and +decoding of JSON is implemented as a C extension to Ruby.") >> + (home-page "https://www.ohler.com/oj") > > I had trouble reaching that site over httpS. http was fine. > Is this permanent or temporary? > rubygems also has http as homepage. Yeah, my bad, I think I followed the linter without thinking. >> + (license license:expat))) > > ./ext/oj/fast.c: BSD (3 clause) > ./ext/oj/hash.c: BSD (3 clause) > ./ext/oj/hash.h: BSD (3 clause) > ./ext/oj/hash_test.c: BSD (3 clause) > and others Good spot, I've tried to improve the license information now. > As above, guix build --rounds=3D2 -K complained, but diffoscope showed no= dfference. I do see some differences with diffoscope, but I haven't looked in to them yet. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAluFssFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcjLRAAqEXgVDadJkHPL9IqZE4XRCKw5/yTbF3U+xil5zGBYnYfCayF1bgABK1m NkySnz0zYhspdzngahzGFR/nNeYu9zHJeutdV2lXCy+S/X0UZPr/E9JAWFByZd8F hT0mY9A687zBJ4a3IeOK7iQhZxZInwiCieBlPS7don7mESifnp5gq0Ht0SUB/Ces sTOOj/xB2nPDeorhFJIx7Ssg7HVnRspeAH16/CJHeAgXGGryT99pdzOfId73Essc aUD9EhEjGmB2y5f6zStn2HrrGvsd5msK8pwiU8FCuCz4YdmkoVoaHsraEyf2CGv/ 5sP6oY1wNJoDCOdE3uF8LPoUwYhEhAFSu+zj3kgQ4k1qIns0KbEdi8hwBRk3gweG b8TlyygVva5gAe5uQYIEVTfj7HJjveEiage3il7LH86XEy5YRXG6uqFYw70XeRJM /+BvcxevkUL0PD3W/Kw4hsvpm8mzZKHW97qaz110CgqW94vnDG53zteMF4ANpTFM vYpXJgnTpVXDWttwzlkAtdwlFkT+7fmp67nNMV8o3xCUmx1k90UgcoT2FO0lMk4L IAAu6NMbC0+vTqiCTcIMJhyMzroRhrIXMztYon9NpyoHrpFTxLgrtCmvq5yRFssu aq9UDj1duDNDm2OtaB5gM/slXL1sdwkWaL/6X9QCNLTM22p2m+o= =+BHN -----END PGP SIGNATURE----- --=-=-=--