From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: 02/02: services: Add Gitolite. Date: Tue, 02 Oct 2018 08:20:58 +0100 Message-ID: <87bm8c7r1h.fsf@cbaines.net> References: <20180928200104.10056.60968@vcs0.savannah.gnu.org> <20180928200105.E0B4F20476@vcs0.savannah.gnu.org> <871s9b69mg.fsf@netris.org> <87d0sv7001.fsf@cbaines.net> <87muryspsg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7EzV-0000f3-E7 for guix-devel@gnu.org; Tue, 02 Oct 2018 03:21:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7EzQ-0007y1-HS for guix-devel@gnu.org; Tue, 02 Oct 2018 03:21:09 -0400 In-reply-to: <87muryspsg.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> Mark H Weaver writes: > > [...] > >>>> +(define-gexp-compiler (gitolite-rc-file-compiler >>>> + (file ) system target) >>>> + (match file >>>> + (($ umask git-config-keys roles enable) >>>> + (apply text-file* "gitolite.rc" >>>> + `("%RC =3D (\n" >>>> + " UMASK =3D> " ,(format #f "~4,'0o" umask) ",\n" > > [...] > >>> --8<---------------cut here---------------start------------->8--- >>> 0 (simple-format #f "~4,'0o" 63) >>> >>> ERROR: In procedure simple-format: >>> In procedure simple-format: FORMAT: Unsupported format option ~4 - use = (ice-9 format) instead >>> --8<---------------cut here---------------end--------------->8--- > > [...] > >> It sounds to me like adding #:use-modules (ice-9 format) to (gnu >> services version-control) would fix this, but I'll wait until I can >> reproduce the failure before re-adding the service. > > Yes, adding #:use-module (ice-9 format) will fix the problem. > > You should be able to reproduce it by running =E2=80=9Cmake hydra-jobs=E2= =80=9D. > > As to why you can=E2=80=99t necessarily reproduce it=E2=80=A6 It turns o= ut that loading > (ice-9 format) has the effect of set!ting the global =E2=80=98format=E2= =80=99 binding. > So if some unrelated piece of code loads (ice-9 format), you don=E2=80=99= t have > any problems; but if that doesn=E2=80=99t happen, you get the error. > > This terrible behavior has been in Guile forever and nobody has dared > changing it so far. :-) The -Wformat warning tries hard to diagnose > the issue though. Thanks both. I've added the #:use-module (ice-9 format) bit, and pushed now. Locally I got make hydra-jobs.scm to run successfully, so hopefully this hasn't broken anything this time :) Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAluzHFpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XerlhAAgFlS9ohuHQ0mzv6OjfWBq6zWQiyk4D1Ff3gpVHR3jheegdyml6vIIqeH 34QQpWhUiryEvb5zHee2RybEyBB53Av/2ka8lrNj+HQudYSwoWpg19/GIQljg/i+ 0BCn4d457RcL/08RkTSmo86A7U4k3sa8T8quPH8wXvaN6INzeeCpK75gIwY1edgw s2AtzB3/8Hea+jyzbHDMAtHqOiT6u+0Ytk1HknQHUN8qf7+BQGPZYixQknCPzEr6 wXcAwMs9YTyxtm5opKt1VfbJcRfvxbin+3RPzf3oUqTIJ6MHShm5kdu8lot6xxBs XybZb0RInTtRHYLej6SkwH7hWFGSxYr9JVuf/niGVfobrnGAwoJvXeEh068FkR5l v5W2YKAk1jO6sU3HKBBD3jHKzhHr8aWs026itZoBWxQus96gIrJU9idtnkGSgM8y Rp6FPUiWXR3VV2Q5rnFCfEQFSJNTHt9oK26CbVU5S042yP6tWERhYD5whYgAgqgN Zu5ZiqLfQ0ZoLhVIUpWXjCIKtwGuhFFrUiG1BZg4qRoRBBUuyHNZAjeLGfGHNskB Z7JEmYKiW0n3uUnMAFnzprl/byYbGnUeCNUaD3sxlcG/3ZXz/VuUrzVTsg8zm8tI vcmpoM4vJs4rJDRj1xDo9z85xBhUryYYjzt7w7DistgE5UDLXCw= =qyZN -----END PGP SIGNATURE----- --=-=-=--