From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40618)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gC93z-0004Ty-IS
	for guix-patches@gnu.org; Mon, 15 Oct 2018 16:02:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gC93y-0000y4-NI
	for guix-patches@gnu.org; Mon, 15 Oct 2018 16:02:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47238)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gC93y-0000xt-He
	for guix-patches@gnu.org; Mon, 15 Oct 2018 16:02:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gC93y-00036J-F7
	for guix-patches@gnu.org; Mon, 15 Oct 2018 16:02:02 -0400
Subject: [bug#33020] [PATCH] gnu: Add nullmailer.
Resent-Message-ID: <handler.33020.B33020.153963370411893@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20181011230632.13515-1-me@tobias.gr>
Date: Mon, 15 Oct 2018 22:01:26 +0200
In-Reply-To: <20181011230632.13515-1-me@tobias.gr> (Tobias Geerinckx-Rice's
	message of "Fri, 12 Oct 2018 01:06:32 +0200")
Message-ID: <87bm7vc73d.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 33020@debbugs.gnu.org

Hello!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * gnu/packages/mail.scm (nullmailer): New public variable.

[...]

> +         (add-before 'check 'delete-failing-tests
> +           (lambda _
> +             (with-directory-excursion "test/tests"
> +               (for-each delete-file
> +                         (list
> +                          ;; XXX 'nullmailer-inject: nullmailer-queue fa=
iled: 15'
> +                          "inject/queue"
> +                          ;; XXX This equires the not-yet-packaged tcpse=
rver.
> +                          "protocols")))

(Typo in the second comment.)

If the first failure something we should worry about?

> +    (synopsis "Simple relay-only mail transport agent")

s/transport/transfer/

> +    (description
> +     "Nullmailer is a simple replacement Mail Transfer Agent (@dfn{MTA})=
 for

I think you can remove @dfn here (normally it=E2=80=99s used on a phrase th=
at is
being introduced, not on an abbreviation.)

Otherwise LGTM, thanks!

Ludo=E2=80=99.