From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYYRc-0007ES-4H for guix-patches@gnu.org; Sun, 16 Dec 2018 10:35:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYYC6-0006jj-Vw for guix-patches@gnu.org; Sun, 16 Dec 2018 10:19:03 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:46236) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYYC6-0006jT-SG for guix-patches@gnu.org; Sun, 16 Dec 2018 10:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gYYC5-0005og-Jp for guix-patches@gnu.org; Sun, 16 Dec 2018 10:19:02 -0500 Subject: [bug#33764] [PATCH] gnu: z3: Update to 4.8.3 and add python{, 2}-z3 bindings. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20181216040528.29880-1-bandali@gnu.org> Date: Sun, 16 Dec 2018 16:18:16 +0100 In-Reply-To: <20181216040528.29880-1-bandali@gnu.org> (Amin Bandali's message of "Sat, 15 Dec 2018 23:05:30 -0500") Message-ID: <87bm5lv6tj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Amin Bandali Cc: 33764@debbugs.gnu.org Hello Amin, Amin Bandali skribis: > * gnu/packages/maths.scm (z3): Update to 4.8.3. > [build-system]: Switch from cmake to make, and use the current > scripts/mk_make.py build script instead of the now-deprecated > contrib/cmake/bootstrap.py. > > * gnu/packages/python.scm (python-z3, python2-z3): New public > variables. Overall LGTM. Some comments: > (native-inputs > - `(("python" ,python-2))) > + `(("which" ,(@ (gnu packages base) which)) > + ("python" ,python-wrapper))) Please add #:use-module (gnu packages which) so you don=E2=80=99t have to r= esort to the @ notation. > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -56,6 +56,7 @@ > ;;; Copyright =C2=A9 2018 Cl=C3=A9ment Lassieur > ;;; Copyright =C2=A9 2018 Maxim Cournoyer > ;;; Copyright =C2=A9 2018 Luther Thompson > +;;; Copyright =C2=A9 2018 Amin Bandali > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -14989,3 +14990,12 @@ RFC 8265 and RFC 8266.") > (description "Simple decorator to set attributes of target function = or > class in a @acronym{DRY, Don't Repeat Yourself} way.") > (license license:expat))) > + > +(define-public python-z3 z3) Is this variable necessary? Note that this does not create a =E2=80=9Cpython-z3=E2=80=9D package. > +(define-public python2-z3 > + (package (inherit python-z3) This definition cannot be in python.scm; it must be in the same file as =E2=80=98z3=E2=80=99 or we can get =E2=80=9Cunbound variable=E2=80=9D error= s while loading either of these two modules. Also, as we=E2=80=99re approaching end-of-life upstream for Python 2.x, we = now avoid creating =E2=80=9Cpython2-=E2=80=9D packages, unless we cannot avoid = it for some reason. Do you think we could do without this =E2=80=9Cpython2-z3=E2=80=9D= package? Could you send an updated patch? If you think we really need =E2=80=9Cpython2-z3=E2=80=9D, please make it a separate patch. Thank you! Ludo=E2=80=99.