From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggsout.gnu.org ([209.51.188.92]:37256 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ggF7V-0002B5-8l
	for guix-patches@gnu.org; Sun, 06 Jan 2019 15:34:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ggF7R-0003H0-Sl
	for guix-patches@gnu.org; Sun, 06 Jan 2019 15:34:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:46377)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ggF7R-0003Gt-PP
	for guix-patches@gnu.org; Sun, 06 Jan 2019 15:34:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ggF7R-0006cd-LO
	for guix-patches@gnu.org; Sun, 06 Jan 2019 15:34:01 -0500
Subject: [bug#33893] [PATCH v5 4/4] gnu: Add docker-cli.
Resent-Message-ID: <handler.33893.B33893.154680679625384@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20181230121754.775-1-dannym@scratchpost.org>
	<20181230233903.23426-1-dannym@scratchpost.org>
	<20181230233903.23426-5-dannym@scratchpost.org>
Date: Sun, 06 Jan 2019 21:33:12 +0100
In-Reply-To: <20181230233903.23426-5-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Mon, 31 Dec 2018 00:39:03 +0100")
Message-ID: <87bm4ty19z.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 33893@debbugs.gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/docker.scm (docker-cli): New variable.

[...]

> +    (arguments
> +     `(#:import-path "github.com/docker/cli"
> +       ;; TODO: Tests require a running Docker daemon.
> +       #:tests? #f

I suppose we cannot run the daemon in the build environment, can we?

Or is it possible to use some of the tests?

> +    (native-inputs
> +     `(("go" ,go)
> +       ("libltdl" ,libltdl)

Shouldn=E2=80=99t libltdl be an input?

Otherwise LGTM, thanks!

Ludo=E2=80=99.