From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:48157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1glhDk-0006Sy-2L
	for guix-patches@gnu.org; Mon, 21 Jan 2019 16:35:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1glhDi-000718-R6
	for guix-patches@gnu.org; Mon, 21 Jan 2019 16:35:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:41314)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1glhDi-0006yc-GA
	for guix-patches@gnu.org; Mon, 21 Jan 2019 16:35:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1glhDi-0002kd-0W
	for guix-patches@gnu.org; Mon, 21 Jan 2019 16:35:02 -0500
Subject: [bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating.
Resent-Message-ID: <handler.34040.B34040.154810645410518@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <8736pzpnhg.fsf@elephly.net>
	<20190111094208.28327-1-rekado@elephly.net>
Date: Mon, 21 Jan 2019 22:34:04 +0100
In-Reply-To: <20190111094208.28327-1-rekado@elephly.net> (Ricardo Wurmus's
	message of "Fri, 11 Jan 2019 10:42:07 +0100")
Message-ID: <87bm49itkj.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 34040@debbugs.gnu.org

Hello,

Other comments/questions came to mind=E2=80=A6  :-)

Ricardo Wurmus <rekado@elephly.net> skribis:

>    (version        upstream-source-version)        ;string
>    (urls           upstream-source-urls)           ;list of strings
>    (signature-urls upstream-source-signature-urls  ;#f | list of strings
> -                  (default #f)))
> +                  (default #f))
> +  (input-changes  upstream-source-input-changes
> +                  (default '()) (thunked)))

Any particular reason for making =E2=80=98input-changes=E2=80=99 thunked?

This causes a failure in tests/upstream.scm (because two evaluator
procedures are unlikely to be eq?).  I would fix it by removing the
=E2=80=98thunked=E2=80=99 property but I=E2=80=99m not sure if it=E2=80=99d=
 make sense.

Another thing: =E2=80=9Cupstream source=E2=80=9D designates something
absolute/stateless, but =E2=80=9Cinput changes=E2=80=9D designates something
relative/stateful.  So on second thought, I wonder whether
<upstream-source> is the right place for it.

I was thinking that updaters could maybe return two values
(<upstream-source> + list of changed inputs), which would be equivalent
but somewhat clearer.  The downside is that we=E2=80=99d have to change all
updaters to return multiple values.

Alternately, we could change =E2=80=98input-changes=E2=80=99 to =E2=80=98in=
puts=E2=80=99, which would be
absolute, not relative, and thus =E2=80=98package-update=E2=80=99 would tak=
e care of
calling =E2=80=98changed-inputs=E2=80=99 etc.

WDYT?

Apologies for not asking these questions earlier!

Thanks,
Ludo=E2=80=99.