From: Pierre Neidhardt <mail@ambrevar.xyz>
To: ludo@gnu.org, 36029@debbugs.gnu.org
Subject: [bug#36029] [PATCH 0/2] 'publish' and 'substitute' support several compression methods
Date: Sat, 01 Jun 2019 08:19:52 +0200 [thread overview]
Message-ID: <87blzhzv1z.fsf@ambrevar.xyz> (raw)
In-Reply-To: <20190531144828.9585-1-ludo@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1749 bytes --]
Hi!
> One idea we discussed there was to allow clients to pass an
> ‘X-Guix-Accepted-Encoding’ header in HTTP requests, and the server
> would return an lzip narinfo or a gzip narinfo depending on that.
> However, I thought that this was not very flexible, and that we
> were bound to mess up with caching.
>
> This patch implements a different solution: ‘guix publish’ can
> be passed multiple ‘-C’ options, in which case it compresses
> substitutes with all these compression methods. The corresponding
> narinfo looks like this:
>
> --8<---------------cut here---------------start------------->8---
> StorePath: /gnu/store/9czlz7ss3187l2vi1hvrlkwlgrggdg5p-inkscape-0.92.4
> URL: nar/gzip/9czlz7ss3187l2vi1hvrlkwlgrggdg5p-inkscape-0.92.4
> Compression: gzip
> FileSize: 40308611
> URL: nar/lzip/9czlz7ss3187l2vi1hvrlkwlgrggdg5p-inkscape-0.92.4
> Compression: lzip
> FileSize: 19867767
> NarHash: sha256:1jv4nkq68a7zwqhi9inrnh340a4jxcpb91wq7d25hgw0nk8isbbk
> NarSize: 136499024
> References: …
> --8<---------------cut here---------------end--------------->8---
Huhu, inkscape's size is already halved ;)
> IOW, it’s like before, except that there are multiple
> URL/Compression/FileSize fields instead of just one of each.
>
> The trick is that old clients take the first occurrence of each
> of these fields and ignore subsequent occurrences. In the example
> above, they’d just take gzip and ignore the rest.
Smart! I like it!
I gave the patches a quick skim but I'm not very knowledgeable of those
parts, so there is little for me to comment about I'm afraid.
Other than that, excited to see .lz substitutes becoming a reality!
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-06-01 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 14:48 [bug#36029] [PATCH 0/2] 'publish' and 'substitute' support several compression methods Ludovic Courtès
2019-05-31 15:00 ` [bug#36029] [PATCH 1/2] publish: '--compression' can be repeated Ludovic Courtès
2019-05-31 15:00 ` [bug#36029] [PATCH 2/2] substitute: Select the best compression methods Ludovic Courtès
2019-06-01 6:19 ` Pierre Neidhardt [this message]
2019-06-02 20:44 ` [bug#36029] [PATCH 0/2] 'publish' and 'substitute' support several " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blzhzv1z.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=36029@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.