Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."

Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."

[Mark H Weaver]

Hi Tobias,

guix-commits@gnu.org writes:

> nckx pushed a commit to branch master
> in repository guix.
>
> commit 1ebb908d447fd7e641e800f970a0035ccd98deb7
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date:   Thu Jun 27 00:20:50 2019 +0200
>
>     Revert "gnu: openssh: Clean-up custom install phase."
>
>     This reverts commit 7754136e464e02284624ad05c196d9ec26099143.

and you reverted another commit related to openssh as well:

> commit ba912479e8481d69b699ce348b35d5d70f0c9367
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date:   Thu Jun 27 00:20:54 2019 +0200
>
>     Revert "gnu: openssh: Don't create the PRIVSEP_PATH directory."
>
>     This reverts commit 46475f72ab6127e7818fdea4a0ea9cc07c60a5f4.

I don't doubt that reverting these commits was the right thing to do,
but it would be good to know _why_ they were reverted.  Can you provide
a link to a relevant discussion, or else explain it here?

In general, when reverting commits, I think it would be useful to
include an explanation in the commit log.  What do you think?

    Regards,
      Mark

Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

Mark,

Mark H Weaver wrote:
> I don't doubt that reverting these commits was the right thing 
> to do,
> but it would be good to know _why_ they were reverted.  Can you 
> provide
> a link to a relevant discussion, or else explain it here?

They remove .../var/empty which breaks ssh-daemon.

> In general, when reverting commits, I think it would be useful 
> to
> include an explanation in the commit log.  What do you think?

You're probably asking the wrong person.  I'm all for it.  It's 
not the done thing in Guix, tho'.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."

[Mark H Weaver]

Thanks.  For the record, the relevant bug is <https://bugs.gnu.org/36395>.

     Mark

Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

Mark H Weaver wrote:
> Thanks.  For the record, the relevant bug is 
> <https://bugs.gnu.org/36395>.

I absolutely would have added that URL had I been aware of its 
existence before now :-)

Thanks,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."

[Jonathan Brielmaier]

On 6/27/19 8:16 AM, Tobias Geerinckx-Rice wrote:
> Mark,
>
> Mark H Weaver wrote:
>> I don't doubt that reverting these commits was the right thing to do,
>> but it would be good to know _why_ they were reverted.  Can you provide
>> a link to a relevant discussion, or else explain it here?
>
> They remove .../var/empty which breaks ssh-daemon.
>
>> In general, when reverting commits, I think it would be useful to
>> include an explanation in the commit log.  What do you think?
>
> You're probably asking the wrong person.  I'm all for it.  It's not the
> done thing in Guix, tho'.

I don't think that the GNU standard forbids explanations additionally to
the required change description. Personally I often miss this, because
the commit description describes often only the obvious and not the
_reasoning_ :(

A good example for that are commit messages from IBM at the kernel :)

Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."

[Ludovic Courtès]

Hello!

Mark H Weaver <mhw@netris.org> skribis:

> In general, when reverting commits, I think it would be useful to
> include an explanation in the commit log.  What do you think?

I’m all for it.  Reverts are the one thing whose explanation cannot go
anywhere but in the commit log.

(Regardless, thank you Tobias for the quick fix!)

Ludo’.