From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:58113)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iDQDs-0007zh-KR
 for guix-patches@gnu.org; Thu, 26 Sep 2019 05:38:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iDQDr-00068o-H1
 for guix-patches@gnu.org; Thu, 26 Sep 2019 05:38:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:33871)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iDQDr-00068i-EB
 for guix-patches@gnu.org; Thu, 26 Sep 2019 05:38:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iDQDp-0006cA-Qr
 for guix-patches@gnu.org; Thu, 26 Sep 2019 05:38:03 -0400
Subject: [bug#37444] [PATCH] added aerc,
 a simple email client and its dependcies
Resent-Message-ID: <handler.37444.B37444.156949067325411@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190918082313.3514-1-mjbecze@riseup.net>
 <87woe6nfka.fsf@elephly.net>
 <574a6c68d80bb669bbbaac7ebede8f9c@riseup.net>
Date: Thu, 26 Sep 2019 11:37:45 +0200
In-Reply-To: <574a6c68d80bb669bbbaac7ebede8f9c@riseup.net> (Martin Becze's
 message of "Sun, 22 Sep 2019 01:55:46 -0700")
Message-ID: <87blv7pfdi.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Martin Becze <mjbecze@riseup.net>
Cc: 37444@debbugs.gnu.org

Hi Martin,

Martin Becze <mjbecze@riseup.net> skribis:

> On 2019-09-18 09:01, Ricardo Wurmus wrote:
>> Hi Martin,
>>=20
>>> This adds aerc, which is a terminal based email client written in go.
>>=20
>> Thank you for your patch!
>>=20
>> Could you please separate the independent changes into separate commits
>> and add commit summaries?  For example, the update of
>> go-github-com-mitchellh-go-homedir should be done separately.
>>=20
>> Please also explain why =E2=80=9Cinputs=E2=80=9D had to be changed to
>> =E2=80=9Cpropagated-inputs=E2=80=9D in some packages, and mention these =
kind of changes
>> in the commit summary.
>>=20
>> Thanks!
>
> just bumping, updated patch has been made and split into commits now.
> https://issues.guix.gnu.org/issue/37444 let me know if that is ok

Like Ricardo mentioned, it would be great if patch #1 were split into
several commits, one per new package.  That=E2=80=99s how we usually do it.

I saw your commit logs provide explanations.  However, they are all on
the =E2=80=9Csubject line=E2=80=9D of the commit log.  Could you take a loo=
k at
<https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html>
regarding the format of commit logs, or run, say, =E2=80=9Cgit log
gnu/packages/golang.scm=E2=80=9D to view examples?

I could do these changes on your behalf, but I=E2=80=99d rather let you do =
it to
make sure I don=E2=80=99t mess up or misrepresent what you did!

Thanks,
Ludo=E2=80=99.