From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: [PATCH] Support returning build information by output. Date: Wed, 08 Jan 2020 22:21:51 +0100 Message-ID: <87blrdej9s.fsf@gnu.org> References: <20200104095148.3522-1-mail@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:38643) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipIm1-0000ii-LO for guix-devel@gnu.org; Wed, 08 Jan 2020 16:21:54 -0500 In-Reply-To: <20200104095148.3522-1-mail@cbaines.net> (Christopher Baines's message of "Sat, 4 Jan 2020 09:51:48 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: guix-devel@gnu.org Hi, Christopher Baines skribis: > Being able to take a derivation and query the build information is useful= , but > in cases where there are multiple derivations that produce the same outpu= ts, > the probability of getting the data back from Cuirass is reduced. > > This is because Cuirass might not have build the exact derivation you hav= e, > but a different derivation that produces the same outputs (this can commo= nly > happen when a related fixed output derivation changes). > > Cuirass doesn't store derivations if they produce the same outputs as a > derivation it already knows about, so it can't determine if this is the > case. Therefore, provide a way of querying build results by output, rather > than derivation. > > The motivation behind this is to make it easier to import build informati= on in > to the Guix Data Service. > > * src/cuirass/database.scm (db-get-output): New procedure. > * src/cuirass/http.scm (respond-output-not-found): New procedure. > (request-path-components): Handle /output/=E2=80=A6 requests. > * doc/cuirass.texi (Build information): Mention that you can get build > information by output. LGTM, thanks! Ludo=E2=80=99.