From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: Command line option in addition to GUIX_PACKAGE_PATH - Reason? Date: Thu, 16 Jan 2020 15:30:23 +0100 Message-ID: <87blr3eao0.fsf@ambrevar.xyz> References: <87pnglj2ka.fsf@ambrevar.xyz> <87sglgsiey.fsf@lassieur.org> <878sn8inru.fsf@ambrevar.xyz> <87o8w4mewg.fsf@gnu.org> <87tv5wfdrm.fsf@ambrevar.xyz> <87lfr8fd9u.fsf@ambrevar.xyz> <20191226213108.753f8ab7@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:52396) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is6AJ-0003Rh-Tj for guix-devel@gnu.org; Thu, 16 Jan 2020 09:30:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1is6AF-0007x8-SX for guix-devel@gnu.org; Thu, 16 Jan 2020 09:30:31 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:45369) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1is6AF-0007vw-Ls for guix-devel@gnu.org; Thu, 16 Jan 2020 09:30:27 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: zimoun , Danny Milosavljevic Cc: Guix Devel , =?utf-8?Q?Cl=C3=A9ment?= Lassieur --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I've merged your patch 38678. Only one nit with guix refresh: =2D-8<---------------cut here---------------start------------->8--- + ;; The short option -L is already used by --list-updaters, therefo= re + ;; it needs to be removed from %standard-build-options. + (let ((%load-path-option (find (lambda (option) + (member "load-path" + (option-names option))) + %standard-build-options))) + (option + (filter (lambda (name) (not (equal? #\L name))) + (option-names %load-path-option)) + (option-required-arg? %load-path-option) + (option-optional-arg? %load-path-option) + (option-processor %load-path-option))) + =2D-8<---------------cut here---------------end--------------->8--- I would name the let-bound variable without a percent sign '%' by convention. Should I fix this for you? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl4gc38ACgkQm9z0l6S7 zH9iQwf/QTQ02x1XnwDntwGSV2W59oYFH6ImpWrcq0nWPVE8dycH4J65Inyxft4P piBGpa7Eri9jBWtswSSbCEYDEOwMeyd0lbWO8O0bcyBxsjhlcn6Jj0mLzDDwaMTk AdUeflvTRC7u96NY4jwLU8Ei9+p971Oon6XkNVDDWLmARVZnPugpHKF/IExrEErX P1Rya/q36Jq9cslLaGFZZiA8yDKNaG8vRFEUThwOCUbV0myUnXjtVU7CBt05n/1I RMR41YrmteFHoFRa8H0e5QXYVM8feb0O8ZcmIDFm8fu61ZXfaYS2tDx/IrU00uV6 it/dZzGUTzgkC4F/aTENBcB3hXXZoA== =sIzS -----END PGP SIGNATURE----- --=-=-=--