bug#39318: [core-updates] 'make-desktop-entry-file' is not exported

bug#39318: [core-updates] 'make-desktop-entry-file' is not exported

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 136 bytes --]

Hello,

On the 'core-updates' branch, emacs-exwm, tome4 and drascula fails to
build because 'make-desktop-entry-file' is not available.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#39318: [core-updates] 'make-desktop-entry-file' is not exported

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 93 bytes --]

My bad I guess :p
Should I just export it?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#39318: [core-updates] 'make-desktop-entry-file' is not exported

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> My bad I guess :p
> Should I just export it?

It's good if you test that it works, too!  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#39318: [core-updates] 'make-desktop-entry-file' is not exported

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> It's good if you test that it works, too!  :-)

It's strange because I did test it.
My guess is that the export disappeared during a conflict resolution.
I remember merging the patch months after initially testing it, so a
conflict must have been introduced in the meantime.

Anyways, will fix!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#39318: [core-updates] 'make-desktop-entry-file' is not exported

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

I've tried to test but it rebuilds the world, looks like there is no
substitute for core-updates.
I've pushed anyways, let me know if that works for you.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#39318: [core-updates] 'make-desktop-entry-file' is not exported

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> I've tried to test but it rebuilds the world, looks like there is no
> substitute for core-updates.
> I've pushed anyways, let me know if that works for you.

Obviously the CI system can not offer substitutes in advance for a
world-rebuilding change!  :-)

I feel slightly offended by being asked to try your untested patch.  Are
you under the impression that I _don't_ have to rebuild the world?

Thanks anyway, closing this issue as I am fairly confident it is solved.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#39318: [core-updates] 'make-desktop-entry-file' is not exported

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Obviously the CI system can not offer substitutes in advance for a
> world-rebuilding change!  :-)
>
> I feel slightly offended by being asked to try your untested patch.  Are
> you under the impression that I _don't_ have to rebuild the world?

Duh, my bad, sorry I was probably too distracted with other things at
Guix Days, I completely missed that the world obviously had to be rebuilt.
I guess I'm not used to dealing with core-updates :p

Actually, this brings up a genuine question: how do you test core-updates
for these type of changes?  Do we really have a rebuild the whole thing on
every iteration?

Cheers, and sorry for the mishaps!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#39318: [core-updates] 'make-desktop-entry-file' is not exported

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Obviously the CI system can not offer substitutes in advance for a
>> world-rebuilding change!  :-)
>>
>> I feel slightly offended by being asked to try your untested patch.  Are
>> you under the impression that I _don't_ have to rebuild the world?
>
> Duh, my bad, sorry I was probably too distracted with other things at
> Guix Days, I completely missed that the world obviously had to be rebuilt.
> I guess I'm not used to dealing with core-updates :p
>
> Actually, this brings up a genuine question: how do you test core-updates
> for these type of changes?  Do we really have a rebuild the whole thing on
> every iteration?

Changing (guix build utils) is an extreme case, but pretty much.  I keep
a TODO list of things I want to do on that branch, and once it gets big
enough, I try to implement all at once before starting the Big Rebuild.

Then go do something else until a node in the graph fails to build.
Berlin typically has substitutes all the way up to 'guix', so it's "not
that bad" unless you are changing the really low layers.

> Cheers, and sorry for the mishaps!

No worries, and sorry for the angry comment.  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]