From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:48078)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFIXD-0004o0-4M
 for guix-patches@gnu.org; Fri, 20 Mar 2020 10:22:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFIXB-0001XV-Ut
 for guix-patches@gnu.org; Fri, 20 Mar 2020 10:22:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39363)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFIXB-0001XP-Px
 for guix-patches@gnu.org; Fri, 20 Mar 2020 10:22:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFIXB-0007kR-MI
 for guix-patches@gnu.org; Fri, 20 Mar 2020 10:22:01 -0400
Subject: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase.
Resent-Message-ID: <handler.40143.B40143.158471408629725@debbugs.gnu.org>
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
References: <20200320092005.22388-1-brice@waegenei.re>
 <20200320105406.42ba348b@scratchpost.org>
Date: Fri, 20 Mar 2020 10:21:14 -0400
In-Reply-To: <20200320105406.42ba348b@scratchpost.org> (Danny Milosavljevic's
 message of "Fri, 20 Mar 2020 10:54:06 +0100")
Message-ID: <87blor3y5h.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Brice Waegeneire <brice@waegenei.re>, 40143@debbugs.gnu.org

Danny Milosavljevic <dannym@scratchpost.org> writes:

> invoke already returns #t, so there's no technical bug.
>
> That said, maybe for clarity?  Not sure...

I don't see any technical nor clarity issue here.  The vision laid out
by Mark more than two years ago (!) was to get rid of all the boolean
return codes and move to an exception based system entirely, which I
find much more elegant.  The transition plan was outlined in this
message:
https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html.

I think we should go back to work on finishing the missing bits :-).

Maxim