From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: bug#39869: python-orator build fails Date: Fri, 20 Mar 2020 21:41:06 -0400 Message-ID: <87bloq4h8t.fsf@gmail.com> References: <87mu8y635i.fsf@gmail.com> <87a74a7lb6.fsf@devup.no> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:43590) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFT9H-0000yK-7U for bug-guix@gnu.org; Fri, 20 Mar 2020 21:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFT9G-0005XE-9W for bug-guix@gnu.org; Fri, 20 Mar 2020 21:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFT9G-0005X6-6S for bug-guix@gnu.org; Fri, 20 Mar 2020 21:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jFT9G-0002fj-5j for bug-guix@gnu.org; Fri, 20 Mar 2020 21:42:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87a74a7lb6.fsf@devup.no> (Marius Bakke's message of "Fri, 20 Mar 2020 22:45:01 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Marius Bakke Cc: 39869-done@debbugs.gnu.org Hey Marius! Marius Bakke writes: > This was a surprisingly deep rabbit hole that ended pretty > unsatisfactory with commit 51d42caa94515f43d677bdd76d53bf8bb8c7bc4e. > > According to a comment in the package definition, the tests were never > supposed to run, so in the end they were just disabled. > > I discovered a pattern that I hadn't seen yet in the Python ecosystem: > orator and many of its dependencies are no longer using setup.py. > Instead they have a file called pyproject.toml and calls out to a tool > called "poetry" to create distribution tarballs, run tests, etc; and it > apparently also creates a setup.py for the PyPI distribution. Interesting! > I did not study poetry enough to figure out how it works, but we might > need a poetry-build-system or some such if the trend continues. Mainly > because all packages using it seem to be stripping tests from the PyPI > release! :-/ Yeah. Or make the python-build-system smart at detecting many situations (as we discussed on IRC today such as guessing how to run the test suite). Thanks for fixing it! Maxim