From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:46176)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jHOrr-00027p-C9
 for guix-patches@gnu.org; Thu, 26 Mar 2020 05:32:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jHOrq-0004Bg-DP
 for guix-patches@gnu.org; Thu, 26 Mar 2020 05:32:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:52144)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jHOrq-0004BP-8q
 for guix-patches@gnu.org; Thu, 26 Mar 2020 05:32:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jHOrq-0003RU-6k
 for guix-patches@gnu.org; Thu, 26 Mar 2020 05:32:02 -0400
Subject: [bug#34638] [PATCH v2 3/4] inferior: Add a shared-directory field to
 <inferior>
Resent-Message-ID: <handler.34638.B34638.158521506513123@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190419140427.15183-1-mail@cbaines.net>
 <20190419140427.15183-3-mail@cbaines.net>
Date: Thu, 26 Mar 2020 10:30:57 +0100
In-Reply-To: <20190419140427.15183-3-mail@cbaines.net> (Christopher Baines's
 message of "Fri, 19 Apr 2019 15:04:26 +0100")
Message-ID: <87blojea3y.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 34638@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> skribis:

> ---
>  guix/inferior.scm | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)

Commit log please.  :-)

> +  (pid              inferior-pid)
> +  (socket           inferior-socket)
> +  (close            inferior-close-socket)       ;procedure
> +  (shared-directory inferior-shared-directory)

Please add a margin comment like =E2=80=9C#f | directory=E2=80=9D.

> -(define* (port->inferior pipe #:optional (close close-port))
> +(define* (port->inferior pipe shared-directory #:optional (close close-p=
ort))
>    "Given PIPE, an input/output port, return an inferior that talks over =
PIPE.
>  PIPE is closed with CLOSE when 'close-inferior' is called on the returned
>  inferior."

Make =E2=80=98shared-directory=E2=80=99 a keyword argument?

(Otherwise there=E2=80=99s a user in (guix ssh) that needs to be updated.)

>           ((client . address)
>            (proxy client (store-connection-socket store))))
>         (close-port socket)
> -       (read-inferior-response inferior)))))
> +       (read-inferior-response inferior)))
> +   #:base-directory (inferior-shared-directory inferior)))

What if =E2=80=98inferior-shared-directory=E2=80=99 returns #f?

Otherwise LGTM.

Ludo=E2=80=99.