From: Tobias Geerinckx-Rice <me@tobias.gr>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/6] gnu: cgit: Make some inputs native.
Date: Wed, 01 Apr 2020 01:07:55 +0200 [thread overview]
Message-ID: <87blocjf78.fsf@nckx> (raw)
In-Reply-To: <20200331220439.3828-1-vincent.legoll@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2163 bytes --]
Vincent,
Thank you!
This list is for general Guix discussion. Although that can
sometimes include rough patches (heh), please send any future
contributions to our patch tracker at guix-patches@gnu.org — after
carefully reading the ‘Submitting Patches’ section of the Guix
manual.
Vincent Legoll 写道:
> * gnu/packages/version-control.scm (cgit)[native-inputs]: New
> field.
This is no new field. Neither are those of mailutils, iwd, or
graphviz!
Please rewrite all commit messages as either
* gnu/packages/version-control.scm (cgit)[inputs]: Move groff &
python-docutils from here…
[native-inputs]: …to this new field.
or
* gnu/packages/version-control.scm (cgit)[inputs]: Move groff &
python-docutils from here…
[native-inputs]: …to here.
although to be honest, I only ever use the latter format unless
I'm feeling particularly pedantic.
> [inputs]: Move groff & python-docutils to native-inputs.
If we run
$ guix gc --references `guix build cgit`
we can see that both groff and python-docutils are part of cgit's
closure. This means they must to be able to run… at run time :-o
Oh dear.
python-docutils's ‘rst2html.py’ is required by cgit's
/lib/cgit/filters/html-converters/rst2html, and groff itself by
cgit's /lib/cgit/filters/html-converters/man2html. Both of these
uses look legitimate to me: they weren't accidentally captured by
a stray environment variable or overzealous wrapper.
Now, it's still possible that either or both of these dependents
must *also* run at build time, and for that they would need to be
native indeed. Unfortunately:
$ guix build cgit --target=mips64el-linux-gnu
guix build: error: gnu/packages/python-xyz.scm:2950:2:
python-docutils@0.16: build system `python' does not support
cross
builds
I could ignore that and pretend that all Python packages are
safely architecture-independent (they're not) to continue
investigating, but I'm out of time.
I don't think this particular patch adds any value at this time,
so let's drop it.
The rest LGTM!
Kind regards,
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-03-31 23:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 23:11 native or not Vincent Legoll
2020-03-30 6:57 ` Mathieu Othacehe
2020-03-30 21:25 ` Vincent Legoll
2020-03-30 22:07 ` Vincent Legoll
2020-03-31 7:45 ` Mathieu Othacehe
2020-03-31 8:02 ` Vincent Legoll
2020-03-31 9:17 ` Vincent Legoll
2020-03-31 17:54 ` Christopher Baines
2020-03-31 7:27 ` Mathieu Othacehe
2020-03-31 9:44 ` Tobias Geerinckx-Rice
2020-03-31 9:51 ` Vincent Legoll
2020-03-31 13:25 ` Marius Bakke
2020-03-31 22:01 ` Vincent Legoll
2020-03-31 22:04 ` [PATCH 1/6] gnu: cgit: Make some inputs native Vincent Legoll
2020-03-31 22:04 ` [PATCH 2/6] gnu: darktable: " Vincent Legoll
2020-04-01 13:58 ` Mathieu Othacehe
2020-04-01 14:15 ` Tobias Geerinckx-Rice
2020-03-31 22:04 ` [PATCH 3/6] gnu: graphviz: " Vincent Legoll
2020-03-31 22:04 ` [PATCH 4/6] gnu: iwd: " Vincent Legoll
2020-03-31 22:04 ` [PATCH 5/6] gnu: mailutils: " Vincent Legoll
2020-04-01 14:03 ` Mathieu Othacehe
2020-03-31 22:04 ` [PATCH 6/6] gnu: nethack: " Vincent Legoll
2020-04-01 14:06 ` Mathieu Othacehe
2020-03-31 23:07 ` Tobias Geerinckx-Rice [this message]
2020-04-01 13:52 ` [PATCH 1/6] gnu: cgit: " Mathieu Othacehe
2020-04-01 14:13 ` Tobias Geerinckx-Rice
2020-04-01 14:20 ` Mathieu Othacehe
2020-04-01 17:59 ` Vincent Legoll
2020-04-01 19:23 ` native or not Tobias Geerinckx-Rice
2020-04-01 21:28 ` Vincent Legoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blocjf78.fsf@nckx \
--to=me@tobias.gr \
--cc=guix-devel@gnu.org \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.