From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:47644)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBfm-0002m3-LK
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:28:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBfm-0000T9-6c
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:28:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39767)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jRBfl-0000T2-S1
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:28:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBfl-0006jS-N5
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:28:01 -0400
Subject: [bug#40677] [PATCH 04/18] gnu: Add libnatpmp.
Resent-Message-ID: <handler.40677.B40677.158754766725848@debbugs.gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
References: <20200421161032.1847-1-tona_kosmicznego_smiecia@interia.pl>
 <20200421161032.1847-4-tona_kosmicznego_smiecia@interia.pl>
Date: Wed, 22 Apr 2020 11:27:37 +0200
In-Reply-To: <20200421161032.1847-4-tona_kosmicznego_smiecia@interia.pl> (Jan
 Wielkiewicz's message of "Tue, 21 Apr 2020 18:10:18 +0200")
Message-ID: <87blnjq392.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
Cc: 40677@debbugs.gnu.org


> +         (delete 'configure)
> +         (delete 'check))

Please add a ;no tests comment.

I guess we are dealing with a raw Makefile here. This is bad news
because it means that cross-compilation is almost always broken.

You can run:

--8<---------------cut here---------------start------------->8---
guix build --target=aarch64-linux-gnu libnatpmp
--8<---------------cut here---------------end--------------->8---

to check it. Then, you probably need to do something similar as what is
done in package "iw" (set CC variable at least).


> +       #:make-flags
> +       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))))
> +    (home-page "http://miniupnp.free.fr/libnatpmp.html")
> +    (synopsis "C library implementing NAT-PMP")
> +    (description
> +     "libnatpmp is a portable and asynchronous implementaiton of
           ^
       @code{libnatpmp}                                    ^
                                                          typo
Thanks,

Mathieu