bug#40604: http-parser 2.9.4 fails to build on armhf-linux

bug#40604: http-parser 2.9.4 fails to build on armhf-linux

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1663 bytes --]

The update to http-parser in 62f7f0d636d3b3ff796263ab892ebf53263539fa
causes a test failure armhf-linux:

--8<---------------cut here---------------start------------->8---
starting phase `check'
gcc  -I. -DHTTP_PARSER_STRICT=1  -Wall -Wextra -Werror -O0 -g  -c http_parser.c -o http_parser_g.o
gcc  -I. -DHTTP_PARSER_STRICT=1  -Wall -Wextra -Werror -O0 -g  -c test.c -o test_g.o
gcc  -I. -DHTTP_PARSER_STRICT=0  -Wall -Wextra -Werror -O3  -c http_parser.c
gcc  -I. -DHTTP_PARSER_STRICT=0  -Wall -Wextra -Werror -O3  -c test.c -o test.o
gcc  -shared -Wl,-soname=libhttp_parser.so.2.9 -o libhttp_parser.so.2.9.4 libhttp_parser.o
gcc -Wall -Wextra -Werror -O0 -g   http_parser_g.o test_g.o -o test_g
gcc -Wall -Wextra -Werror -O3   http_parser.o test.o -o test_fast
./test_g
test_g: test.c:4237: main: Assertion `sizeof(http_parser) == 4 + 4 + 8 + 2 + 2 + 4 + sizeof(void *)' failed.
make: *** [Makefile:76: test] Aborted

Test suite failed, dumping logs.
command "make" "test" "-j" "4" "PREFIX=/gnu/store/qlis9jzgcdk1m48hjdzag6gij244cwvz-http-parser-2.9.4" "CC=gcc" "library" failed with status 2
builder for `/gnu/store/gzywh6bmn10ip49yklmiagsjfcr2jflf-http-parser-2.9.4.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

The assert is new in 2.9.4 (one of two commits since 2.9.3):

https://github.com/nodejs/http-parser/commit/714cbb2dfbea9a521960b82b6239a991a64e3b9a

I can't tell what causes the size difference on armhf and don't
currently have access to hardware or QEMU for testing.  Any takers?

Meanwhile I've reverted the commit on 'master' as this is a dependency
of libgit2 which is needed for 'guix pull'.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#40604: http-parser 2.9.4 fails to build on armhf-linux

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Marius,

Marius Bakke 写道：
> The update to http-parser in 
> 62f7f0d636d3b3ff796263ab892ebf53263539fa
> causes a test failure armhf-linux:

[…]

> Meanwhile I've reverted the commit on 'master' as this is a 
> dependency
> of libgit2 which is needed for 'guix pull'.

Thank you!

> I can't tell what causes the size difference on armhf and don't
> currently have access to hardware or QEMU for testing.  Any 
> takers?

No access to Qemu?  That's no fun.

I'm going to punt: debugging an arch I know nothing about is an 
inefficient of time.  I only waste my time efficiently.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#40604: http-parser 2.9.4 fails to build on armhf-linux

[Ricardo Wurmus]

Marius Bakke <mbakke@fastmail.com> writes:

> The update to http-parser in 62f7f0d636d3b3ff796263ab892ebf53263539fa
> causes a test failure armhf-linux:

The same test failure happens on i686-linux.

-- 
Ricardo

bug#40604: http-parser 2.9.4 fails to build on armhf-linux

[Ricardo Wurmus]

Ricardo Wurmus <rekado@elephly.net> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> The update to http-parser in 62f7f0d636d3b3ff796263ab892ebf53263539fa
>> causes a test failure armhf-linux:
>
> The same test failure happens on i686-linux.

Actually, this might be a different failure:

    test_g: test.c:4240: main: Assertion `sizeof(http_parser) == 32' failed.

This prevents me from running “guix pull” on my i686 machines.

-- 
Ricardo

bug#40604: http-parser 2.9.4 fails to build on armhf-linux

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

Ricardo, Marius,

Ricardo Wurmus 写道：
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> The update to http-parser in 
>>> 62f7f0d636d3b3ff796263ab892ebf53263539fa
>>> causes a test failure armhf-linux:
>>
>> The same test failure happens on i686-linux.
>
> Actually, this might be a different failure:
>
>     test_g: test.c:4240: main: Assertion `sizeof(http_parser) == 
>     32' failed.

Neither, or both, or whatever.  It's the fix for the armhf failure 
(5c30eb61) that in turn causes a failure on i686 because there the 
struct *is* a mere 28 bytes.

Fixed in f2de892b375d30ad79502509a47a15f0f4d68fee by applying the 
fix only on armhf.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#40604: http-parser 2.9.4 fails to build on armhf-linux

[Ricardo Wurmus]

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Ricardo, Marius,
>
> Ricardo Wurmus 写道：
>>> Marius Bakke <mbakke@fastmail.com> writes:
>>>
>>>> The update to http-parser in
>>>> 62f7f0d636d3b3ff796263ab892ebf53263539fa
>>>> causes a test failure armhf-linux:
>>>
>>> The same test failure happens on i686-linux.
>>
>> Actually, this might be a different failure:
>>
>>     test_g: test.c:4240: main: Assertion `sizeof(http_parser) ==
>> 32' failed.
>
> Neither, or both, or whatever.  It's the fix for the armhf failure
> (5c30eb61) that in turn causes a failure on i686 because there the
> struct *is* a mere 28 bytes.
>
> Fixed in f2de892b375d30ad79502509a47a15f0f4d68fee by applying the fix
> only on armhf.

Thank you!  That got me past “guix pull” on my i686-linux netbook.

-- 
Ricardo