From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gGmoCYlJ116TBQAA0tVLHw (envelope-from ) for ; Wed, 03 Jun 2020 06:56:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4CF2BYlJ117EQQAAB5/wlQ (envelope-from ) for ; Wed, 03 Jun 2020 06:56:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A96279401CB for ; Wed, 3 Jun 2020 06:56:07 +0000 (UTC) Received: from localhost ([::1]:40600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgNJk-0005OT-RG for larch@yhetil.org; Wed, 03 Jun 2020 02:56:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgNJi-0005OF-3G for guix-patches@gnu.org; Wed, 03 Jun 2020 02:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgNJh-0002yz-Q8 for guix-patches@gnu.org; Wed, 03 Jun 2020 02:56:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgNJh-0006A0-Ox for guix-patches@gnu.org; Wed, 03 Jun 2020 02:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41637] [PATCH] gnu: Add hashcash. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Jun 2020 06:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41637 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Cc: 41637@debbugs.gnu.org Received: via spool by 41637-submit@debbugs.gnu.org id=B41637.159116735223664 (code B ref 41637); Wed, 03 Jun 2020 06:56:01 +0000 Received: (at 41637) by debbugs.gnu.org; 3 Jun 2020 06:55:52 +0000 Received: from localhost ([127.0.0.1]:41783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgNJX-00069c-RO for submit@debbugs.gnu.org; Wed, 03 Jun 2020 02:55:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgNJW-00069I-4u for 41637@debbugs.gnu.org; Wed, 03 Jun 2020 02:55:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35365) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgNJQ-0002wW-7n; Wed, 03 Jun 2020 02:55:44 -0400 Received: from [2a01:e0a:fa:a50:7059:39d8:75e4:ec1a] (port=43954 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jgNJN-0004Vp-Sl; Wed, 03 Jun 2020 02:55:43 -0400 From: Mathieu Othacehe References: <20200601004015.21684-1-kuba@kadziolka.net> Date: Wed, 03 Jun 2020 08:55:39 +0200 In-Reply-To: <20200601004015.21684-1-kuba@kadziolka.net> ("Jakub \=\?utf-8\?B\?S8SFZHppb8WCa2EiJ3M\=\?\= message of "Mon, 1 Jun 2020 02:40:15 +0200") Message-ID: <87blm07i50.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: zUOEsbQ4eji0 Hey Jakub, Thanks for fixing the cross-compilation, a full review this time :) > + (let* ((outdir (assoc-ref outputs "out")) > + (bindir (string-append outdir "/bin")) > + (mandir (string-append outdir "/share/man/man1")) > + (docdir (string-append outdir "/share/doc/hashcash-" ,version))) > + ;; make install assumes /usr and doesn't provide a way to override it > + (install-file "hashcash" bindir) > + (install-file "hashcash.1" mandir) > + (install-file "README" docdir) > + (install-file "LICENSE" docdir) > + (install-file "CHANGELOG" docdir) I think you can set the variables INSTALL_PATH, MAN_INSTALL_PATH and DOC_INSTALL_PATH instead. > + #t)))))) > + (home-page "https://www.hashcash.org/") > + (synopsis "Denial-of-service countermeasure") > + (description "Hashcash is a proof-of-work algorithm, which has been used > +as a denial-of-service countermeasure technique in a number of systems. You can remove "in a number of systems". > +A hashcash stamp constitutes a proof-of-work which takes a parametrizable > +amount of work to compute for the sender. The recipient can verify received > +hashcash stamps efficiently. > + > +This package contains a command-line tool for computing and verifying hashcash > +stamps.") > + (license license:public-domain))) I'm also concerned by this line in the Makefile: --8<---------------cut here---------------start------------->8--- # request static link of -lcrypto only LIBCRYPTO=/usr/lib/libcrypto.a --8<---------------cut here---------------end--------------->8--- We should maybe add "openssl" to the inputs and fix this variable (that's what Nix does). Thanks, Mathieu