From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QLnaCEzU9V6/UgAA0tVLHw (envelope-from ) for ; Fri, 26 Jun 2020 10:56:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MBSKBEzU9V50MgAAbx9fmQ (envelope-from ) for ; Fri, 26 Jun 2020 10:56:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7FF1F9404D7 for ; Fri, 26 Jun 2020 10:56:11 +0000 (UTC) Received: from localhost ([::1]:51234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jom1h-0002Wv-S7 for larch@yhetil.org; Fri, 26 Jun 2020 06:56:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jom1a-0002U5-Ja for guix-patches@gnu.org; Fri, 26 Jun 2020 06:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jom1a-0004kC-A2 for guix-patches@gnu.org; Fri, 26 Jun 2020 06:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jom1a-0004E4-94 for guix-patches@gnu.org; Fri, 26 Jun 2020 06:56:02 -0400 Subject: bug#41695: [PATCH] Update Go to v1.14.4 Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 26 Jun 2020 10:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41695 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Katherine Cox-Buday , Jack Hill Cc: 41695-done@debbugs.gnu.org Mail-Followup-To: 41695@debbugs.gnu.org, mail@cbaines.net, cox.katherine.e@gmail.com Received: via spool by 41695-done@debbugs.gnu.org id=D41695.159316893016185 (code D ref 41695); Fri, 26 Jun 2020 10:56:02 +0000 Received: (at 41695-done) by debbugs.gnu.org; 26 Jun 2020 10:55:30 +0000 Received: from localhost ([127.0.0.1]:41932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jom13-0004Cz-P0 for submit@debbugs.gnu.org; Fri, 26 Jun 2020 06:55:30 -0400 Received: from mira.cbaines.net ([212.71.252.8]:32954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jom12-0004Cq-1A for 41695-done@debbugs.gnu.org; Fri, 26 Jun 2020 06:55:28 -0400 Received: from localhost (unknown [46.237.174.39]) by mira.cbaines.net (Postfix) with ESMTPSA id E6BAD27BBE1; Fri, 26 Jun 2020 11:55:26 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 59b814b2; Fri, 26 Jun 2020 10:55:24 +0000 (UTC) References: <87d06c0zza.fsf@gmail.com> User-agent: mu4e 1.4.10; emacs 26.3 From: Christopher Baines In-reply-to: Date: Fri, 26 Jun 2020 11:55:21 +0100 Message-ID: <87bll66qqu.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: z92Oz3OM/cY6 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jack Hill writes: > On Sat, 6 Jun 2020, Katherine Cox-Buday wrote: > >> Jack Hill writes: >> >> You're welcome! Thanks for the review. I wish I had more time to >> contribute to Guix. >> >> I suppose I should have qualified my statement by saying there's too >> many dependent Go packages for me to test. I should invest in a better >> computer :) > > More computing is nice, but in the meantime, I'm happy to be part of a > community of other Guix people who can provide extra cycles when > needed. > > I'd like to recognize the work Chris and Danjela are doing on Guix > Data Service to ease patch review as well. > >>> Reading through the Go release notes [1], the following change to the >>> net/url package caught my eye: >>> >>>> When parsing of a URL fails (for example by Parse or >>>> ParseRequestURI), the resulting Error message will now quote the >>>> unparsable URL. This provides clearer structure and consistency with >>>> other parsing errors. >>> >>> I think this could be the cause of the docker test failure. Should we >>> patch docker or perhaps try to update it? >> >> Spot on! I've updated docker and docker-cli. hyperledger-fabric depends >> on docker-cli and also continues to build. I've attached a patch which >> should supersede the prior patch. It updates go, docker, and docker-cli >> atomically. > > I'm happy to confirm that the revised path fixes the docker problem > here as well. > > [=E2=80=A6] > >>> I am curious, why switch to using git-fetch? >> >> `guix lint` now complains about downloading tarballs. I have also >> recently seen some chatter on the mailing list about preferring this. > > Right, I remember that thread, thanks! > > Hopefully a more experienced reviewer/committer will confirm that > everything looks good and push soon. Thanks for the patch Katherine, and thanks to doing some review Jack. I've had a look now, and pushed (with a small commit message changes): 6e9f8826087fbd824c546f6daad70f090fa1a8d7 Thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl711BlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xd0Iw/+O/0Gz4dEImd+KApQXJeI6u/XUB8Mm0bbtxMPF6Wu1rGc24o1jIZDrV+T WIWhIOYGhRA429LWR38dBoKBNmvh7TGMqILpkpXEXTqRSIKQVehG3Zozun+VZpMn sTmugYLF0G5lTAz9Uwpr1NsaUwYxkZakNGHzcx25YkhWkgFWJBq6cif3R8rClbpW gGOQZHgL5G2YioqLa5eI91Cb0Xd9MUW97rLTiPs0Nr9B4cm5if5Py7CYJT84f1Ln 5ugbUbAaGPn5M5yTEGKErXw41Bk32vMFKe4tD8oeDtSCrN+tJ4ZEoho0cCzAm6m/ iJo/jkuuV+B8ge0e6oB6bym3N0qGaRozLmtn8MQsMjxLlhO/YiR7KKO2yEmuKvTa /bw8TSU7DmtSoLpsByeIdHZyoKsvEDvkl5nozXWe2EHf9KR2r+eXOOEVu+hfG15G oZOzjrAD50+KDh7kBWcbORFDuOTIDFg4HeJYgmvZOxels0QPF02fFAeTZWX/z/EI pkjLlcq65gOs1IVN1D4Ap16dt0M5svMi8BOrWspSd6Vm05ht+G9cjPyOUXjQvk3B Re8pDFQYDbRFcIjs2fOf0Be4vXuXgjSUR2g8q2vT4Na4niCviIfl5v25W59gfE4w LHMTN49DoJfZWGJB35tOdiWFFqAmBjrEeGR1qcP8lvH1qgVyAKw= =kifo -----END PGP SIGNATURE----- --=-=-=--