From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qNi3NWVSV2BbXQAA0tVLHw (envelope-from ) for ; Sun, 21 Mar 2021 14:04:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aICaMWVSV2DhEAAA1q6Kng (envelope-from ) for ; Sun, 21 Mar 2021 14:04:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 888691B7AC for ; Sun, 21 Mar 2021 15:04:21 +0100 (CET) Received: from localhost ([::1]:35230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNygm-0000jH-Nk for larch@yhetil.org; Sun, 21 Mar 2021 10:04:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNygc-0000jB-AC for guix-devel@gnu.org; Sun, 21 Mar 2021 10:04:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40176) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNygb-0000Mg-HT; Sun, 21 Mar 2021 10:04:09 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36736 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lNygY-0006I4-T9; Sun, 21 Mar 2021 10:04:07 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?L=C3=A9o?= Le Bouter Subject: Re: imagemagick@6.9.11-48 to graft or not to graft with 6.9.12-2 References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 1 Germinal an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 21 Mar 2021 15:04:05 +0100 In-Reply-To: (=?utf-8?Q?=22L=C3=A9o?= Le Bouter"'s message of "Fri, 19 Mar 2021 10:40:45 +0100") Message-ID: <87blbc38oa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616335461; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OsrhtF0lsg0mHB7D/LsuKHvKqlJbofR/yUe1hnxY7Eg=; b=LTzOprlqaVQKYRoVOnhA79jxuwXwaDuh44tPGiE9hjJfQat2O6c3d2dzMsB5Lr1o00LdaK vbh9BEHF5br+gNwwUU5DpEDdIzy7lQFv4NGlMAGTJVy9QzFcUTkTUzBseRknbXOwB9mZ5y JtGB0zEtzKcrH8BqoTcislaN73LWR+CllTYo8T/N6yDxNsMm9A6x05I7DlhFnLBn8KIME0 NISnTItdP22AhhTA2M3GaYOdrxsud3USEGXLHkBnHhWs0yCFWRPHBqjMn/P5UK17CUlSLT 7OWsBaRajWDvj1zWFopIeVl65oOcEo8wXrbDx57c2vWSyX1gVJeELbrEGb48gw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616335461; a=rsa-sha256; cv=none; b=FAG31+qvkkkgbiyIj6CafehcusKKEZtAe3w0DJG8+F6emZkoN6maiRLxIJtFYpEhGQkXic 1YkkEKKpd89YlyqitElIhfpnxKGvuG9ghp1fGAcBPLD5C9GMUFg1mJAWOKicxv2vY/iCt8 o7dJHfVkfUbrVFBQlsHe0tz2b1XNcYzdpUoo/5J0PqYhnxBFGlyJGzOedEmYTO8dcJDaOe iljLeIsrbEG5Uneg5bVAwrUjmXGCGcWppuyi7gpJxN61QpdjCL0ZGqvlbnyKLFK1N6SX/I fMKJZJ29ZykbfGYCI7iIz82Ut02P+sCrvZ7gTsyOdfZFR08pPlDsyylDyi4mfg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 888691B7AC X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: Q1xEtalKNj21 Hi L=C3=A9o, L=C3=A9o Le Bouter skribis: > See commit: 82e887ba48c2ba91b17aa9b6b17501e3e0ef4aef > > Following discussion around whether it is safe to graft and whether we > should do so or not, first, I apologize for not doing as rigorous > checking on this issue as I should have, and also requesting more peer- > review, I initially believed those two ImageMagick version were ABI > compatible with unchanged soname so it turns out it would be a rather > uncontroversial graft to make but now it turns out we have a changed > soname but whether it is binary (backwards) compatible or not remains a > question. Mistakes happen, that=E2=80=99s okay. However, the manual explicitly menti= ons =E2=80=9Ctrivial changes=E2=80=9D are acceptable without peer review, but a= s I wrote, those security updates rarely, if ever, qualify as =E2=80=9Ctrivial=E2=80= =9D: https://guix.gnu.org/manual/devel/en/html_node/Commit-Access.html > $ ./pre-inst-env guix environment --ad-hoc libabigail -- abidiff > $(./pre-inst-env guix build --no-grafts imagemagick@6.9.11-48 | grep -v > doc)/lib/libMagickCore-6.Q16.so.6 $(./pre-inst-env guix build=20 > imagemagick@6.9.12-2g | grep -v doc)/lib/libMagickCore-6.Q16.so.7 > ELF SONAME changed If upstream changed the SONAME, they probably had a reason. A library with a different SONAME cannot be used as a replacement, period. It=E2=80=99s also unclear to me that ImageMagick can be meaningfully grafte= d. Are there users of libMagick*.so in external packages? That seems unlikely. On berlin, I see this: --8<---------------cut here---------------start------------->8--- $ guix graph -t referrers /gnu/store/7iwx7rj1ipsbgb9wgimrrflniyxpilw3-image= magick-6.9.12-2g=20 digraph "Guix referrers" { "/gnu/store/7iwx7rj1ipsbgb9wgimrrflniyxpilw3-imagemagick-6.9.12-2g" [labe= l =3D "imagemagick-6.9.12-2g", shape =3D box, fontname =3D sans]; "/gnu/store/7iwx7rj1ipsbgb9wgimrrflniyxpilw3-imagemagick-6.9.12-2g" -> "/= gnu/store/7iwx7rj1ipsbgb9wgimrrflniyxpilw3-imagemagick-6.9.12-2g" [color = =3D darkviolet]; "/gnu/store/7iwx7rj1ipsbgb9wgimrrflniyxpilw3-imagemagick-6.9.12-2g" -> "/= gnu/store/wsw9an4lsnqxalwkvycxaa3y0ybp8rxp-ecl-ltk-0.992" [color =3D darkvi= olet]; "/gnu/store/wsw9an4lsnqxalwkvycxaa3y0ybp8rxp-ecl-ltk-0.992" [label =3D "e= cl-ltk-0.992", shape =3D box, fontname =3D sans]; "/gnu/store/wsw9an4lsnqxalwkvycxaa3y0ybp8rxp-ecl-ltk-0.992" -> "/gnu/stor= e/wsw9an4lsnqxalwkvycxaa3y0ybp8rxp-ecl-ltk-0.992" [color =3D peachpuff4]; } --8<---------------cut here---------------end--------------->8--- That means =E2=80=98ecl-ltk=E2=80=99 is the only package that keeps a refer= ence to ImageMagick, and thus, it=E2=80=99s the only one that would benefit from the graft. The graft is useless. To me that means we should revert this patch series (perhaps with the exception of bb2427fa28): 2e0ff59f0c gnu: imagemagick/fixed: Redirect old sonames to new sonames. bb2427fa28 gnu: ImageMagick: Refer to the version number in a more robust= way. bb5d84a048 gnu: ImageMagick: Fix version number in build configuration of= grafted replacement. 852ba914a4 gnu: imagemagick/fixed: Retain version length for successful g= rafting. 82e887ba48 gnu: imagemagick: Update to 6.9.12-2 [security fixes]. After that, what we can do, is introduce 6.9.12-2 as an additional public version of imagemagick. That way, users who run: guix install imagemagick get the newer version, the one that includes security fixes. Could you look into this? Thanks, Ludo=E2=80=99.