[bug#51980] [PATCH] Adding xlispstat.scm

[bug#51980] [PATCH] Adding xlispstat.scm

[Frank Pursel]

From d86ba6d5ed609cbe8b8814a13468e1410f8af726 Mon Sep 17 00:00:00 2001
From: Frank Pursel <purself@yahoo.com>
Date: Fri, 19 Nov 2021 11:55:02 -0800
Subject: [PATCH] Adding xlispstat.scm

---
 gnu/packages/xlispstat.scm | 83 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)
 create mode 100644 gnu/packages/xlispstat.scm

diff --git a/gnu/packages/xlispstat.scm b/gnu/packages/xlispstat.scm
new file mode 100644
index 0000000000..94f5b9863b
--- /dev/null
+++ b/gnu/packages/xlispstat.scm
@@ -0,0 +1,83 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2021 Frank Pursel <purself@yahoo.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages xlispstat)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix licenses)
+  #:use-module (gnu packages xorg)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages shells))
+
+(define-public xlispstat
+  (let ((xlispstat-version "3.52.23")
+        (guix-revision "0")
+        (commit "f1bea6053df658ee48612bf1f63c35de99e2c649"))
+    (package
+      (name "xlispstat")
+      (version (git-version xlispstat-version guix-revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/jhbadger/xlispstat")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1p0cmgy19kbkxia139cb5w9dnkp2cdqp5n3baag6cq3prn3n71mf"))
+                (file-name (git-file-name name version))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:parallel-build? #f
+         #:parallel-tests? #f
+         #:tests? #f
+         #:configure-flags
+         (list "--with-gcc")))
+      (inputs
+       `(("tcsh" ,tcsh)
+         ("libx11" ,libx11)
+         ("libxmu" ,libxmu)
+         ("libxext" ,libxext)
+         ("libxpm" ,libxpm)
+         ("libxaw" ,libxaw)
+         ("ncurses" ,ncurses)
+         ("gnuplot" ,gnuplot)))
+      (native-inputs `(("pkg-config" ,pkg-config)))
+      (synopsis "Statistical analysis environment with interactive graphics
+based on lisp")
+      (description "XLISP-STAT is a statistical environment based on a dialect
+of the Lisp language called XLISP.  To facilitate statistical computations,
+standard Lisp functions for addition, logarithms, etc., have been modified to
+operate on lists and arrays of numbers, and a number of basic statistical
+functions have been added.  Many of these functions have been written in Lisp,
+and additional functions can be added easily by a user.  Several basic forms
+of plots, including histograms, scatterplots, rotatable plots and scatterplot
+matrices are provided.  These plots support various forms of interactive
+highlighting operations and can be linked so points highlighted in one plot
+will be highlighted in all linked plots.  Interactions with the plots are
+controlled by the mouse, menus and dialog boxes.  An object-oriented
+programming system is used to allow menus, dialogs, and the response to mouse
+actions to be customized.")
+      (home-page "http://homepage.divms.uiowa.edu/~luke/xls/xlsinfo/")
+      (license expat))))
+
+;; See also https://www.cs.cmu.edu/afs/cs/project/ai-repository/ai/lang/lisp/impl/xlspstat/
+
+;; xlispstat
-- 
2.33.1

[bug#51980] [PATCH] Adding xlispstat.scm

[Liliana Marie Prikler]

Am Freitag, den 19.11.2021, 11:55 -0800 schrieb Frank Pursel:
> ---
>  gnu/packages/xlispstat.scm | 83 
If you're adding a package, that also needs to be recorded in
Makefile.am.  Also the ChangeLog is missing.

On a slightly related note, single-package files are usually a bad
idea.  Would it make sense to add this to lisp.scm, lisp-xyz.scm or
statistics.scm?
> ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 83 insertions(+)
>  create mode 100644 gnu/packages/xlispstat.scm
> 
> diff --git a/gnu/packages/xlispstat.scm b/gnu/packages/xlispstat.scm
> new file mode 100644
> index 0000000000..94f5b9863b
> --- /dev/null
> +++ b/gnu/packages/xlispstat.scm
> @@ -0,0 +1,83 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright =C2=A9 2021 Frank Pursel <purself@yahoo.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify
> it
> +;;; under the terms of the GNU General Public License as published
> by
> +;;; the Free Software Foundation; either version 3 of the License,
> or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public
> License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>
> ;.
> +
> +(define-module (gnu packages xlispstat)
> +  #:use-module (guix packages)
> +  #:use-module (guix git-download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix licenses)
> +  #:use-module (gnu packages xorg)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages ncurses)
> +  #:use-module (gnu packages maths)
> +  #:use-module (gnu packages shells))
> +
> +(define-public xlispstat
> +  (let ((xlispstat-version "3.52.23")
> +        (guix-revision "0")
> +        (commit "f1bea6053df658ee48612bf1f63c35de99e2c649"))
Guile is not Java.  revision and commit suffice, as does hard-coding
the base version as the first argument to git-version. 
> +    (package
> +      (name "xlispstat")
> +      (version (git-version xlispstat-version guix-revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/jhbadger/xlispstat")
> +                      (commit commit)))
> +                (sha256
> +                 (base32
> +                  "1p0cmgy19kbkxia139cb5w9dnkp2cdqp5n3baag6cq3prn3n7
> 1mf"))
> +                (file-name (git-file-name name version))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:parallel-build? #f
> +         #:parallel-tests? #f
> +         #:tests? #f
Any explanation on these flags?
> +         #:configure-flags
> +         (list "--with-gcc")))
> +      (inputs
> +       `(("tcsh" ,tcsh)
> +         ("libx11" ,libx11)
> +         ("libxmu" ,libxmu)
> +         ("libxext" ,libxext)
> +         ("libxpm" ,libxpm)
> +         ("libxaw" ,libxaw)
> +         ("ncurses" ,ncurses)
> +         ("gnuplot" ,gnuplot)))
> +      (native-inputs `(("pkg-config" ,pkg-config)))
> +      (synopsis "Statistical analysis environment with interactive
> graphics
> +based on lisp")
> +      (description "XLISP-STAT is a statistical environment based on
> a dia=
> lect
> +of the Lisp language called XLISP.  To facilitate statistical
> computations,
> +standard Lisp functions for addition, logarithms, etc., have been
> modified=
>  to
> +operate on lists and arrays of numbers, and a number of basic
> statistical
> +functions have been added.  Many of these functions have been
> written in L=
> isp,
> +and additional functions can be added easily by a user.  Several
> basic for=
> ms
> +of plots, including histograms, scatterplots, rotatable plots and
> scatterp=
> lot
> +matrices are provided.  These plots support various forms of
> interactive
> +highlighting operations and can be linked so points highlighted in
> one plot
> +will be highlighted in all linked plots.  Interactions with the
> plots are
> +controlled by the mouse, menus and dialog boxes.  An object-oriented
> +programming system is used to allow menus, dialogs, and the response
> to mo=
> use
> +actions to be customized.")
> +      (home-page "http://homepage.divms.uiowa.edu/~luke/xls/xlsinfo/
> ")
> +      (license expat))))
> +
> +;; See also 
> https://www.cs.cmu.edu/afs/cs/project/ai-repository/ai/lang/li=
> sp/impl/xlspstat/
> +
> +;; xlispstat
Don't leave trailing declarations, commented or uncommented in the
patch.

Cheers 

[bug#51980] [PATCH] Adding xlispstat.scm

[Liliana Marie Prikler]

Am Freitag, den 19.11.2021, 11:55 -0800 schrieb Frank Pursel:
> ---
>  gnu/packages/xlispstat.scm | 83 
If you're adding a package, that also needs to be recorded in
Makefile.am.  Also the ChangeLog is missing.

On a slightly related note, single-package files are usually a bad
idea.  Would it make sense to add this to lisp.scm, lisp-xyz.scm or
statistics.scm?
> ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 83 insertions(+)
>  create mode 100644 gnu/packages/xlispstat.scm
> 
> diff --git a/gnu/packages/xlispstat.scm b/gnu/packages/xlispstat.scm
> new file mode 100644
> index 0000000000..94f5b9863b
> --- /dev/null
> +++ b/gnu/packages/xlispstat.scm
> @@ -0,0 +1,83 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright =C2=A9 2021 Frank Pursel <purself@yahoo.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify
> it
> +;;; under the terms of the GNU General Public License as published
> by
> +;;; the Free Software Foundation; either version 3 of the License,
> or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public
> License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>
> ;.
> +
> +(define-module (gnu packages xlispstat)
> +  #:use-module (guix packages)
> +  #:use-module (guix git-download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix licenses)
> +  #:use-module (gnu packages xorg)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages ncurses)
> +  #:use-module (gnu packages maths)
> +  #:use-module (gnu packages shells))
> +
> +(define-public xlispstat
> +  (let ((xlispstat-version "3.52.23")
> +        (guix-revision "0")
> +        (commit "f1bea6053df658ee48612bf1f63c35de99e2c649"))
Guile is not Java.  revision and commit suffice, as does hard-coding
the base version as the first argument to git-version. 
> +    (package
> +      (name "xlispstat")
> +      (version (git-version xlispstat-version guix-revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/jhbadger/xlispstat")
> +                      (commit commit)))
> +                (sha256
> +                 (base32
> +                  "1p0cmgy19kbkxia139cb5w9dnkp2cdqp5n3baag6cq3prn3n7
> 1mf"))
> +                (file-name (git-file-name name version))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:parallel-build? #f
> +         #:parallel-tests? #f
> +         #:tests? #f
Any explanation on these flags?
> +         #:configure-flags
> +         (list "--with-gcc")))
> +      (inputs
> +       `(("tcsh" ,tcsh)
> +         ("libx11" ,libx11)
> +         ("libxmu" ,libxmu)
> +         ("libxext" ,libxext)
> +         ("libxpm" ,libxpm)
> +         ("libxaw" ,libxaw)
> +         ("ncurses" ,ncurses)
> +         ("gnuplot" ,gnuplot)))
> +      (native-inputs `(("pkg-config" ,pkg-config)))
> +      (synopsis "Statistical analysis environment with interactive
> graphics
> +based on lisp")
> +      (description "XLISP-STAT is a statistical environment based on
> a dia=
> lect
> +of the Lisp language called XLISP.  To facilitate statistical
> computations,
> +standard Lisp functions for addition, logarithms, etc., have been
> modified=
>  to
> +operate on lists and arrays of numbers, and a number of basic
> statistical
> +functions have been added.  Many of these functions have been
> written in L=
> isp,
> +and additional functions can be added easily by a user.  Several
> basic for=
> ms
> +of plots, including histograms, scatterplots, rotatable plots and
> scatterp=
> lot
> +matrices are provided.  These plots support various forms of
> interactive
> +highlighting operations and can be linked so points highlighted in
> one plot
> +will be highlighted in all linked plots.  Interactions with the
> plots are
> +controlled by the mouse, menus and dialog boxes.  An object-oriented
> +programming system is used to allow menus, dialogs, and the response
> to mo=
> use
> +actions to be customized.")
> +      (home-page "http://homepage.divms.uiowa.edu/~luke/xls/xlsinfo/
> ")
> +      (license expat))))
> +
> +;; See also 
> https://www.cs.cmu.edu/afs/cs/project/ai-repository/ai/lang/li=
> sp/impl/xlspstat/
> +
> +;; xlispstat
Don't leave trailing declarations, commented or uncommented in the
patch.

Cheers 

[bug#51980] [PATCH] Adding xlispstat.scm

[Frank Pursel]

From d39e627c9433e3193de1857a9c0f5b438082ba3f Mon Sep 17 00:00:00 2001
From: Frank Pursel <frank.pursel@gmail.com>
Date: Sun, 21 Nov 2021 09:29:18 -0800
Subject: [PATCH] Adding xlispstat

---
 gnu/packages/statistics.scm | 50 +++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index e69baee8bd..36d1030bc6 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com>
 ;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com>
 ;;; Copyright © 2021 Lars-Dominik Braun <lars@6xq.net>
+;;; Copyright © 2021 Frank Pursel <frank.pursel@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -67,6 +68,7 @@ (define-module (gnu packages statistics)
   #:use-module (gnu packages machine-learning)
   #:use-module (gnu packages maths)
   #:use-module (gnu packages multiprecision)
+  #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
@@ -74,6 +76,7 @@ (define-module (gnu packages statistics)
   #:use-module (gnu packages python-science)
   #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages readline)
+  #:use-module (gnu packages shells)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages ssh)
   #:use-module (gnu packages tcl)
@@ -6830,3 +6833,50 @@ (define-public r-desctools
 from contributed R packages as well.")
     (license license:gpl2+)))
 
+(define-public xlispstat
+  (let ((xlispstat-version "3.52.23")
+	(guix-revision "0")
+	(commit "f1bea6053df658ee48612bf1f63c35de99e2c649"))
+  (package
+   (name "xlispstat")
+   (version (git-version xlispstat-version guix-revision commit))
+   (source (origin
+	    (method git-fetch)
+	    (uri (git-reference
+		  (url "https://github.com/jhbadger/xlispstat.git")
+		  (commit commit)))
+	    (sha256
+	     (base32
+	      "1p0cmgy19kbkxia139cb5w9dnkp2cdqp5n3baag6cq3prn3n71mf"))))
+   (build-system gnu-build-system)
+   (arguments
+    `(#:parallel-build? #f   ; Parallel builds are not supported
+      #:parallel-tests? #f   
+      #:tests? #f            ; Pre-integrated testing source code.
+      #:configure-flags
+      (list "--with-gcc")))
+   (inputs `(("tcsh" ,tcsh)
+	     ("libx11" ,libx11)
+	     ("libxmu" ,libxmu)
+	     ("libxext" ,libxext)
+	     ("libxpm" ,libxpm)
+	     ("libxaw" ,libxaw)
+	     ("ncurses" ,ncurses)
+	     ("gnuplot" ,gnuplot)))
+   (native-inputs `(("pkg-config" ,pkg-config)))
+   (synopsis "Statistical analysis environment with interactive graphics based on lisp")
+   (description "XLISP-STAT is a statistical environment based on a dialect of the Lisp language called XLISP.  To facilitate statistical
+computations, standard Lisp functions for addition, logarithms, etc.,
+have been modified to operate on lists and arrays of numbers, and a
+number of basic statistical functions have been added.  Many of these
+functions have been written in Lisp, and additional functions can be
+added easily by a user.  Several basic forms of plots, including
+histograms, scatterplots, rotatable plots and scatterplot matrices are
+provided.  These plots support various forms of interactive
+highlighting operations and can be linked so points highlighted in one
+plot will be highlighted in all linked plots. Interactions with the
+plots are controlled by the mouse, menus and dialog boxes. An
+object-oriented programming system is used to allow menus, dialogs,
+and the response to mouse actions to be customized.")
+   (home-page "http://homepage.divms.uiowa.edu/~luke/xls/xlsinfo/")
+   (license expat))))
-- 
2.33.1

bug#51980: [PATCH] Adding xlispstat.scm

[Liliana Marie Prikler]

Pushed with the following adjustments:

Am Sonntag, den 21.11.2021, 13:10 -0800 schrieb Frank Pursel:
> From d39e627c9433e3193de1857a9c0f5b438082ba3f Mon Sep 17 00:00:00
> 2001
> From: Frank Pursel <frank.pursel@gmail.com>
> Date: Sun, 21 Nov 2021 09:29:18 -0800
> Subject: [PATCH] Adding xlispstat
> 
> ---
Added a commit message.
>  gnu/packages/statistics.scm | 50
> +++++++++++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/gnu/packages/statistics.scm
> b/gnu/packages/statistics.scm
> index e69baee8bd..36d1030bc6 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -14,6 +14,7 @@
>  ;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com>
>  ;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com
> >
>  ;;; Copyright © 2021 Lars-Dominik Braun <lars@6xq.net>
> +;;; Copyright © 2021 Frank Pursel <frank.pursel@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -67,6 +68,7 @@ (define-module (gnu packages statistics)
>    #:use-module (gnu packages machine-learning)
>    #:use-module (gnu packages maths)
>    #:use-module (gnu packages multiprecision)
> +  #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages pcre)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages pkg-config)
> @@ -74,6 +76,7 @@ (define-module (gnu packages statistics)
>    #:use-module (gnu packages python-science)
>    #:use-module (gnu packages python-xyz)
>    #:use-module (gnu packages readline)
> +  #:use-module (gnu packages shells)
>    #:use-module (gnu packages sphinx)
>    #:use-module (gnu packages ssh)
>    #:use-module (gnu packages tcl)
> @@ -6830,3 +6833,50 @@ (define-public r-desctools
>  from contributed R packages as well.")
>      (license license:gpl2+)))
>  
> +(define-public xlispstat
> +  (let ((xlispstat-version "3.52.23")
> +	(guix-revision "0")
> +	(commit "f1bea6053df658ee48612bf1f63c35de99e2c649"))
> +  (package
> +   (name "xlispstat")
> +   (version (git-version xlispstat-version guix-revision commit))
> +   (source (origin
> +	    (method git-fetch)
> +	    (uri (git-reference
> +		  (url "https://github.com/jhbadger/xlispstat.git")
> +		  (commit commit)))
> +	    (sha256
> +	     (base32
> +	      "1p0cmgy19kbkxia139cb5w9dnkp2cdqp5n3baag6cq3prn3n71mf")))
> )
> +   (build-system gnu-build-system)
> +   (arguments
> +    `(#:parallel-build? #f   ; Parallel builds are not supported
> +      #:parallel-tests? #f   
> +      #:tests? #f            ; Pre-integrated testing source code.
> +      #:configure-flags
> +      (list "--with-gcc")))
Enabled tests.
> +   (inputs `(("tcsh" ,tcsh)
> +	     ("libx11" ,libx11)
> +	     ("libxmu" ,libxmu)
> +	     ("libxext" ,libxext)
> +	     ("libxpm" ,libxpm)
> +	     ("libxaw" ,libxaw)
> +	     ("ncurses" ,ncurses)
> +	     ("gnuplot" ,gnuplot)))
> +   (native-inputs `(("pkg-config" ,pkg-config)))
> +   (synopsis "Statistical analysis environment with interactive
> graphics based on lisp")
> +   (description "XLISP-STAT is a statistical environment based on a
> dialect of the Lisp language called XLISP.  To facilitate statistical
> +computations, standard Lisp functions for addition, logarithms,
> etc.,
> +have been modified to operate on lists and arrays of numbers, and a
> +number of basic statistical functions have been added.  Many of
> these
> +functions have been written in Lisp, and additional functions can be
> +added easily by a user.  Several basic forms of plots, including
> +histograms, scatterplots, rotatable plots and scatterplot matrices
> are
> +provided.  These plots support various forms of interactive
> +highlighting operations and can be linked so points highlighted in
> one
> +plot will be highlighted in all linked plots. Interactions with the
> +plots are controlled by the mouse, menus and dialog boxes. An
> +object-oriented programming system is used to allow menus, dialogs,
> +and the response to mouse actions to be customized.")
Fixed indentation + minor wording.
> +   (home-page "http://homepage.divms.uiowa.edu/~luke/xls/xlsinfo/")
> +   (license expat))))
Used license:expat