From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kJ8aAWsitmHzEwEAgWs5BA (envelope-from ) for ; Sun, 12 Dec 2021 17:25:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qKZaOGoitmHoMgAAB5/wlQ (envelope-from ) for ; Sun, 12 Dec 2021 16:25:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7FA201DF59 for ; Sun, 12 Dec 2021 17:25:14 +0100 (CET) Received: from localhost ([::1]:58992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwRez-0000Up-O3 for larch@yhetil.org; Sun, 12 Dec 2021 11:25:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwReo-0000UQ-EM for guix-patches@gnu.org; Sun, 12 Dec 2021 11:25:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwReo-0003Zg-6T for guix-patches@gnu.org; Sun, 12 Dec 2021 11:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwRen-0000e1-UT for guix-patches@gnu.org; Sun, 12 Dec 2021 11:25:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v3 26/43] gnu: Add node-nan. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Dec 2021 16:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 51838@debbugs.gnu.org X-Debbugs-Original-Cc: 51838@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16393262892456 (code B ref -1); Sun, 12 Dec 2021 16:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Dec 2021 16:24:49 +0000 Received: from localhost ([127.0.0.1]:52972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwReb-0000dY-6y for submit@debbugs.gnu.org; Sun, 12 Dec 2021 11:24:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:60650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwReX-0000dH-JU for submit@debbugs.gnu.org; Sun, 12 Dec 2021 11:24:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwReX-0000Tt-EP for guix-patches@gnu.org; Sun, 12 Dec 2021 11:24:45 -0500 Received: from mout.gmx.net ([212.227.17.22]:55349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwReU-0003Yf-4Q for guix-patches@gnu.org; Sun, 12 Dec 2021 11:24:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1639326273; bh=/Hk/5+EJ3f1JOmJlkBwLczh/k8qMOxhUjkW0ZSslFQM=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=L2ZZAHhx2yh4dkghYLVG4ZDyPgfdRnksMdj8PwluT7NK7+gM5SU8xfW+PsC49jAX9 Y98+89r0TxQMlKYHPsbtkncRfy8C++PJyv7qmIuWHlU5R9T0YfLJg+Z1CmFd/URZNh FPYuTeIxXfkkNswsStAiHOYlC47f/g9llh5Fpf8s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N0oBx-1mZqnU0StJ-00wp7t; Sun, 12 Dec 2021 17:24:33 +0100 References: <46a042bc08eb72a068b1e8c69bfe28cf2d4b2e53.camel@gmail.com> <20211208202838.752542-1-philip@philipmcgrath.com> <20211208202838.752542-27-philip@philipmcgrath.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Pierre Langlois Date: Sun, 12 Dec 2021 16:17:45 +0000 In-reply-to: <20211208202838.752542-27-philip@philipmcgrath.com> Message-ID: <87bl1lyeo3.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:c6wW0VvmLrzrSAHAf6Hr/rnd9D8/8zgL81F0uqE4cP7mrg3tlc1 FutJerrSVVZ4eJBz4Qvct4C+yHH1VTMRPjy6XAlMZeUuBHzog5IWEVJQ2cysklnavSXsksj EsiRNbENe+rNj8sRX0+PydvKR7USD59gGoPzZX5Uw6faw7iifolnFvM33eW0Ct7qDoNue+e 6xzZKX+LZHMcRTEszlvGA== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZojZGpiqX1g=:nMGALg/gQUVk9f+22dV5c8 wK0Z9iJ6sbcVldgpThzem8YxgHxX/nQdXdJPcXKt4/fCrAFRyZAi9PLtuXlwuag3X8vu+Xkwc aqJ5SSqokv2z7pDG/UO29Ayf8yau4YNUwgoCgampEO1y3VUjnrC2pSWmK7g/KOJOODOFLerCN 6KjyOZlMIH4ktl7k4HoT81hwBDRApugTVIbQK2lWwauDQxauS1y+MB8sMgceNgnAMrIbEr7sF 96VmT7fqP+Jfhu8AIRXXLJMdTfpZIDp3abfCbP4RfPOfZI3jcqqyLZAdaJEFojIPWfvzB8IGo M7C3yzAiv2TbNFTsUZEeK9iNpn3/0mivBCBBix7Gkev8mzkukkXUugRbE6nvHUDZ92tISiXkQ znY8Hj5tA2QTL6BWP8X3r4EkBAGHMfBsLFAhpZjyzibUtmZsHqYHhBB1sWLCm5AE9amISZ3x4 mkOZs/CHu+LFw9JeJjl2ak404zYwEmzvhw4nlR7yFgq21HRRrOJ0ohyxhR3E7jOK2BVBa3lyI w7K/YSLjxqBL3Jix4hLw8GQ9MvJh3djhuRRWGv52TeRdcXD4x1UMiTTDAqhj+mEsz7m3MMoIc XwGL1YSP0p1BD3ImJgIZq+NRBHZwcOSS9hslz7gYRns/2WFBczDDjsD+v0IwzjW8Mk6Zc3Dpf m+qAa593CkeKoq2LdPPQulHxu0IzpXw+lTTodjjRzE0zbAumBNmg7dgpMNATT8CDHUW2Vchl4 k0OxPTIde8Vh5xIm7KOBnXvy9uk50JdPX23iRA23vNv264t2EPG7i0XzAxsJDmd6JJZAmnIrp Lg7Q9V+euY5Gd4mSzgnY9tIkwgrKCryfxFUCpjhGKmTyI5WB+JDu6BuOSoIS5VCRNBCfL9EGq l0cRdQabJv46lrzYfnR6x5/tX5J8nnLiZZMEiCbdYTwrM/xtMoyVGtioKTzqbjbZet7N8fzwm vNUZuVUjXGtHpZuXunihAeY+ocdSxt2R7fCU1z4/5zCUutUHobIoe9k7GWmf4xADKQa9KB2bN jnpgR50p+Vn19cgvvZPwtmZhs4xNlIIkHOxqldmgfPWw6cG9cxrh6WBH0obp8cBp6vpfaSiyA /Noba4Q1dqJhtI= Received-SPF: pass client-ip=212.227.17.22; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639326314; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=dqculMml4yRwjYrb5XR9EXM37CvpT3RGZ48aQhNtrds=; b=Jj1NWgOukItkYh3fwtsW661dM6st9IRpWvgve3Xej2Wq2fdWwqMIC6o1dVTKyW9irj3CfI gEl+SFuBaEADEHybfhcyUH0XfT0tUt7cJFt1Y3hGCGWYaqCiugnRI+Xupa+heKFqDTw4Uu bp9lQUu7d9CF/qc1XR87uTXvoeoMtBCzdCT5lvIAVJIX7pdx2vugXDvEqqvQ70A6YB5Pkm w5iZVMmCo/h2A1BN0vTAFWhxjvgGibhDjSzYAymFOEGJJywXOIO164fLnPLpF+dBYTeXNg lDHEPZnibNJpNC9PvzCKpKpdHQKcBylrhyC5Qpi41wGXVjerBhgOA0pabqA4Dw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639326314; a=rsa-sha256; cv=none; b=WH6ImjbNP5A3kzlDPfMkpNQMLsuVvaSkMlrZoUH+qktn+9QvVZ1H/HDvfz1HCQ9tWCTc3q y6dl+h8LYz39X+Cvmxpc/P3vZL8TxeLImTuw5oOH2bEZXWRgqQqWfAKqEuBQ4d0n9tBhvj Tj/ON8hcYtGLROOpkL071UAP10VhIHIT5k3lOPw7HbgKrKcDiPzT4+ZWFgkwu3pytkBZwI 7r+/6xKxzswVbOFfV8vNQ1ARgiwcEXE5sBaQtwMx3kzvwDETygIQFs0I3TDX6cA+DM6z2x 6zdtt2fADO/Zn6z5tKfCMzTI1MY3cxwnrP9UU7ocX5WwsBc2n79req+GxN3Uuw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=L2ZZAHhx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=L2ZZAHhx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7FA201DF59 X-Spam-Score: -4.17 X-Migadu-Scanner: scn1.migadu.com X-TUID: LPDMmNuw7P0d --=-=-= Content-Type: text/plain Philip McGrath writes: > * gnu/packages/node-xyz.scm (node-nan): New variable. > --- > gnu/packages/node-xyz.scm | 44 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm > index 3e06413908..ed169c0778 100644 > --- a/gnu/packages/node-xyz.scm > +++ b/gnu/packages/node-xyz.scm > @@ -553,3 +553,47 @@ (define-public node-irc > (description "@code{node-irc} is an IRC client library for Node.js. > It has functions for joining, parting, talking, and many other IRC commands.") > (license license:gpl3+))) > + > +(define-public node-nan > + (package > + (name "node-nan") > + (version "2.15.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/nodejs/nan") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "18xslh9va5ld872scrp5y4251ax9s3c6qh0lnl1200lpzbsxy7yd")))) > + (build-system node-build-system) > + (arguments > + `(#:tests? > + ;; tests need tap and other dependencies > + #f Formatting nit, you can write this all in one line: #:tests? #f ;; Tests need tap an other dependencies. > + #:absent-dependencies > + '("bindings" > + "commander" > + "glob" > + "request" > + "node-gyp" ;; would be needed for tests > + "tap" > + "xtend"))) > + (inputs > + `(("readable-stream" ,node-readable-stream))) > + (home-page "https://github.com/nodejs/nan") > + (synopsis "Native Abstractions for Node.js") > + (description "A header file filled with macro and utility goodness for > +making add-on development for Node.js easier across versions 0.8, 0.10, 0.12, > +1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 and 16. Given our packages only work with the node what Guix uses, you could remove the version numbers from the description. Mostly because we probalby won't think to update this description when future node releases appear. > + > +Thanks to the crazy changes in V8 (and some in Node core), keeping native > +addons compiling happily across versions, particularly 0.10 to 0.12 to 4.0, is > +a minor nightmare. I'd remove this sentence, it doesn't make much sense in Guix given we don't support older versions. > +The goal of this project is to store all logic necessary > +to develop native Node.js addons without having to inspect > +@code{NODE_MODULE_VERSION} and get yourself into a macro-tangle. > + > +This project also contains some helper utilities that make addon development a > +bit more pleasant.") > + (license license:expat))) Otherwise LGTM! I hope my comments make sense, I agree in general it's good to keep our description the same as upstream. But I think it's OK to reserve ourselves the right to tweak them a little bit, after all we provide a "curated" set of packages, not a direct mirror IMO :-). Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmG2IjwYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UQ48H/2RSZipqIuX6edb8m2sxKnGU COp6WOigZYt/hUh+MVh6ufH7enrGV2fUSHT2gKHKx+vQQQjSmuxkDOcOHSx1uQVR dGtOWdA+coc58SqSZ+YwtfTOqgEcipmrY2rKrxOVd2W7VDeN8tcyA0XxXT5thOLQ ap2S8U8lqt0mj7GZ9Hc6s25Luu2Pxm2IV0fs6iHhl/XwD3Rk8ctuRrL9V6FWCu97 iyGKyJVlRpJFzsbE5Za41bcU/6dDwGYoI9M+I1s5TN7HbiNQ75QBqU1WnoOFF5hV e6ylfzVa46ON71yYkJ/IjkGnXLxslD9GiuwPAGqUyE9jDk9qnIZZU5mhBg5q8UI= =u5OW -----END PGP SIGNATURE----- --=-=-=--