From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mAQ3Iup7BWIGoAAAgWs5BA (envelope-from ) for ; Thu, 10 Feb 2022 21:56:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gJzdHup7BWICpAAAauVa8A (envelope-from ) for ; Thu, 10 Feb 2022 21:56:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 311302D1B6 for ; Thu, 10 Feb 2022 21:56:10 +0100 (CET) Received: from localhost ([::1]:51560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIGU5-0002t6-Dq for larch@yhetil.org; Thu, 10 Feb 2022 15:56:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIGTy-0002sy-Aj for guix-patches@gnu.org; Thu, 10 Feb 2022 15:56:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nIGTy-0002t9-1w for guix-patches@gnu.org; Thu, 10 Feb 2022 15:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nIGTx-0003bC-Sb for guix-patches@gnu.org; Thu, 10 Feb 2022 15:56:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53837] [PATCH] gnu: Remove leftover patch files. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Feb 2022 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53837 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: Julien Lepiller , 53837@debbugs.gnu.org Received: via spool by 53837-submit@debbugs.gnu.org id=B53837.164452653513797 (code B ref 53837); Thu, 10 Feb 2022 20:56:01 +0000 Received: (at 53837) by debbugs.gnu.org; 10 Feb 2022 20:55:35 +0000 Received: from localhost ([127.0.0.1]:57318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIGTX-0003aS-1p for submit@debbugs.gnu.org; Thu, 10 Feb 2022 15:55:35 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:39092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIGTV-0003aD-2J for 53837@debbugs.gnu.org; Thu, 10 Feb 2022 15:55:33 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 35D15174; Thu, 10 Feb 2022 21:55:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TrjjWiJYX3LP; Thu, 10 Feb 2022 21:55:26 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 3A442AD3; Thu, 10 Feb 2022 21:55:26 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <34d7ac478fe7d852862e75e176f0297e139658b2.1644207641.git.leo@famulari.name> <20220208120655.4e10f5bb@tachikoma.lepiller.eu> <87zgn071tm.fsf_-_@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 =?UTF-8?Q?Pluvi=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 10 Feb 2022 21:55:25 +0100 In-Reply-To: (Leo Famulari's message of "Wed, 9 Feb 2022 11:45:19 -0500") Message-ID: <87bkze4f2a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 35D15174 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644526570; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=IGXfXByIH9O/se6H+Ey33hLmRnbADFBar6+QQKm+DZc=; b=CQYwkE3jF+NpZ51RRT479o6gQQ3KFMlCb8jB7QsL/PoUb3AxchYj06kIaVJdCKwuXxFdjN ntTu8/zNy53Znt0t64ScfWT7MBNFH8bzAAlsLA04cXsMtXuk2Lo1Dxz/e5tBX891Nk52eA TREstH2eMKkL4bh/5kDxb0D3pArO1b93bNmoiKRtkLe35QamRETsUgyf5NlcMzSKZn5Eio y3zxVhyI9mFmDbfShgMocY3L4GC1h5awSgh8xIhN/NxnWvkFQJ87o1dmcpQEPBuwhFKUpL bhn5TzIXRXt1e22xxn+qBEOlNBNnFbA1ZFFAaZrf+jPbnghMEGMuiCy0XpBQ7w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644526570; a=rsa-sha256; cv=none; b=c9JzptUHBlm1kQLi6vXSNWhOEi3Wve9XsGBm9t8SneU67ctWLENZ7GVQ1iLE2xg3MV3yFN gzww2jwhL+4yS5t2g3S6E4/1vW2Ok9aYTeVAkQz1p3s/xL/u4bAZLPMKqBBe//PLw7kbuq AKvkPYJLc0xIo6EqnAzOzkZmB32SczdfxPeKhvzpznzO7bJP04jJ+JS+/iokT2b7YXuBQ6 meOw/0pLRELdupDknZNyhi2Uztk6Szm7pwrHBwxt+SnDAuhbqDcGIFaXeJZA3OgnpGMKvJ RvdKdgChDjDue6y2PD8ewNcj9999kfX0KYZkaBIugfS3wb1KSHqSusuadHp7Fw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.63 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 311302D1B6 X-Spam-Score: -3.63 X-Migadu-Scanner: scn1.migadu.com X-TUID: cPRAw8OhpUEt Hi, Leo Famulari skribis: > On Wed, Feb 09, 2022 at 11:48:37AM +0100, Ludovic Court=C3=A8s wrote: >> Perhaps you can share the script that you used? That way we can review >> the script rather than its output. :-) > > Sure, I did this: > > `find gnu/packages/patches | while read patch; do git grep ${patch##gnu/p= ackages/patches/} gnu/packages >/dev/null || echo "${patch##gnu/packages/pa= tches/} is leftover?"; done` Looks reasonable to me. > I figure it could cause a problem if a patch file was used somewhere > besides 'gnu/packages', or if the patch file name was "constructed". We don=E2=80=99t have to worry about third-party channels. As for construc= ted file names, I don=E2=80=99t think there are any. To be on the safe side, you can run =E2=80=9Cmake as-derivation=E2=80=9D be= fore pushing. Of course that will only catch serious issues, but if other issues come up (unlikely), we=E2=80=99ll follow up. Thanks, Ludo=E2=80=99.