From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kCd/Mqm+XWKjAAAAbAwnHQ (envelope-from ) for ; Mon, 18 Apr 2022 21:40:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sJ94Mqm+XWIEwgAAauVa8A (envelope-from ) for ; Mon, 18 Apr 2022 21:40:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1F147A9F7 for ; Mon, 18 Apr 2022 21:40:25 +0200 (CEST) Received: from localhost ([::1]:60644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngXEV-0006oe-V0 for larch@yhetil.org; Mon, 18 Apr 2022 15:40:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngXEA-0006oU-4g for guix-patches@gnu.org; Mon, 18 Apr 2022 15:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngXE9-0007BB-Rf for guix-patches@gnu.org; Mon, 18 Apr 2022 15:40:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ngXE9-0000Eb-OJ for guix-patches@gnu.org; Mon, 18 Apr 2022 15:40:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54723] [PATCH] Check URI when verifying narinfo validity. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Apr 2022 19:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54723 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Guillaume Le Vaillant Cc: Simon Streit , 54723@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 54723-submit@debbugs.gnu.org id=B54723.1650310765850 (code B ref 54723); Mon, 18 Apr 2022 19:40:01 +0000 Received: (at 54723) by debbugs.gnu.org; 18 Apr 2022 19:39:25 +0000 Received: from localhost ([127.0.0.1]:40868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngXDZ-0000De-1D for submit@debbugs.gnu.org; Mon, 18 Apr 2022 15:39:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngXDW-0000DR-Lh for 54723@debbugs.gnu.org; Mon, 18 Apr 2022 15:39:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngXDQ-000792-Uc; Mon, 18 Apr 2022 15:39:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3UsLqNnPnz6cLTXs49GXosYGxTZsj+SvyYobXmFTGdw=; b=jyjqvQj71mly06AQv4BG fP58yAPY68ZF3N2HoXN/sTNX+2rIMjhYv6Jwgy3hRkxUPF7iki2fvwYjswThMWl4SZb7IkZGJwpUj aKQNmYvD3IqOdKSWILIqvXNa6ds51enLuVVRJpn9nz9K1ozmAqKSf/ES4XiycC9MaE9m1I/LYZQaf zu7qwM4Dgfu2f7KahNO4MbXKXuwvMR9Txl6DQzmRCVrAxJb4+n8TioLIFMR0wRpWEuBBxW1/1zyeg 8RF94zPBbFvJd2tACmLX+ZDeMgv65hDxGI9vk7weLZWMi8mGNvbE8oqapgDOqkVRT8/XgLZ5z9HDd mIo7oq6XossTuw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54459 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngXDQ-00023R-IO; Mon, 18 Apr 2022 15:39:16 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87a6czbzvh.fsf@kitej> <877d83lapv.fsf@gnu.org> <875ynnbe65.fsf@kitej> <87pmlq6lqx.fsf_-_@gnu.org> <877d7ydjwk.fsf@kitej> <87wnfv90cl.fsf@kitej> <871qy2g2v3.fsf@gnu.org> <87o816wt36.fsf@kitej> <87sfqfc0fq.fsf@kitej> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 Germinal an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 18 Apr 2022 21:39:14 +0200 In-Reply-To: <87sfqfc0fq.fsf@kitej> (Guillaume Le Vaillant's message of "Thu, 14 Apr 2022 12:18:51 +0000") Message-ID: <87bkwyxjtp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650310825; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3UsLqNnPnz6cLTXs49GXosYGxTZsj+SvyYobXmFTGdw=; b=ks53iDk7dCx9s34bEou7KlYOofVP5FhrZ+ORpRo2/16/dDF61BYFuVI/jagjpGq6tIoXnu vHpoF7rmFcTRbGah+dGIqno3/usq6mvKEMeIyBhwzMmOqqQ41n52zmmsvPJXKaEsrf/Iao uEPg0VdBrguBuFnk9uZogDckAfgYWjzLdrCd0zQxlVrQQ1fvuxHaKJ/GsWpn414iWFqo5G zaviG0iaSs7BtDXWiKW1WzTqtL5gmlAEtNNyx3T5uXaQtZIDqT6wXbyUwpgTGh3CBz3SiW Yi99ctzXDA/n+bskFlQALUuswd6Fpjma6coX4kpAp3FwgHBMH30vFxdVTTtXEg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650310825; a=rsa-sha256; cv=none; b=goMV3E8lAY1BtD/MBYHmTYE1TdMuAM2EPmbUJbgKHTJ4XywUb9G0/cSerUo+00gBcU5kip +2UUCglCFQGyic05ucSv7mfS7tctIcKqhgQZlw0WvOs9CzfLGG8sxlvUL+2Quyp+K2X69H tHNhRLNTZ3I7wP6JhcU5pxaI/1ol2JJrNWGp+GWqrEf1dymqmDtGzjBeZXbAkGkusLcr1K bB2QtNXnWZCg34d95bF2eynvvTL/aigwbg+g2GvgNOli8rSYQjX0XoNHNNLjuGKvaHvJEK oLfk06fvakHtotl+vXzxDduA7BmOeAqF/Lye9eQDqX2wlBZqtSZ2/IpukazzJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jyjqvQj7; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jyjqvQj7; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1F147A9F7 X-Spam-Score: -4.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: dmXdENsOA2d5 Hi! Guillaume Le Vaillant skribis: > I tested a few things, and it looks like there is a concurrency issue in > the 'http-write' function of the publish server. > After removing the 'call-with-new-thread' in the part of the function > sending narinfos, I can't reproduce the "broken pipe" error anymore. Ah ha! Little has changed in this code, so I think the culprit must be f743f2046be2c5a338ab871ae8666d8f6de7440b. Could you try running it from master with this patch reverted? You can spawn it from the build tree with: sudo -E ./pre-inst-env guix publish -u nobody Bonus points if you have a script to reproduce the issue. I guess that involves making pipelined keep-alive narinfo requests the way =E2=80=98guix substitute=E2=80=99 and =E2=80=98guix weather=E2=80=99 do. Thanks, Ludo=E2=80=99.