From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SEs6KL0EmWJ7JwAAbAwnHQ (envelope-from ) for ; Thu, 02 Jun 2022 20:43:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MB9CKL0EmWKeEwEA9RJhRA (envelope-from ) for ; Thu, 02 Jun 2022 20:43:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 552513E9C0 for ; Thu, 2 Jun 2022 20:43:08 +0200 (CEST) Received: from localhost ([::1]:59198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwpml-00034z-GH for larch@yhetil.org; Thu, 02 Jun 2022 14:43:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwpmg-00034o-GG for guix-patches@gnu.org; Thu, 02 Jun 2022 14:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwpmg-0003PP-7t for guix-patches@gnu.org; Thu, 02 Jun 2022 14:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwpmg-0001dw-5f for guix-patches@gnu.org; Thu, 02 Jun 2022 14:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55762] [PATCH] Upgrade linux-pam to 1.5.2 Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Jun 2022 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Felix Lechner Cc: 55762@debbugs.gnu.org X-Debbugs-Original-Cc: 55762@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 55762-submit@debbugs.gnu.org id=B55762.16541953616262 (code B ref 55762); Thu, 02 Jun 2022 18:43:02 +0000 Received: (at 55762) by debbugs.gnu.org; 2 Jun 2022 18:42:41 +0000 Received: from localhost ([127.0.0.1]:54592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwpmK-0001cw-Ry for submit@debbugs.gnu.org; Thu, 02 Jun 2022 14:42:41 -0400 Received: from tobias.gr ([80.241.217.52]:57194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwpmG-0001cl-S0 for 55762@debbugs.gnu.org; Thu, 02 Jun 2022 14:42:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=ib0nesmCH2eJn yscfmwqHN2Kqy3vs+Yd3D6mG4ITwwU=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=AbUZLvMFsPCZAe/l3jIVX9mPkdmfcahRnBBBbc pXwWZLkvhDFAGZlpTnzw6qtNCOIc3gAbAWOu2++Fif3g1f4l5EgokPC3d6QiFGy9iWfCWB jiER6B9ceipmJiKzbzR+PJ1458+si5Plo4ufqUiZ2jBvORxIj5GoU0gRTXiHZ6SrldioaJ XGzZF+y2Z4fbDnC4leMD9Jw3fEm5maCPteKbtt8tC6TkoBIrSpZ4JDe75n7vPWtfcMdpIW kC21KmHJsmAN2A2uPHBcMnmA0J7zelr/bt4GdSXaiyIdrIVq+sH52Ai1WZAHYZL5lCWyo+ Dc/XBU5kgDYBE2fnPp4OZqNg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id e83b77a7 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 2 Jun 2022 18:42:34 +0000 (UTC) References: Date: Thu, 02 Jun 2022 20:16:27 +0200 In-reply-to: BIMI-Selector: v=BIMI1; s=default; Message-ID: <87bkva9aat@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654195389; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ib0nesmCH2eJnyscfmwqHN2Kqy3vs+Yd3D6mG4ITwwU=; b=ABSnCn585K5I+yBFLWjrNzc3ZT/4ywR3ArJuU7iNqZ0jWjSrfVC1E4l6Ab+CiiV7eMyH/x CzZPYubXuoA6qbWPWAhSMxaSaDtfT6VCpLhdOnNM9CLfgYxOvcRLdSVJyQ29MDsmMcuBpA d2x49sqKhmF4XKxjZ3w0f4Rxk9NfLX1AMoA5y0FN+XdqJfB2s/G4fY89T7OWktDhyjOCsw SaaHEu7SIXp2bebepWZagmPhBVLfwHsWnb0FZ6XFbSOf/VOlyPq3L9ZWV1MYqFASeQeZeY abwhMT9o6vJ/ZPVJDAXwLSvhiqVdKusiyjOlDt5hPqpwVbyxEbJxwixpfoCdtQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654195389; a=rsa-sha256; cv=none; b=eqnqOiy/YWyHuulK3TcPC03DEMhsFi95vESrgvk/avv1lr+ItCMRFG2gUOb17SzRmV0zu8 4432wh6dXOZBJ0y6epQMuTi6LtYbQ/EVbsQWnBXVT1VkRsFYB5eRfE8zBGxbTpCU1lZiyb aRn+MI9TdFK9gIq/Zw2XgnjCYwUG6Y2fGLv5C3ZT9QYZZCi5+V3b3ZEzQEogV7Ki/7DQBF qy1Ts73RvNHmBKyGElkla6wvs7aQYzEV7cDIcYgL4zhKZ8dBzCKTdoYhpPb0kq1xzQueqW 2BP6NRTIzzMoaxCOtRaljh+5x60ruieIKAQ5on3oe9NCQlNALH9xKTV+dBiIKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=AbUZLvMF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.22 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=AbUZLvMF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 552513E9C0 X-Spam-Score: -6.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: tY9BXyB3CzHC --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Felix, Felix Lechner =E5=86=99=E9=81=93=EF=BC=9A > For my work in making PAM configurable in Guile, I rely on the=20 > foreign > function interface (FFI). The automatic generation of that=20 > interface > requires Pkgconfig files. Those files are not available in Guix. > Linux-PAM started shipping them in the release after the one we=20 > have. > The attached patch upgrades linux-pam to version 1.5.2. Thanks for working on both! > The changes are further documented in the commit message. And thanks for writing a clear commit message. A few thoughts: =2D The =E2=80=98gnu: foo: Update to x.y.z=E2=80=99 messages you see in the= Guix=20 commit history are standardised. The format's documented in the=20 GNU =E2=80=98(standards)Change Logs=E2=80=99 info page, but just take a s= troll=20 through the history to get a feel for the majority of cases. =2D Don't feel obligated to explain why you're upgrading a package,=20 although you're free to do so if you like (it was interesting=20 and I learnt something). Assuming no regressions, we always prefer to ship newer versions=20 of things. =2D And finally, a personal windmill of mine: > The extra argument to ./configure is needed to sidestep an issue > upstream.[1] belongs in the code, where your fellow hackers can see it, not=20 buried in the commit log where $nobody will: ;; Work around=20 . As you might now, this update rebuilds a good part of the world=20 and will have to pass through the core-updates branch=E2=80=A6 $ guix refresh -l linux-pam | cut -d: -f1 > I am new to Guix and already use the new version of linux-pam=20 > locally > (via Guix System) but I was unable to test the patch according=20 > to the > requirements and recommendations listed for this submission. [1] =E2=80=A6so it's impressive if you rebuilt most of your entire system=20 based on the new nyacc/linux-pam packages. What still needs to be done, and which problems did you encounter? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYpkEmg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15MWEBAKcm0YoPpP+Z+vxkhUDdTgary0pBKegpyDbjJWaa GaEwAP9RmN3Qex12Wt30yslDS4//yDCmZJ2LAQw6igyYTu3ZAA== =Ga8Z -----END PGP SIGNATURE----- --=-=-=--