From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id pUSYEkjzZWMMWAEAbAwnHQ (envelope-from ) for ; Sat, 05 Nov 2022 06:23:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2ECtEUjzZWO2MQEA9RJhRA (envelope-from ) for ; Sat, 05 Nov 2022 06:23:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5D7B1C580 for ; Sat, 5 Nov 2022 06:23:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orBeB-0003ZG-8W; Sat, 05 Nov 2022 01:23:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orBe2-0003Xe-Co for guix-patches@gnu.org; Sat, 05 Nov 2022 01:23:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orBe1-0002ts-Vx for guix-patches@gnu.org; Sat, 05 Nov 2022 01:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orBe1-0003C3-LR for guix-patches@gnu.org; Sat, 05 Nov 2022 01:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58730] [PATCH] Split emacs-piem and emacs-git-email Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Nov 2022 05:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58730 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: Declan Tsien , public@yoctocell.xyz, liliana.prikler@gmail.com, Andrew Tropin , 58730@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 58730-submit@debbugs.gnu.org id=B58730.166762572912184 (code B ref 58730); Sat, 05 Nov 2022 05:23:01 +0000 Received: (at 58730) by debbugs.gnu.org; 5 Nov 2022 05:22:09 +0000 Received: from localhost ([127.0.0.1]:55306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orBdB-0003AR-4i for submit@debbugs.gnu.org; Sat, 05 Nov 2022 01:22:09 -0400 Received: from out0.migadu.com ([94.23.1.103]:48895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orBd7-0003AD-Q1 for 58730@debbugs.gnu.org; Sat, 05 Nov 2022 01:22:07 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1667625723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dIdo4kDSkTdKvjMIL03H2zWrfLG6nMdkRVaw9U1iIKk=; b=onfiDfWfBqCCMy0VTNfu62DMrB1xLEzcOf6gVZzVt39C1iTad9w4xp9VE8LsEqHNCXt4rM MMz60c4K5lIpMYfNER6tE1w/osSkP9JntcEcGP+7jqyAIOHfuRUTaM6cAbDGTlojseIcvm 08OK4loZmd5ryreYV3dhB4zi2mBmpv1UDzcWLU8Rd+O/EbUaS2wya6DA7f5s7eUqs0y955 boaJGMCHOdamHCGwSx1UlLL1QNd9Ecst7h0X4Y8Lt6RoF1S2vdZxPNflufO1U3wGw6cJ9B 7eQpnBAP10OBriOxUH+HGO8rN5wdUVjmgTZkow2SJwj2HWDKUMfKRXr3x8bD3Q== From: Kyle Meyer In-Reply-To: <87leotb4xj.fsf@gmail.com> References: <87r0yzks1p.fsf@riseup.net> <87leotb4xj.fsf@gmail.com> Date: Sat, 05 Nov 2022 01:22:01 -0400 Message-ID: <87bkpm2cxy.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667625799; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=dIdo4kDSkTdKvjMIL03H2zWrfLG6nMdkRVaw9U1iIKk=; b=DoP+By/kpjaqgZTrewgledDCilJ/bSH8gAnBmCOK+Y81JimbDqOB2kgr3R9CytIadPisNG BqqkIzhHIlxxM3iyFSoaCR6EZxao5xEe/UILlGtRl0lhy+We0MAZnLIFUOaZi70yq0jvpR /0o7v9jT3Xa9UEvjzjw5lBzC8Vli+yb2szgo7BI8Y8/i+k3IzURGcEqfFhI3PVtgcxXNUe xWT9pLDJnmFZ7cW6iZiAVDeY7SPnLRLBCmbAcgdB61kUlO91PO3PCb+pMQB1mQBLQ+DXET hbSUQGdHAIIFv9ytVBtq1ex6qlKk3J8p+BQjE7kH5cWkugqTCrtnpw8nDmTfFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667625799; a=rsa-sha256; cv=none; b=A31kHsOXRgLH0tA4mGO4tlZ0IRXezqwIjipvogLbMpTiIYrw8xdXpXz7Cx017P/pijirHU /nhjU9hM+MnRKe//HUddxENEzC3N6uAUCJxXdD+WWa4AiXBLORAxdyNIxLe5z6KzcTohJ2 +XKiC9AHGHO0vmLPRNODRH5a6TxqwuHTlY/uYuZXGEq/ZJwpiypd/SfVHcW+uJOp2MlHY/ YSNYuQ3d6c1HOJLaNbWN0bZYPo50647kJ+iqkf1C+HvaKgytRtei2hiI3Zzda6OsPxAOza Q4UsAs+/ZFhXQJOTCmewgAfT4x+zpQBW4tkXsYEyIdXWAV439YZF802gcjK9xw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=onfiDfWf; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=onfiDfWf; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D5D7B1C580 X-Spam-Score: 3.90 X-Migadu-Scanner: scn1.migadu.com X-TUID: uQaPrZrelnq0 zimoun writes: > Kyle, are all the sub-packages of piem working independently? -elfeed, -eww, -gnus, -notmuch, and -rmail are integration libraries that, when their corresponding minor modes are enabled, wire themselves up to piem.el hooks. None of these libraries depend on each other, and piem.el doesn't depend on any of them being present. -lei is an integration library as well, though it's a bit more involved because it provides an interface to public-inbox's lei (mostly just `lei q' at the moment). piem.el does bind a piem-lei command in piem-dispatch, so that of course won't be found if piem-lei.el isn't present, but otherwise things should be functional. -b4 is a little different. It implements b4 support of course, but it's not an "integration library" like the ones referred to above. b4 is the main workhorse for applying patch series, regardless of whether that's from Gnus or Notmuch or whatnot. I know some people use piem.el without b4, and I'm glad if that works for their needs, but in my view b4 support is a core part of piem. > On dim., 23 oct. 2022 at 13:49, Declan Tsien wrote: [...] >> Subject: [PATCH 2/4] gnu: emacs-piem: Add build-info-manual phase. >> >> * gnu/packages/emacs-xyz.scm (emacs-piem): Add build-info-manual phase. >> [native-inputs]: Add texinfo. >> --- >> gnu/packages/emacs-xyz.scm | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >> index be6d4c6ba3..bc56067a7c 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -7151,9 +7151,15 @@ (define-public emacs-piem >> (lambda* (#:key inputs #:allow-other-keys) >> (emacs-substitute-variables "piem-b4.el" >> ("piem-b4-b4-executable" >> - (search-input-file inputs "/bin/b4")))))))) >> + (search-input-file inputs "/bin/b4"))))) >> + (add-after 'unpack 'build-info-manual >> + (lambda _ >> + (invoke "make" "Documentation/piem.info") >> + (rename-file "Documentation/piem.info" "piem.info")))))) > > Here, I would build the manual before the install phase instead after > the unpack phase. Declan, thanks, I appreciate you adding the manual. >> Subject: [PATCH 3/4] gnu: emacs-piem: Split into multiple separated packages. >> >> emacs-piem currently bundles multiple lisp files with identical functionality >> but for different tastes. Split into separated packages would avoid pulling >> unnecessary dependencies into user profile. >> >> * gnu/packages/emacs-xyz.scm (emacs-piem): Split into multiple separated >> packages. >> * gnu/packages/emacs-xyz.scm (emacs-piem-b4): New variable. >> * gnu/packages/emacs-xyz.scm (emacs-piem-elfeed): New variable. >> * gnu/packages/emacs-xyz.scm (emacs-piem-eww): New variable. >> * gnu/packages/emacs-xyz.scm (emacs-piem-gnus): New variable. >> * gnu/packages/emacs-xyz.scm (emacs-piem-notmuch): New variable. >> * gnu/packages/emacs-xyz.scm (emacs-piem-rmail): New variable. >> * gnu/packages/emacs-xyz.scm (emacs-piem-lei): New variable. > > Personally, I am fine with several packages. But we could also ask if > several output would not fit the bill. WDYT? Yes, I also wondered about using multiple outputs instead. Two comments on "avoid[ing] pulling in unnecessary dependencies": * -eww, -gnus, and -rmail use libraries that ship with Emacs, so splitting them out doesn't remove any dependencies. * -lei doesn't bring in any dependencies because public-inbox isn't listed as an input.