From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WMT8NglflGPXbwEAbAwnHQ (envelope-from ) for ; Sat, 10 Dec 2022 11:27:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MEs6NglflGOEggAAG6o9tA (envelope-from ) for ; Sat, 10 Dec 2022 11:27:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B5231F573 for ; Sat, 10 Dec 2022 11:27:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3x4S-0001GB-1W; Sat, 10 Dec 2022 05:27:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3x4Q-0001Fr-Ml for bug-guix@gnu.org; Sat, 10 Dec 2022 05:27:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3x4Q-0000Um-EH for bug-guix@gnu.org; Sat, 10 Dec 2022 05:27:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3x4P-0003VP-Up for bug-guix@gnu.org; Sat, 10 Dec 2022 05:27:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#59823: [1.4.0rc1] Installer fails to identify installation device on Ventoy-made images Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 10 Dec 2022 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59823 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59823@debbugs.gnu.org, Josselin Poiret , So'n Typ im Internet Received: via spool by 59823-submit@debbugs.gnu.org id=B59823.167066801013459 (code B ref 59823); Sat, 10 Dec 2022 10:27:01 +0000 Received: (at 59823) by debbugs.gnu.org; 10 Dec 2022 10:26:50 +0000 Received: from localhost ([127.0.0.1]:41952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3x4E-0003V1-IC for submit@debbugs.gnu.org; Sat, 10 Dec 2022 05:26:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3x4C-0003Uu-HA for 59823@debbugs.gnu.org; Sat, 10 Dec 2022 05:26:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3x46-0000RO-Qx; Sat, 10 Dec 2022 05:26:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=X7kVUpjXvBU+QCEOJy4G2buIDTv9wDN2Y9j8zn9ivuk=; b=QMJjf0wCF77GrnZVsH3g diNJozMy+u3gxgf2/+CKL9z09qiTz+hXZVdppjeIYxqVG4CDTNQc9yvu70IgB0eHIm1NAos+KfcgM Hta/OJOqsMtmS7ArwyYqB0kc2o+LOzyU7LUgdBQENWOP2BG4CnM1irKUTdFbME8kmtWP0gUzqeoIO R4fVzsRQFCP/cI6MqfaPbr0JjirXp0xgnYIsrZCoLmKAktBDcJ13zvuaJ3JZpk7PxTmekpm200zB0 xnBnIwMe5dUsZxfY4VZc+1wBKVr6PKKnY0atIuR/L5gw3U9ZIBqBeSAkoRxh3AnPpnDGplA5qNKWV zbunOVVaFJU3SA==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2774.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2774] helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3x46-00045H-Dc; Sat, 10 Dec 2022 05:26:42 -0500 From: Mathieu Othacehe References: <87tu2a8drd.fsf@gnu.org> <87lenj8srr.fsf@gnu.org> <87y1rj6xb0.fsf@gnu.org> <877cz213mk.fsf_-_@gnu.org> <87y1rg5il4.fsf@gnu.org> Date: Sat, 10 Dec 2022 11:26:39 +0100 In-Reply-To: <87y1rg5il4.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 09 Dec 2022 23:16:07 +0100") Message-ID: <87bkobo8ps.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670668041; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=X7kVUpjXvBU+QCEOJy4G2buIDTv9wDN2Y9j8zn9ivuk=; b=bdX85D3vRbNb/CgBHuZhb1LMtz3SMt7rP3S1QU0gf0wH+cwS18ZYCQuoOjv0zSFqrBi8bT SExSMpjmOHNVcgJ+V/M912ywMz9mLRiw7NMlIDdPjenoKqVI4ng0L5DdXcf4EvxHKGZTV6 I75ZBEFL50/JYLuYz/GFp/VPGLAPCMovS+cTfWOD7HAn5CDsp8QTHQtjZzHTPDs+Urytf9 5q3IJRD+x0HTtmXt4MxBQuATi1Rhklx/6TRechO6UZNjXl7BDUbIcNUNxyCl/2v2mz8Y/M rB6APkvXgL2Aw0x5rnsUdHE8JFXeFy/FiWYK0nQfr7i7UYuzgxydbYYaNb79bg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QMJjf0wC; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670668041; a=rsa-sha256; cv=none; b=FLKFFgv/Rw/OhJsm/muX0ailxtyqYQX0fYhQ+JErJ+LeSLnQgG3lB15uNxBwTRu8fcwFmx oa8/lZAqC+BLX/GfYTWLbjWxnQP0p+pbdaOrEoQxlLgpZJXx7hCXV+w0o0h61It8jQdaRX 5tHFidWMO4QnZYkCuOBZlUj+oG1vQDXSBUnQ6OcO7roxdfJuB9d+cYMKhgMkc82El68qJ+ AyarItfHJTU5Q3MTdIuX+NSCNDunwzIVXxHd/IOADuOWzWMPNlYHkVqQ6/3Kinn5ouaw9V IftmStM5INHSFWMsl6JXPGwpoxUqn/5dvfLWmiWwne4c/I/WF4au/CaJMC+qyw== X-Migadu-Spam-Score: -4.35 X-Spam-Score: -4.35 X-Migadu-Queue-Id: 5B5231F573 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QMJjf0wC; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: 09sfWYbw5AhB Hola, > Anyway, all in all, calling out to dmsetup looks reasonable for now; I > have a slight preference for using =E2=80=98open-pipe* OPEN_READ=E2=80=99= , but no big > deal. Perhaps add a comment showing what the line we=E2=80=99re parsing = should > look like. Yeah, I agree that open-pipe would be a bit clearer, but as this is already tested as-is plus we'll switch to the ioctl after the release, I think we can proceed. >> (define (eligible-devices) >> "Return all the available devices except the install device and the d= evices >> which are smaller than %MIN-DEVICE-SIZE." >>=20=20 >> (define the-installer-root-partition-path >> - (installer-root-partition-path)) >> + (let ((root-path >> + (installer-root-partition-path))) > > Just =E2=80=98root=E2=80=99. :-) Fixed, added a few comments and pushed. Thanks for having a look! Mathieu