From: Mathieu Othacehe <othacehe@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 59823@debbugs.gnu.org, Josselin Poiret <dev@jpoiret.xyz>,
So'n Typ im Internet <sontypiminternet@gmail.com>
Subject: bug#59823: [1.4.0rc1] Installer fails to identify installation device on Ventoy-made images
Date: Sat, 10 Dec 2022 11:26:39 +0100 [thread overview]
Message-ID: <87bkobo8ps.fsf@gnu.org> (raw)
In-Reply-To: <87y1rg5il4.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 09 Dec 2022 23:16:07 +0100")
Hola,
> Anyway, all in all, calling out to dmsetup looks reasonable for now; I
> have a slight preference for using ‘open-pipe* OPEN_READ’, but no big
> deal. Perhaps add a comment showing what the line we’re parsing should
> look like.
Yeah, I agree that open-pipe would be a bit clearer, but as this is
already tested as-is plus we'll switch to the ioctl after the release, I
think we can proceed.
>> (define (eligible-devices)
>> "Return all the available devices except the install device and the devices
>> which are smaller than %MIN-DEVICE-SIZE."
>>
>> (define the-installer-root-partition-path
>> - (installer-root-partition-path))
>> + (let ((root-path
>> + (installer-root-partition-path)))
>
> Just ‘root’. :-)
Fixed, added a few comments and pushed.
Thanks for having a look!
Mathieu
next prev parent reply other threads:[~2022-12-10 10:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 9:57 bug#59823: an installer dump was sent So'n Typ im Internet
2022-12-05 8:18 ` Mathieu Othacehe
2022-12-05 8:33 ` So'n Typ im Internet
2022-12-07 9:31 ` Mathieu Othacehe
2022-12-07 9:48 ` So'n Typ im Internet
2022-12-07 15:36 ` Mathieu Othacehe
2022-12-08 12:28 ` bug#59823: [1.4.0rc1] Installer fails to identify installation device on Ventoy-made images Mathieu Othacehe
2022-12-09 22:16 ` Ludovic Courtès
2022-12-10 10:26 ` Mathieu Othacehe [this message]
2022-12-10 11:01 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkobo8ps.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=59823@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=ludo@gnu.org \
--cc=sontypiminternet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.