From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cBX0CB+PvWMVLAEAbAwnHQ (envelope-from ) for ; Tue, 10 Jan 2023 17:15:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +HbtBx+PvWPWWwAAG6o9tA (envelope-from ) for ; Tue, 10 Jan 2023 17:15:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7B6F2EAEB for ; Tue, 10 Jan 2023 17:15:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFH4s-0002fF-F9; Tue, 10 Jan 2023 11:02:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFH4d-0002a3-9O for guix-patches@gnu.org; Tue, 10 Jan 2023 11:02:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFH4d-0004t4-0P for guix-patches@gnu.org; Tue, 10 Jan 2023 11:02:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFH4c-0001X4-P9 for guix-patches@gnu.org; Tue, 10 Jan 2023 11:02:02 -0500 Subject: bug#60707: [PATCH] gnu: services: Fix fail2ban configuration serialization. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 10 Jan 2023 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60707 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: muradm Cc: 60707-done@debbugs.gnu.org, mirai@makinata.eu Mail-Followup-To: 60707@debbugs.gnu.org, maxim.cournoyer@gmail.com, mail@muradm.net Received: via spool by 60707-done@debbugs.gnu.org id=D60707.16733664625796 (code D ref 60707); Tue, 10 Jan 2023 16:02:02 +0000 Received: (at 60707-done) by debbugs.gnu.org; 10 Jan 2023 16:01:02 +0000 Received: from localhost ([127.0.0.1]:40947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFH3e-0001VP-Gb for submit@debbugs.gnu.org; Tue, 10 Jan 2023 11:01:02 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:39450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFH3b-0001Un-Ry for 60707-done@debbugs.gnu.org; Tue, 10 Jan 2023 11:01:00 -0500 Received: by mail-qt1-f172.google.com with SMTP id s5so6801997qtx.6 for <60707-done@debbugs.gnu.org>; Tue, 10 Jan 2023 08:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=gpjW9xiwb06ydMC3u0NIkm2nOR31sp9Cjy7KqFvS0Fw=; b=Z8mkRQoOEb+0V7QEFhp6oAOCV50xB74SIJT0QpCBGg84KPxQ6oOnef6wInKFFvF1GY VfPZd33JVweATPLrYry8xKFHZJBmC2thpm6R9/4LVu+5IiinDBS/1t8R5ZXHDtjS5fFW 2ZM3rgTzOKMwIIXvJrtgsGOZGRqhTXx25xyV7IHjZx0jQ488Khb9R6DGhMisIyUl+AB+ HgZPQLiYmqTrElK4CS+RMc5vmdyiN09bnLza/Zbm1FgsZBf38mV690qLe7zWZIzRX1zO 23HvARgvqtJ8wiEELbD77o5Oh48X/O1m7mZCbIDuOMSlgHwdhrFYoA5q0VB3CmCKyVQF IZ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gpjW9xiwb06ydMC3u0NIkm2nOR31sp9Cjy7KqFvS0Fw=; b=gAM0LMRBU2LxbmmMpbXiCXOorLPB0TRisig2DC8ny2S6IF+hGsb62irZnQM1oTC3Kh WLYZYrFqzi0JzNc2GeFDmAKK5nTvF65Lqv6hQWEMgv01zwIN4KG2nmqNA7bk11gL/ZLt lLyKk5wZwRWv27BUN/J3IR8AAhyA/XulQYtL7pFxSfSGf0gEVws3C1dh9v12zDMkfM2P +0umkKUmjn7xWE1pbyrrQJcsjbTw58E25wENnMdvMh13q0eAnmFSajkFe4x3k4jRh56Y dPWSTlg5/v4t6M1qqZBozAQTswUIGdM4aSWkVLsEG3idlq9ZbdP+Y1RPUEs1t/TzuSfM Do/w== X-Gm-Message-State: AFqh2kqrFwZH7hPw6DUTwentk34QKuCqvKa5qdVtH7W8nsenJvf6uVLf ZLFgfrp6CgZxRbmq/9yPhD4ebtpD5HrJaQ== X-Google-Smtp-Source: AMrXdXtBvIdvN1AGUmQvdeWUuMEk93aWcZ63xR7MaDtxoX1N2fEqa/18ESYlF6K8vZKLODLBEac4sg== X-Received: by 2002:a05:622a:59c9:b0:3ac:9f39:24fd with SMTP id gc9-20020a05622a59c900b003ac9f3924fdmr5371294qtb.6.1673366454210; Tue, 10 Jan 2023 08:00:54 -0800 (PST) Received: from hurd (dsl-157-228.b2b2c.ca. [66.158.157.228]) by smtp.gmail.com with ESMTPSA id ch3-20020a05622a40c300b003ac2ae7a63fsm4473737qtb.57.2023.01.10.08.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 08:00:53 -0800 (PST) From: Maxim Cournoyer References: <20230110101136.26169-1-mail@muradm.net> <20230110144756.31172-1-mail@muradm.net> Date: Tue, 10 Jan 2023 11:00:52 -0500 In-Reply-To: <20230110144756.31172-1-mail@muradm.net> (muradm's message of "Tue, 10 Jan 2023 17:47:56 +0300") Message-ID: <87bkn6l6q3.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673367326; a=rsa-sha256; cv=none; b=jbS4iQxmrVL1vB6vUE6886F9/gT2R6XvIWG9Q6QPrjm6OfSQ4YSeeN2Cr6COF+3QGIzyoo jFSx6MANFH3sKYBgrBxcPMQL6UFJSA3lYopc3fhZaAuU+puN/fhqL0jUvJLDgiIp1BF5wn DqfA2IulLR6xCqIgHevmxk2+tE/46995hrn2/y0b26AYTRD85xEJGiqc7CYi/jRnHcIpf0 sBtsJOlhCUUdBMSpOi4weZsJ13kCyBPxLi6wCAagNvS1F1CVQStVWKdjUVWnv3g9IUhzdI cVmQXRAzdFiZQdeh2MzgjbKt28UzNRB4Qu433BX1be59bxzbH+fsu3D/2tg7Sw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Z8mkRQoO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673367326; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=gpjW9xiwb06ydMC3u0NIkm2nOR31sp9Cjy7KqFvS0Fw=; b=Gtd90tcB70V7RRnArqok6cuNjFNTRjeOHwG/qObHlXVm+vK7NXAk3XP5BuFoxDzQMZInPO jintcwIrgY0+fWDaQdW/6xWFs1KoWS3DTpa/KA00mDgx35bwaa5mmGrn2R3NRypw4cPDZ7 6eZJKtjBpqyPLgrErXoPi74cAQ2IciX3sHrnTgA3KoezbC+Cd88fW5K3aKGkJIKuHBjzUL TH7zOqe2JXYNWrA76VlfaxRh47PW9rtua5AgJna+dpGAvX3HZWNDSQtIv8s5ZxNEvqKZne JTbNluywVW/fk3tBO903ELI1bwgAY/WWMRrNExmsOVZbr06+4OG6d+azVuHMvw== X-Migadu-Spam-Score: -1.98 X-Spam-Score: -1.98 X-Migadu-Queue-Id: B7B6F2EAEB X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Z8mkRQoO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: j0oRxkb+igkj Hi! (Please make sure to keep all participants such as Bruno in '--cc' in the fututer to make it more likely they see your v2!) muradm writes: > This fixes a regression from 543d971ed2a1d9eb934af1f51930741d7cc4e7ef whereby > match-lambda due to configuration field reordering. > > * gnu/services/security.scm: > [serialize-fail2ban-ignore-cache-configuration]: Switch to match-record. > [serialize-fail2ban-jail-filter-configuration]: Switch to match-record. > [serialize-fail2ban-jail-action-configuration]: Switch to match-record. LGTM. Thanks to Bruno for the suggestion to use match-record. Applied as dc403ec7f1. -- Thanks, Maxim