From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cBCYFL+O1WMBDgEAbAwnHQ (envelope-from ) for ; Sat, 28 Jan 2023 22:08:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iC+nFL+O1WNPDAAA9RJhRA (envelope-from ) for ; Sat, 28 Jan 2023 22:08:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A23DED54E for ; Sat, 28 Jan 2023 22:08:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLsQa-0007mG-5a; Sat, 28 Jan 2023 16:08:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLsQX-0007lw-JV for guix-devel@gnu.org; Sat, 28 Jan 2023 16:07:57 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLsQV-0007i4-II; Sat, 28 Jan 2023 16:07:57 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:40]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 1BE051ACA1; Sat, 28 Jan 2023 13:07:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1674940071; bh=n8AorDku50x7IyXcR9OuHMgCN6CT69p+lge1tX0PW90=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=F/lgdzMhODyR03bQizo28OKydE2yLHbY1QpDItFo+l4Sb13L3hyLctON2BKMlGAJD QAExfbpXFU/mxn2CEO1UvFRvLLBnAdVT40rSQfvRiw8RtRTwHpPWjM7oqEWCHtnDAH rHk/bxZyjnPAc4q6rDSEwh4ohMQZ4naZCVIybD0AF/NOBlmkGdLYpMo5RYE/3FNIAj SqaslQnrLQ827L8Wa0+IcNxtlaa7tslt4CXcOprv4YFW24x2rILAlm+IqULnTbcKqb PI8aru785DLlVAjcLI3bH5YLDHuyA52/Y2oTbcsbBSH82jdSr0xg6wbgcuKjWLJbwY rcI+L91EWdT1A== From: Vagrant Cascadian To: Simon Tournier , Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= Cc: guix-devel@gnu.org Subject: Re: guix lint false positives and RFC patch In-Reply-To: <87cz6zoov6.fsf@gmail.com> References: <87leosd8bg.fsf@contorta> <87tu3goyia.fsf@gnu.org> <877d0beh4i.fsf@contorta> <87leoqcq8p.fsf@contorta> <87k049jnl9.fsf@gnu.org> <87v8njliub.fsf@contorta> <87cz6zoov6.fsf@gmail.com> Date: Sat, 28 Jan 2023 13:07:46 -0800 Message-ID: <87bkmigyfx.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674940095; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4SD7GdpXUyOg+2+JTAYerVRdBlxO23fIXHKx5W7sXhY=; b=nIx3CsYumha8G/sCjwh3gO0xdYz6bjNw8zbHKGRHM0R9f9K9Ueso2FAbrF6VRvFIjnLYML Etas7ok2Z9cIa8+JzsAC9pvmyckmU8K7f5O5kyMBljIwCyakdySgNPCR8ZPDHEmoCKTWOT hkUs/K5IkGNAyxMDhNboWRrXLGzTfFuL6WXjKlhvRYi8tshngbxMj/9lbezbTOyhYQoEVk Ikh+OotP8OCgidLPxUhpr80GHXeL/2pFv6l0MRpUX60J7f/7mgO4Mrl2tSooLvezQtUDET tbRaRU+9usO4MST1//KbFfD6lJhEfyJVDwajTc10WCO40a0vlfyeQqTthLnSFg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b="F/lgdzMh"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674940095; a=rsa-sha256; cv=none; b=Ng8E6UalRFRgd+NEehBZ0dTiPqy0ILmLCCs6ZpuK5uWmnCZJIz0M0tB5j0XNZF7IlSk2Dh PgKkTy+scRS9XO3z+E5Szn44K5xyOOboOy/ZafRlJCaUXBQWcqkNQuaE2wDP3+hrw/ZPQv /CBoqAY47by1ubzirIpszi3552znuc+R4eAHQtMjRB4v5fm1lC7tch7ojNTIixrqFhvhK9 OMvxSTQE8Mmzz8tva4wH6ZzVQ4FgD51sOSd85s8FqnKeyl4DcNEQgDRQWiPL9Q9cV/rLdr kVR7NFM6szClhEWdNlRoT9sMcO8xj+/EssvQ43ONzv+Fqev8cXCvxSaDP42vMw== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b="F/lgdzMh"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -9.77 X-Spam-Score: -9.77 X-Migadu-Queue-Id: A23DED54E X-TUID: SNpvbRfepeLm --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-01-27, Simon Tournier wrote: > On sam., 12 nov. 2022 at 17:54, Vagrant Cascadian wr= ote: >> On 2022-11-05, Ludovic Court=C3=A8s wrote: >>> Vagrant Cascadian skribis: >>>> From bfa13fdd3616839883e50efbbc05fb132610ce67 Mon Sep 17 00:00:00 2001 >>>> From: Vagrant Cascadian >>>> Date: Wed, 2 Nov 2022 19:56:12 -0700 >>>> Subject: [PATCH 01/12] guix: lint: Exclude some "@" symbols from vario= us >>>> checks. >>>> >>>> The visual representation of "@code{}" or similar in the description a= nd >>>> synopsis do not include the string, so exclude it from checks to avoid= false >>>> positives. >>>> >>>> FIXME handle @command, @file, @acronym, etc. >>>> >>>> * guix/linx.scm (properly-starts-sentence): Exclude leading "@". >>>> (check-synopsis-length): Exclude "@code" and "@acronym". >>> >>> LGTM! Bonus points for a test in =E2=80=98tests/lint.scm=E2=80=99. :-) >> >> No bonus points for me just yet... > > [...] > >> What is failing to match what here? > > Well, almost done but not merged, right? > > Still an issue this =E2=80=99match=E2=80=99? Thanks for bringing this back up to the surface! I struggled with it a bit and honestly do not remember where I last left it... I think I made some further progress... and then hit a new blocker and the sun went down and slept on it ... and never got back to it. So I was definitely stuck writing a test. From vague memory, I think once I figured out how to have the test not fail wit guile complaining inscrutibly... it did not effectively test the thing it was supposed to. The other thing I remember being caught up on, which was not a deal-breaker, per se, was hoping for a way to loop through a bunch of @SOMETHING things ... I was not happy with: + (if (>=3D (string-length (string-replace-substring + (string-replace-substring synopsis "@acronym" = "") + "@code" "")) + 80) And then adding @command, @file, @acronym, etc. ... using increasingly nested levels string-replace-substring would eventually become difficult to read and surely there is a better way! I might be able to take another look at this in february, but I would welcome help wrapping this up regardless! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY9WOowAKCRDcUY/If5cW qm0BAQCbywlEFOOhPVTIZNgz3cf5ooKGdtN9D3gVxHc77CHnkQEA1c2eSYNpA5tb aIIt6JxSpLmypFLwaCnZ9SmaTJKzgwc= =RMLj -----END PGP SIGNATURE----- --=-=-=--