From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eBRLI2Hd/GOc7wAAbAwnHQ (envelope-from ) for ; Mon, 27 Feb 2023 17:42:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qCcII2Hd/GNf8gAAauVa8A (envelope-from ) for ; Mon, 27 Feb 2023 17:42:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 64B9B20026 for ; Mon, 27 Feb 2023 17:42:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWgZf-0005zV-Vg; Mon, 27 Feb 2023 11:42:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWgZe-0005zH-Ug for bug-guix@gnu.org; Mon, 27 Feb 2023 11:42:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWgZe-0007Ib-Kr for bug-guix@gnu.org; Mon, 27 Feb 2023 11:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pWgZe-0005Rz-Bh for bug-guix@gnu.org; Mon, 27 Feb 2023 11:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61841: bug#61255: [PATCH 0/5] Add support for the RPM format to "guix pack" Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 27 Feb 2023 16:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61841 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 61255@debbugs.gnu.org, 61841@debbugs.gnu.org Received: via spool by 61841-submit@debbugs.gnu.org id=B61841.167751610520888 (code B ref 61841); Mon, 27 Feb 2023 16:42:02 +0000 Received: (at 61841) by debbugs.gnu.org; 27 Feb 2023 16:41:45 +0000 Received: from localhost ([127.0.0.1]:48658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgZM-0005Qp-J4 for submit@debbugs.gnu.org; Mon, 27 Feb 2023 11:41:45 -0500 Received: from mail-qt1-f175.google.com ([209.85.160.175]:35532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgZI-0005QQ-92; Mon, 27 Feb 2023 11:41:43 -0500 Received: by mail-qt1-f175.google.com with SMTP id y10so2656204qtj.2; Mon, 27 Feb 2023 08:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=60uXvIPRzk8bf7E1jGypoW3k03KmuRuepv2cqHrgdIw=; b=NcANEFdg/cSsspV/d8CUIZCxx8isgyRLLo/+bIJo5kCIdc0eQNlguOjMjy8gUlttap MS2bXJy6OcgXJBQk39VCZHXxPmDpufaugMxbdm9zyWXNOLIEZHJ1zeA9TWIr2zjeeUlq lE0KifU2U80N5+fu5dsdVJRx5x80il8hAfa9HOsEGjLtxnOpJf0jhj2LWRZa3EUnV82J K2ocIgI4yJqzzKepHdvE1i2KXmVm7trI8d7EbLgz4LkfYgUHmmc4f4TKOM2pBKstzK16 37BmDewXFlUhPXEND4iq+JTADbqFKlm0zvPnTUZ8u8Nt8N76XSbbwfDrNudIu6T1walC 0Wvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=60uXvIPRzk8bf7E1jGypoW3k03KmuRuepv2cqHrgdIw=; b=6rJgdrNkSLYqUd65eKWHgGc04DtE+6Yodp3OLwYV7PTHzbrMu/LZ5WsQ+qvQtEcRUe AgJDtQRLHgF7b4dJ5CzTPS18zu3BGE5upwH+vg94vRwQLLx3eFAqlr1MRHR/Ywd23w5R 7Lc6Jge9sGqOYZEoThmHzjHzYl085vZnBz1EQLHNYDqiEE06DWN8ro7Zwr85RIHEvpb/ qyEshVWBOazpwX6dC8opheEnaoK1whAU44sPojPeclqFcv1yvBZUFMwEQey/1tgsFWtM PVfv8S+eNTgz0g+w+OFnOHTkVka7bAf4j10LRMvpmW2TSBvNltl61doJMV7BCDZjeweU jQTw== X-Gm-Message-State: AO0yUKX4A1tGLo55cJvXnfRMaoJZwaKwCdCnoArOGZ70nMt8r+8yO1ZY hwMtPnmGs4MVi7cL7FwWLIePzllujD+5afhK X-Google-Smtp-Source: AK7set+xyJjH6CDnIX3fuhZVYpowrrsKaepx5Tp07wVD3kdMlgAA1cuzwErn7nFm/BqasmEtEoo47Q== X-Received: by 2002:a05:622a:1646:b0:3bf:d8e2:ab0e with SMTP id y6-20020a05622a164600b003bfd8e2ab0emr7556444qtj.23.1677516094412; Mon, 27 Feb 2023 08:41:34 -0800 (PST) Received: from hurd (dsl-156-86.b2b2c.ca. [66.158.156.86]) by smtp.gmail.com with ESMTPSA id z2-20020ac86b82000000b003bfbf16ad08sm4855697qts.74.2023.02.27.08.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 08:41:33 -0800 (PST) From: Maxim Cournoyer References: <20230203221409.15886-2-maxim.cournoyer@gmail.com> <20230203221409.15886-3-maxim.cournoyer@gmail.com> <877cwyw7yc.fsf@gnu.org> <87h6w2p02y.fsf@gmail.com> <87a61ilpi6.fsf_-_@gnu.org> <87fsb5wso1.fsf@gmail.com> <877cw85qtq.fsf_-_@gnu.org> <87k003i1pu.fsf_-_@gnu.org> Date: Mon, 27 Feb 2023 11:41:32 -0500 In-Reply-To: <87k003i1pu.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 27 Feb 2023 16:10:05 +0100") Message-ID: <87bklfkqmb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677516129; a=rsa-sha256; cv=none; b=O4pP8bB3dRe2UKhrgqG7FCYt4sF4fcKbyWd+zKdeuwhiOChyMyoHEHpNiAm06JzXv+U7YC hXn9EPru0ymU6NcWbEl69uFCa5r0OfMx49o5stfk3yzbKvNpeukEaE7Bo7iYWLcEXMNAlm 56gW/Uh28XpSLXeHxBhWx6ahXCNF6W2shziQGqtXhnefCddhcQ3pWNjNLleL/thberaSkt IqCm93BycnVHD+0IO55vJHEOSOP19v+HLGVii5YD76yfIg7CnlZD0tZPnvlebfWd8S7M17 9I4YITyDcko6egfBr4AnFj6ZeuDPD+Yx9DTp789ZndqwzjSdkjBHBt5fr1S07Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NcANEFdg; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677516129; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=60uXvIPRzk8bf7E1jGypoW3k03KmuRuepv2cqHrgdIw=; b=BimWzjHvfLBi66bypC/u9AHKKicrHsBw0C6zrazyM4UScMUQs/tVkNqSEaEvawnY2ZauWJ LZKwhb8Ql4eK7iy9/HfsW9XcXZ+PVlBD4sRwMVmavJf+pkCU1rKO4O+7gTuWlg6bJthzPD 5/iqBt2W6MYzJppSaGZDzGTHbvKDUD0aOTywa40qThiQgom2NgBJxSwNTPYaXyYNKXMJeW kgu0cK/RpEdJKDz5lXXEOGAGzFYO+6dCmfc1D9lUPrG3pzxbynFOezyww8SefRqrZzU5Me npa+lLN4+a4NVhmqzCrLvDDzisrjG32wFKMvIKAV44UQVMjjK06EDk5SiUpCkw== X-Spam-Score: 8.81 X-Migadu-Queue-Id: 64B9B20026 X-Migadu-Spam: Yes X-Migadu-Spam-Score: 8.81 X-Migadu-Scanner: scn1.migadu.com X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NcANEFdg; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: DSQPrNyfMJ7M Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Ludovic Court=C3=A8s skribis: > >> I=E2=80=99m really not sure what the impact of >> 68775338a510f84e63657ab09242d79e726fa457 is, nor whether it was the only >> solution to the problem. >> >> One thing that probably happens is that (default-guile) is now never >> used for , contrary to what was happening before. The >> spirit is that (default-guile) would be used as the default for all the >> declarative file-like objects; gexp compilers refer to (default-guile), >> not (%guile-for-build). >> >> Importantly, (%guile-for-build) is a derivation, possibly built for >> another system, whereas (default-guile) is a package, which allows >> =E2=80=98lower-object=E2=80=99 to return the derivation for the right sy= stem type. > > Commit 68775338a510f84e63657ab09242d79e726fa457 turned out to have > unintended side effects: > > https://issues.guix.gnu.org/61841 Ugh. > I fixed it with: > > a516a0ba93 gexp: computed-file: Do not honor %guile-for-build. > fee1d08f0d pack: Make sure tests can run without a world rebuild. > > Please take a look. Thank you. I still think it'd be nicer if computed-file had a means to honor %guile-for-build rather than having to accommodate it specially as you did in fee1d08f0d, so that it'd be symmetrical to gexp->derivation in that regard. Why can't they? > We should think about how to improve our processes to avoid such issues > in the future. I did raise concerns about this very patch late at night > during FOSDEM, 24h after submission, and reaffirmed my viewpoint days > later. I understand that delaying a nice patch series like this one is > unpleasant, but I think those concerns should have been taken into > account. You are right, I should have delayed this submission passed its 2 weeks, to let some extra time to look at alternatives w.r.t. the %guile-for-build patch. Apologies for being too eager! --=20 Thanks, Maxim