From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MOOyAqu5AmT0sAAAbAwnHQ (envelope-from ) for ; Sat, 04 Mar 2023 04:23:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CPapAqu5AmTQgAAAauVa8A (envelope-from ) for ; Sat, 04 Mar 2023 04:23:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B603810900 for ; Sat, 4 Mar 2023 04:23:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYIUB-0005qN-Kj; Fri, 03 Mar 2023 22:23:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYIUA-0005qF-R6 for bug-guix@gnu.org; Fri, 03 Mar 2023 22:23:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYIUA-0002Rz-Cs for bug-guix@gnu.org; Fri, 03 Mar 2023 22:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYIUA-0001qD-4j for bug-guix@gnu.org; Fri, 03 Mar 2023 22:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61853: =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?pack=E2=80=99?= shell tests fail Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 04 Mar 2023 03:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61853 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61853@debbugs.gnu.org Received: via spool by 61853-submit@debbugs.gnu.org id=B61853.16779001407012 (code B ref 61853); Sat, 04 Mar 2023 03:23:02 +0000 Received: (at 61853) by debbugs.gnu.org; 4 Mar 2023 03:22:20 +0000 Received: from localhost ([127.0.0.1]:35018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYITT-0001p1-Ks for submit@debbugs.gnu.org; Fri, 03 Mar 2023 22:22:20 -0500 Received: from mail-qv1-f50.google.com ([209.85.219.50]:33413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYITR-0001op-SP for 61853@debbugs.gnu.org; Fri, 03 Mar 2023 22:22:18 -0500 Received: by mail-qv1-f50.google.com with SMTP id jo29so3139169qvb.0 for <61853@debbugs.gnu.org>; Fri, 03 Mar 2023 19:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=E0VFeWboHlwqpQOcR8roaeVfgQN/KzxqaDG2QVRIK3Q=; b=HnD7C2LZ9viRInov8mGvn34tQL6saVKEGDYs7CtMImhAutRvGYIvZ308fSeSX+h5ZZ WMg96A9sY0pFSwRHz4c90zs7JWsAULpe2KMHMJI4olY+VTRZNW2ObvONYwZtQAd/SM+L IrYUPiJK1Cs3KOnmYKAF4A9rzvTj/MNkDOp97X6mZQr9npshK4lmHFZ9FB9slu0tsNgu RqGgIowpDureiT4GroKuItACuwdO+C71XNUk9KT1o6JnQTlWdlcF/hRfVlZtlfOihfH2 R/fUpOnJFdQ0TjkWEZLmQXmm1bfcIFQYaqf1W04W57ZR6l45HPntcRfr0Hlt7RGF6lLm lrVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=E0VFeWboHlwqpQOcR8roaeVfgQN/KzxqaDG2QVRIK3Q=; b=sfOsKfLqhtNg9RAuVT4iUbVwmL4l1SAnyhmhqusGZ+e/EQfIEfiWHkzgUA79epuw2c 7i0lLnT1cw2PA0l/5xLlx3oVycMeNVuppzC/MEuhPewV1JYtk9pOj7+3yR+vMbIhROr2 tYy+ADPhff87xsThhR4SDSjCcC61nZwEO9Wm0zd92fat/ICGIgdiDiflFpdVW3T9l1Vn +35s8Luyu1eoeMAqlOjuzGvUexn22SZ69pQlmPIZfd/jBOznUyTjNTtKbXMpKhPiTcn4 HfZKaTud+zVmq8R3vmBW2jbZnlC8aXoxa9EJ99sQ5nhYWJkNKVqAbYB3n8HNJ2DH8gF3 n3Pw== X-Gm-Message-State: AO0yUKVEvG/doQl07vM89zz3MliRmH3U5J3iYajtTnvY1NWIlVRhesdR 8ICSDWJV6w9imgNo446EVuyB1rXFqFtpmw== X-Google-Smtp-Source: AK7set/QhB/W3LrpIF1xCc37BrGmTaC+mU1QjYSjMi4dIidlZmvsV3Ag5XWVX3aUHJKAk5m82FV2+g== X-Received: by 2002:a05:6214:f23:b0:56e:8a00:f3a with SMTP id iw3-20020a0562140f2300b0056e8a000f3amr7766883qvb.32.1677900131817; Fri, 03 Mar 2023 19:22:11 -0800 (PST) Received: from hurd (dsl-10-129-180.b2b2c.ca. [72.10.129.180]) by smtp.gmail.com with ESMTPSA id r62-20020a374441000000b00706c1f7a608sm2914770qka.89.2023.03.03.19.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 19:22:11 -0800 (PST) From: Maxim Cournoyer References: <871qmahjcy.fsf@inria.fr> <87wn42emh8.fsf@gnu.org> <87v8jmilhl.fsf@gmail.com> <87cz5qyv10.fsf@gnu.org> Date: Fri, 03 Mar 2023 22:22:10 -0500 In-Reply-To: <87cz5qyv10.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 03 Mar 2023 11:43:55 +0100") Message-ID: <87bkl942vx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677900202; a=rsa-sha256; cv=none; b=X6GmXUhfJtIaPfbszqlB81IXRHlW9KiaQmFYM4QoC9R8F0rSd67olVppGQO2stpQk9oXJH 2lzdswixMSltDnbnvp1bOjQwUfbGfCSrQC4g+U5P07mD05BnQIPSdx08Wq5sj68CjYStQ0 DL/WLh888Dgr3WADp3EHBLsHyZB0Ln4CZ1Q31tYp4OTvk+cbunSxJASlb6qL8LH9hkEmFO 1Qq8t3OdEqmQpMrWhddY4dMS0GzP/dW/Ae2h5pS6dYsEIMttMD7UYxd/RpqKN9JsolOabO DzvFoC3hacnr4r76Ss+fJFSvd0kspetzWeNjGu3Es5qNn6BCfPkJC0PABTlntg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=HnD7C2LZ; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677900202; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=E0VFeWboHlwqpQOcR8roaeVfgQN/KzxqaDG2QVRIK3Q=; b=iPTxPWpboNdlg+mjNxzzpsRLVN44BpS5fasFUiYiLHZk20Buogp3Z9thELd8AFCxI1s7gl QKwHF5JKplR9c1KGu7tKE3Y42pzVfvDvsepoF/PzetWf2fgc1y/P8E3nrOkO5ENRXD3wVz DtVdNjQwYvVRHRG0bzRvl7dlZnSyyjGO72WTjOEP2kjnqtqjMk0CtcfBJapdDj1QkKi5+Z yexKem83PRzidqfcuMp9ym6PBxFbwjd4Y/G/wQREzYTrZ/3L0nK5X52zURZ1iHtljp32Vp yZhmkXx+/9c9aoa4o2RMErv9P6AVxtQQyoksav6Prmr/MtXTt+XN/LsQdjblrA== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.60 X-Spam-Score: -0.60 X-Migadu-Queue-Id: B603810900 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=HnD7C2LZ; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: /lIOPIoPsk3V Hi, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: > > [...] > >>> That=E2=80=99s an acceptable change IMO, introduced in >>> 68380db4c40a2ee1156349a87254fd7b1f1a52d5. However, the tests were >>> evidently not run after that change, which is problematic. >> >> Interesting. I had done all my testing using tests/pack.scm (and the >> new tests/rpm.scm), and overlooked tests/pack.sh. > > =E2=80=A6 > >>> Anyway, fixed in 92a0e60a963a54230e400c5c2ae585205489bf35. Both tests >>> now pass for me. >> >> Thanks (again)! > > To be clear, it=E2=80=99s time-consuming and stressful. That=E2=80=99s n= ot sane and I=E2=80=99d > rather not work that way. Again, thanks for fixing up after me, but you didn't need to put yourself under such pressure. As the author of the problematic change, the responsibility of fixing it was on me; I understand this well. >>> One issue with 68380db4c40a2ee1156349a87254fd7b1f1a52d5, though, is that >>> it introduces a copy of the profile being built to the store >>> (=E2=80=9Cprofile-directory=E2=80=9D). This was purposefully avoided b= efore because >>> it=E2=80=99s very I/O-intensive, space-consuming, and puts more pressur= e on the >>> store. It=E2=80=99s a pattern we avoided for system images too, having= noticed >>> its cost (commit 7f75a7ec08975eb6d6e01db61bd6b91f447f655e for instance.) >>> >>> We may need to come back to a single derivation well or creating packs >>> for big profiles will be too costly. >> >> I agree it's expensive; we're trading IO for storage though, so the case >> of generating the same pack in multiple format, it could be beneficial >> by only computing the union directory once. The real motivation was >> avoiding code duplication though; perhaps this could be accomplished by >> moving the common logic to (guix build pack-utils)? > > Yes, that=E2=80=99s a good idea. There=E2=80=99s already (guix build pac= k) and I guess > we could move roughly the contents of =E2=80=98self-contained-tarball/bui= lder=E2=80=99 > and =E2=80=98populate-profile-root=E2=80=99 there. > > How does that sound? Sounds good. See an implementation in #61949, to which you should be CC'd already (per 'etc/teams.scm cc-members HEAD^ HEAD'). --=20 Thanks, Maxim