From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uB2REclpB2QAMQAASxT56A (envelope-from ) for ; Tue, 07 Mar 2023 17:43:53 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EFGNEclpB2STcwEA9RJhRA (envelope-from ) for ; Tue, 07 Mar 2023 17:43:53 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 097A13C863 for ; Tue, 7 Mar 2023 17:43:52 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dyQjXpda; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678207433; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=hxEx7FimAlFq7jL3xk5YvkU4vAaKGq7Khhc5BhdtXP0=; b=In9KdgXlEb+IP2bsuzN4SYzm2fnEl3KeI5ZLMoLXMXB2XitA++RIJ+fKUPwHgueuG+dt2/ wRDMs4pt71pV3j939vCQ9/cZJrDAp68+MygLgyh50z5fJZBq3z97/grI9EdeD0wGUm+JV9 cple7H0FXxacXKPB4ivAQaAhkyHsy4DdvlAByOi2IVb4x72LLW3MMAKhcJA0URM3kuziiy X4jHGAzGS3yxYCroYBHcf+WvGTpYw1WZ95bNBl8JRSf1yJ4eUOiR83vwiAsTsuOa4+TWCR EMEx1sdjip9hii2V1s61yarKiPu1pZgLvXazcdvD/fPMzJyP0aKAubUBAhrCAg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678207433; a=rsa-sha256; cv=none; b=sCDc5KEVV4K3MkgTIP3MuE5jU24oWJEFcMMKaok8nUhgTqOOZjeaHKtlBY3wROY3WjuR3d nm6RiFDMFT+iujeuciO9I5CoRlCXayIVVBgEDM+VmsFp/i6PtI94nzC6L6p7Rsmlf7Wda7 u96a8rGhoV2M9M5hFJaSSSNzllwB9uUV313eVJssuduBififQJtexaXjpicsZDeNcC1SFe a5EHuDMfWLQN1PdVEy7EwT3ckQy/0xl5b/LbRr3Vp+sJ8fQHvKaBRPl7jczGGMHfnuzHGs DSPCAb87w0tarR0HP2Kl9AuNVkaHVpvkSFh7DHeprWeh/wwFSt1q1UcbSqI/hQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dyQjXpda; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZaPE-0003YE-W4; Tue, 07 Mar 2023 11:43:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZaPD-0003Tn-DD for guix-devel@gnu.org; Tue, 07 Mar 2023 11:43:15 -0500 Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZaPB-0005ZE-Sv for guix-devel@gnu.org; Tue, 07 Mar 2023 11:43:15 -0500 Received: by mail-qv1-xf36.google.com with SMTP id nf5so9285152qvb.5 for ; Tue, 07 Mar 2023 08:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678207392; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=hxEx7FimAlFq7jL3xk5YvkU4vAaKGq7Khhc5BhdtXP0=; b=dyQjXpdaV9lQ9uftlaD2kgiUUgFhPQNoW4X21R9GNv1Q0G3AzBlOWvXf2vWnFVQ33B 38L63hRslCcSG2ewyz+5TkeX0kX3vCrS4VgrLwXrVIbza30sGyXyYvLLUeU23Jr8aTso l+nQZplz16thLmbNI5kjhkRvoMBmO9UCdQf2SHFkACcTf6B6/pZ32Ujlh6e1PmPP62I4 g8u0ezeYOhukbdqrr4S4UZ1WyGr5DU1V5uq/oG2Gr/B9Y3ViRhSvxb84mUcTPVo33WZO 5TPLQHgDnGfR4BWVzojxuloHUFl4PL44mJZ4ewIHPjvpG3F7TYCkFpaQWO5sEM/jZuIw u26Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678207392; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hxEx7FimAlFq7jL3xk5YvkU4vAaKGq7Khhc5BhdtXP0=; b=zgewjLd0lLX4qW7z+R2pxjaw0uKtA4f8OhIoIF6Qv68qjVSo5s/J5jvtgrRE1w0bxO iUqLdyrtgoPvEa21W1PjsZp5piLIkFy14Mu3+dLZtdqqx79O3YegxhJMuTU1JRjU7Ywp A9DQALbrDKx4vSqj/TfF1hFq+LEEpQvBmevcWc6s73QfgmbCI6T9DL/ll1mrcbNkqT1h AZyJtwWBXuZqY0bX3nVjP4OmGuucjZWzIWKgrFehqOQJ1K71sk1uH7OUr4YzHrUs2EB6 m5hP+sGK598wmpr4NVASAlWONQwiuV1QLF+fiOdsJjsNmX1Sr7nh9J1m2lgSJ+mehjgT WU/w== X-Gm-Message-State: AO0yUKWkaFz15t0UsctnBa+oBbMVUEJGxNfnwqlBy0iWu7xqvHMKA4eY WLTPzIE+G2zMv/afUnQetEx45KbZSeCFOe+h X-Google-Smtp-Source: AK7set8o9s2PPJdvRSj2DfFlI6UIZ9tYyWE4kohAR/VQAardSZZxzztQDffR/D8xDpzujLf/WL9bLw== X-Received: by 2002:ad4:5dc2:0:b0:56b:fafa:9117 with SMTP id m2-20020ad45dc2000000b0056bfafa9117mr26176429qvh.25.1678207392726; Tue, 07 Mar 2023 08:43:12 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1000]) by smtp.gmail.com with ESMTPSA id u24-20020a37ab18000000b006fa16fe93bbsm9798015qke.15.2023.03.07.08.43.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 08:43:12 -0800 (PST) From: Maxim Cournoyer To: Simon Tournier Cc: Tobias Geerinckx-Rice , Guix Devel Subject: Re: The package/inherit trap References: <20230221130600.18932-1-sharlatanus@gmail.com> <20230226004406.6215-1-sharlatanus@gmail.com> <87ilfmhkuh.fsf_-_@gnu.org> <87lekijcwi.fsf@gmail.com> <87v8jixg6u.fsf@gnu.org> <87o7p94yqk.fsf@gmail.com> <87jzzxy6l0.fsf@nckx> <86lek8dbsf.fsf@gmail.com> Date: Tue, 07 Mar 2023 11:43:10 -0500 In-Reply-To: <86lek8dbsf.fsf@gmail.com> (Simon Tournier's message of "Tue, 07 Mar 2023 12:46:24 +0100") Message-ID: <87bkl4y0kh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f36; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: 097A13C863 X-Spam-Score: -6.93 X-Migadu-Spam-Score: -6.93 List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: oCU0GGqSCsaT Hi Simon, Simon Tournier writes: > Hi, > > On Fri, 03 Mar 2023 at 20:21, Tobias Geerinckx-Rice wrote: > >> Could we rename it to something like=20 >> =E2=80=98package+replacements/inherit=E2=80=99? To me, that captures th= e spirit,=20 >> without being overly longer. > > Well, I gave a look at the code and have seen the replacement. But I > had not thought about the package transformation and the like. > > From my point of view, the best would to add a paragraph with index > entries under =E2=80=9CDefining-Package-Variants=E2=80=9D section [1]. > > However, in the light of Maxim=E2=80=99s explanations, the example from t= he > manual appears to me inconsistent: > > You can just as well define variants with a different set of > dependencies than the original package. For example, the default > @code{gdb} package depends on @code{guile}, but since that is an > optional dependency, you can define a variant that removes that > dependency like so: > > @lisp > (use-modules (gnu packages gdb)) ;for 'gdb' > > (define gdb-sans-guile > (package > (inherit gdb) > (inputs (modify-inputs (package-inputs gdb) > (delete "guile"))))) > @end lisp Do you mean inconsistent because based on what I wrote it should have used "package/inherit gdb ..." instead of (package (inherit gdb) ...) ? If so, I agree. It could be modified to use the former and an extra explanation offered about why package/inherit is used here when it's to be preferred to plain inheritance. --=20 Thanks, Maxim