From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sOPTGqsLB2SAIAAASxT56A (envelope-from ) for ; Tue, 07 Mar 2023 11:02:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UFH0GasLB2QKCQEAG6o9tA (envelope-from ) for ; Tue, 07 Mar 2023 11:02:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 379BD2E167 for ; Tue, 7 Mar 2023 11:02:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZU8x-0007T7-RE; Tue, 07 Mar 2023 05:02:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZU8w-0007Sg-EX for guix-patches@gnu.org; Tue, 07 Mar 2023 05:02:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZU8w-00009t-5n for guix-patches@gnu.org; Tue, 07 Mar 2023 05:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZU8w-0003pL-1D for guix-patches@gnu.org; Tue, 07 Mar 2023 05:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61587] [PATCH 0/8] networking services refactoring Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Mar 2023 10:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 61587@debbugs.gnu.org Received: via spool by 61587-submit@debbugs.gnu.org id=B61587.167818330514683 (code B ref 61587); Tue, 07 Mar 2023 10:02:01 +0000 Received: (at 61587) by debbugs.gnu.org; 7 Mar 2023 10:01:45 +0000 Received: from localhost ([127.0.0.1]:44499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZU8f-0003ok-48 for submit@debbugs.gnu.org; Tue, 07 Mar 2023 05:01:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZU8d-0003oM-VY for 61587@debbugs.gnu.org; Tue, 07 Mar 2023 05:01:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZU8U-00006k-AV; Tue, 07 Mar 2023 05:01:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=obvBUs7mNOoDI09QByYW1oYjxm7JoSYhNCjf+WHhHVo=; b=OyQNvBfndk7KioLgI/N3 yqlNcejn2pscETPSrLg64m7dRyAnQYc0YkzQwe/XSOzoKmM5JGoTGDeoR/CQqvXX/Mh6sqXpw9OpK aaVb0BdinYvOgTJHk1gCKOZ9qToW/SBXHEIk8A607fqGewGT/xXmT76WVTaMSDSq+cjkHmeK0EZRm fMo8w3t378p+yXDLVfRa+1Isk5l99YWwVSP+GdzGrlj9Il6wvxb6xxgVQ9BZT4rK9ZAFSd3DK1jS1 GGfSZaIHbCdK+X3HYnfVzBMiHq06RoXHHcLlMlvpki+NzLIMLkRxWC+Z85M/FdQI0wJxhmxfH5oPw SLeFsxJQR94tOg==; Received: from [193.50.110.138] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZU8T-00012r-El; Tue, 07 Mar 2023 05:01:33 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Tue, 07 Mar 2023 11:01:30 +0100 In-Reply-To: (Bruno Victal's message of "Fri, 3 Mar 2023 22:59:06 +0000") Message-ID: <87bkl4ev7p.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678183339; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=obvBUs7mNOoDI09QByYW1oYjxm7JoSYhNCjf+WHhHVo=; b=bLCu5ab+z8F7+awvjJwAiNPNzUvsBuEbWSomT3Jx1HFTOTzWlN+BW8ZoP9wBZ33yrMM7Xu OOZOQnJJEGEUzxYOfvzCF2BRT/UUkiF8pD4RsHaYTRiVrFrS7BM0E92C5INUk8GlqR5kl1 hzgOBJcm94oYYnE1e3vUXrstVuCEuJquxBcfL49nETIjVZi3FMTFDfIIDb03F0paq+0fSX /vPH6AOkvwLovM0kqrw428hWNKL5+iR7fLTojrASXFNgDUFA4av6ue2yuvP93Brhgx1FVb j6jQ9Ks/TKFRbsnsVHB8n0mST4mW5Dm+4VKG00QcvOeSJM9wQDykpvR67uGI7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OyQNvBfn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678183339; a=rsa-sha256; cv=none; b=RhYO1S2fXwTaxmPaRG592p7aztZoLzI6U/wXPqeFqMckXHa8aDc4UqQa+0L6Q1jKuorbKn 5vD5JZG6gs65YMHBIPdGLL/2u1FCpelFQ1zqP1aFz3MB8GQs26iuBj1R+UUwnUEjT2YhF1 V1+yzOKfKrl6GrXWejZRqQW4SG/f52uH8vHBwUtpzb1PxCcYBbgDa/KJFlvpGigbgX79f4 lq8qiKR9mqragFjWxF+q16rf7dnyxvYyKpz3bt7Q8gJKNz70zIh+1uUvuKPpR90E19COAw l8vIZVOGExxMxsxEwfnxErkp2UAo2nLmMADe15x9LBY6pYvTtfCLyEoTyGXQOw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OyQNvBfn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -2.61 X-Spam-Score: -2.61 X-Migadu-Queue-Id: 379BD2E167 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7iQVjxaJkg6b Hi, Bruno Victal skribis: > Note: This also makes wpa-supplicant an optional requirement. > > * gnu/services/networking.scm () > [shepherd-requirement]: New field. > (network-manager-shepherd-service): Honor it. > (network-manager-configuration-shepherd-requirement): Export accessor. > * doc/guix.texi (Networking Setup): Document it. [...] > +@item @code{shepherd-requirement} (default: @code{()}) > +This option can be used to provide a list of symbols naming Shepherd ser= vices > +that this service will depend on, such as @code{'wpa-supplicant} or > +@code{'iwd} if you require authenticated access for encrypted WiFi or Et= hernet > +networks. For clarity, I=E2=80=99d write the list: @code{'(wpa-supplicant)}. > + (shepherd-requirement network-manager-configuration-shepherd-requireme= nt > + (default '())) [...] > - (requirement (append '(user-processes dbus-system loopback) > - (if iwd? '(iwd) '(wpa-supplicant)))) > + (requirement `(user-processes dbus-system loopback > + ,@shepherd-requirement > + ,@(if iwd? '(iwd) '()))) To preserve backward compatibility and to provide a reasonable default (with working WiFi), I think the default for =E2=80=98shepherd-requirement= =E2=80=99 should be '(wpa-supplicant) rather than the empty list. (BTW, it seems that wpa-supplicant can be DBus-activated, maybe that=E2=80= =99s what we should do instead? But let=E2=80=99s forget about it for this patch series.) Thanks, Ludo=E2=80=99.