all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 62008@debbugs.gnu.org
Subject: [bug#62008] [PATCH 0/2] Update Disarchive to 0.5.0
Date: Fri, 10 Mar 2023 09:17:50 +0100	[thread overview]
Message-ID: <87bkl1aukx.fsf@gnu.org> (raw)
In-Reply-To: <87a60odep4.fsf@gmail.com> (Simon Tournier's message of "Tue, 07 Mar 2023 11:43:35 +0100")

Hi Simon!

Simon Tournier <zimon.toutoune@gmail.com> skribis:

> On mar., 07 mars 2023 at 10:49, Ludovic Courtès <ludo@gnu.org> wrote:
>
>> For this package, I have a slight preference for keeping propagated
>> inputs so that one can use Disarchive as a library.
>
> Well, maybe I am missing a point but currently for Disarchive standalone,
>
> $ guix shell -C disarchive -- disarchive disassemble hello-2.12.1
> Backtrace:

Hmm good point.  So maybe we need to wrap after all, and also keep
propagated inputs (as an example, (guix build download) uses the
Disarchive modules directly, not the command.)

I realize that I worked around it in ‘etc/disarchive-manifest.scm’.

>>> +              (let* ((effective
>>> +                      (read (open-pipe* OPEN_READ
>>> +                                        (string-append #$guile-3.0 "/bin/guile")
>>> +                                        "-c" "(write (effective-version))")))
>>
>> (guix build guile-build-system) exports ‘target-guile-effective-version’
>> to do that; it’s more convenient.
>
> I did not know.  Well, I will adapt Cuirass and Dezyne too, IIUC. :-)

Awesome.

>
>>> +                     (modules (list #$output
>>> +                                    #$guile-bytestructures
>>> +                                    #$guile-gcrypt
>>> +                                    #$guile-lzma))
>>
>> This should use (this-package-input "guile-bytestructures“) and similar,
>> for consistency.
>
> Ok.  Just for my understanding about the "consistency”, is the procedure
> ’make-gitolite’ from (gnu packages version-conrol) consistent?

It should use ‘this-package-input’ as well, to keep input fields and
inheritance meaningful.

Thanks,
Ludo’.




  reply	other threads:[~2023-03-10  8:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 19:18 [bug#62008] [PATCH 0/2] Update Disarchive to 0.5.0 Simon Tournier
2023-03-06 19:19 ` [bug#62008] [PATCH 1/2] gnu: disarchive: Wrap program instead of using propagated inputs Simon Tournier
2023-03-06 19:19   ` [bug#62008] [PATCH 2/2] gnu: disarchive: Update to 0.5.0 Simon Tournier
2023-03-07  9:51     ` [bug#62008] [PATCH 0/2] Update Disarchive " Ludovic Courtès
2023-03-07  9:49   ` Ludovic Courtès
2023-03-07 10:43     ` Simon Tournier
2023-03-10  8:17       ` Ludovic Courtès [this message]
2023-03-10 11:41         ` Simon Tournier
2023-03-10 16:44           ` Ludovic Courtès
2023-08-16 17:28             ` Simon Tournier
2023-08-18 13:56               ` Ludovic Courtès
2023-08-18 15:03                 ` Simon Tournier
2023-08-19  8:57                 ` Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkl1aukx.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=62008@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.