From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yImPBVi6GWRdLQEASxT56A (envelope-from ) for ; Tue, 21 Mar 2023 15:08:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KNqFBFi6GWQuTAEAG6o9tA (envelope-from ) for ; Tue, 21 Mar 2023 15:08:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D28828B49 for ; Tue, 21 Mar 2023 15:08:23 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ir90uDqX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679407703; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=vjzdVliZQHvNrkaJjEcrFFNACuFlCvNz57mccC8Qqlg=; b=VgWKowaQKAj+wpjBZ8j6VgqY5g7nJ2JFTBzaG/8EWCfvaS6bjYtXKsEUERIgAFnmCXO2ls gGicPurOkB3U0f5S1WhX0OxQfnYRMQiw170AthmgSduPiogRkHILyO46bF+Xv6JtRYBtrC bvyPskTqzdeOot3wZbG+nr0UpY/fkNUiuuf2bBW+roxunvfPnsCjkrdUV/my+OPPuS0wZ5 9gfbGxX/4f2M42wiand1Js6rpJRjc9UqhT5k5s1lSaQ6mwVQms1BK6xFMrV/mjZXleys2r ZkHgdpcYKbY8E+wFmTtloOEQAwB2Uz7VibB7TNpz47nFhJybyCI4bgTbWeNM7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ir90uDqX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679407703; a=rsa-sha256; cv=none; b=UIFhKnYi2ubDBqDttTPrNSfjtsbd33BcxqO6eYTJTmh+irJUGK/RalMpN2MeLd6ZQ6wuLa d5mX/RGjC1V7llDLEv6oBt+xBrtix21/P389poQVAJc55h2/hQ3f1LUHrYWHrEnaTZdymF UsEfNitkVAKPherj4DYBIGXXETMn7d42gESMrla4l+jwC93eCuaIJ58Tyvv643gLIrd5io ONissrru3hVrSPURxTlhms3Ie0ued/cO7ZwOqNrNdKJvScECgSc8ElJq7pSi9BH/4M+Oe2 QeMoOJ5XsjFRzkZV2UqOBgCDhXAX8vUBDw1Zfqykw9Bc2gC94cnH2ISJVCebOg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peceh-0006zc-72; Tue, 21 Mar 2023 10:08:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peceg-0006xV-6R for guix-patches@gnu.org; Tue, 21 Mar 2023 10:08:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pecef-0004Rn-TN for guix-patches@gnu.org; Tue, 21 Mar 2023 10:08:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pecef-0002Tp-Lm for guix-patches@gnu.org; Tue, 21 Mar 2023 10:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#59851] Add Moonlight Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Mar 2023 14:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59851 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: phodina Cc: 59851@debbugs.gnu.org Received: via spool by 59851-submit@debbugs.gnu.org id=B59851.16794076709515 (code B ref 59851); Tue, 21 Mar 2023 14:08:01 +0000 Received: (at 59851) by debbugs.gnu.org; 21 Mar 2023 14:07:50 +0000 Received: from localhost ([127.0.0.1]:60049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peceT-0002TO-Pf for submit@debbugs.gnu.org; Tue, 21 Mar 2023 10:07:50 -0400 Received: from mail-qv1-f51.google.com ([209.85.219.51]:44731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peceO-0002T4-Un for 59851@debbugs.gnu.org; Tue, 21 Mar 2023 10:07:48 -0400 Received: by mail-qv1-f51.google.com with SMTP id 59so4020318qva.11 for <59851@debbugs.gnu.org>; Tue, 21 Mar 2023 07:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679407659; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vjzdVliZQHvNrkaJjEcrFFNACuFlCvNz57mccC8Qqlg=; b=ir90uDqXxIXB+HcKNbdpjFWGb6OnruVHqQMF4kyfp/wV6D4KG6Re2W9dRAuEGSvSgG 8c5h/EH4ysT5WuJuRibqylBzUpg10oXZH5hJlVji2c1F7P+RXoVQxhqW0VHpqpvVTVQF AiqL66+xrO+9EkR8gjhyIdaM+0c11k7Lx58MO7+eWF4wRIzHeKFV40b4wvMe1KW2P6Xd ZrkqZ7B2UzXZZcp+sYrpc/md696aa7vDQ4o0iTGeX15lUprx44fDhU8nUWjkuQJU7xNf CLMkgiY7hUgrceXQtp5dONzuYS+NspqAK2eQxLs0ozC0DrhBtBNo1rRGDmg4umWDpOHs zKrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679407659; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vjzdVliZQHvNrkaJjEcrFFNACuFlCvNz57mccC8Qqlg=; b=cnHWKe+/wR2EFbTU4yplM07QOGCrKEPyCJvJzHKii3Q+nlJgBpyPAGVBLO99dibAJM T6ofAkpkxUBLWKVI71AiLQMp5qch4MfU3S+dHzrvSjaWfT5qQYEHXIX+Cl+Kr9b2YUxO 46ldqVZKFayb33ewLGwh2FzNcqiWe+MbOQHOLt/4Uft403CUTvxXHHzoGdkAxgjUtb3S elZq+0F9zkbrxdinquv2hJG+qPwq6onh2U3TfnmAOo9i3ZZ5N7f0bURT5uvYH1mFoj81 r4Lvqn7Hwn8F0ZkRv+8nZJIzSeHaTdOrApgLWNmKxluFRQcubtm/8gqJggfBocsmasO0 Q8DQ== X-Gm-Message-State: AO0yUKWySExV9M+YrEks8OL9tx69jTWrkHdpwCY57WNAjHjWVlGHwbBD CrYuxy+KgG3Zg3lSWW9u3veg1gY1QF4V5w== X-Google-Smtp-Source: AK7set8vJGiqRDY4+EOdkQqOD5+Zc36dw71Dct/5vAnY1RkRjSUNfDFuSuEEgSK0ysFp+0jfRESPog== X-Received: by 2002:a05:6214:27eb:b0:5d1:d9f3:dd83 with SMTP id jt11-20020a05621427eb00b005d1d9f3dd83mr4485555qvb.7.1679407658704; Tue, 21 Mar 2023 07:07:38 -0700 (PDT) Received: from hurd ([2607:fad8:4:3::1004]) by smtp.gmail.com with ESMTPSA id j2-20020a378702000000b00746059d9c3fsm9439819qkd.35.2023.03.21.07.07.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 07:07:38 -0700 (PDT) From: Maxim Cournoyer References: <87cz7e8nlw.fsf@gmail.com> <878ri115m6.fsf@gmail.com> Date: Tue, 21 Mar 2023 10:07:37 -0400 In-Reply-To: <878ri115m6.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 17 Jan 2023 11:35:29 -0500") Message-ID: <87bkkmqjti.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 9D28828B49 X-Spam-Score: -3.15 X-Migadu-Spam-Score: -3.15 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: s9kzstE/0iRe Hello Petr, Maxim Cournoyer writes: > Hi Petr, > > phodina writes: > >> From a18528bd178c177f50e73de4b89ccbf758ab1774 Mon Sep 17 00:00:00 2001 >> From: Petr Hodina >> Date: Sat, 3 Dec 2022 10:36:38 +0100 >> Subject: [PATCH v2 6/6] gnu: Add moonlight-qt. >> >> * gnu/packages/games.scm (moonlight-qt): New variable. >> >> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm >> index 5f5bd8795e..6600c1ee60 100644 >> --- a/gnu/packages/games.scm >> +++ b/gnu/packages/games.scm >> @@ -5841,6 +5841,66 @@ (define-public bambam >> colors, pictures, and sounds.") >> (license license:gpl3+))) >> >> +(define-public moonlight-qt >> + (package >> + (name "moonlight-qt") >> + (version "3.1.4") >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/moonlight-stream/moonlight-qt") >> + (commit (string-append "v" version)))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + "02y2rbiiawhj1dvgxdaz8k9kpz6zkv20zsk17fbqj8259m3g5xr5")))) >> + (build-system qt-build-system) >> + (arguments >> + (list #:tests? #f ;no test suite >> + #:phases #~(modify-phases %standard-phases >> + (replace 'configure >> + (lambda* _ >> + (symlink (string-append #$(this-package-input >> + "sdl-gamecontrollerdb") >> + "/gamecontrollerdb.txt") >> + "app/SDL_GameControllerDB/gamecontrollerdb.txt") >> + (substitute* "moonlight-qt.pro" >> + (("moonlight-common-c \\\\") >> + "#moonlight-common-c \\") >> + (("qmdnsengine \\\\") >> + "#qmdnsengine \\") >> + (("app \\\\") >> + "app") >> + (("app.depends") >> + "INCLUDEPATH +=") >> + (("h264bitstream \\\\") >> + "#h264bitstream \\")) >> + (invoke "qmake" >> + (string-append "PREFIX=" >> + #$output))))))) > > The above could benefit from a comment explaining what this is about > (mostly unbundling libraries, it seems). > >> + (native-inputs (list pkg-config qttools-5)) >> + (inputs (list ffmpeg >> + h264bitstream >> + libva >> + libvdpau >> + moonlight-common >> + openssl >> + opus >> + qmdnsengine >> + qtbase-5 >> + qtdeclarative-5 >> + qtquickcontrols2-5 >> + qtsvg-5 >> + sdl2 >> + sdl2-ttf >> + sdl-gamecontrollerdb)) >> + (synopsis "GameStream client") >> + (description >> + "Moonlight is an open source implementation of NVIDIA's GameStream, as >> +used by the NVIDIA Shield.") > > There's no need to use 'open source' or similar adjective in Guix, as > this is already implied for the whole collection of software offered. > > Thank you, and apologies for sending my comments in multiple small > chunks. Gentle ping. See the thread for the full review comments. -- Thanks, Maxim