From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UMUoHM+LYmQZkwAASxT56A (envelope-from ) for ; Mon, 15 May 2023 21:45:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2JIKHM+LYmQ/NAAAauVa8A (envelope-from ) for ; Mon, 15 May 2023 21:45:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2DDB0379EE for ; Mon, 15 May 2023 21:45:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pye88-0002ba-3b; Mon, 15 May 2023 15:45:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pye7z-0002a1-0n for guix-patches@gnu.org; Mon, 15 May 2023 15:45:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pye7y-0001sZ-Oo for guix-patches@gnu.org; Mon, 15 May 2023 15:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pye7y-0004OE-Ho for guix-patches@gnu.org; Mon, 15 May 2023 15:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 May 2023 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63499 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: rg@raghavgururajan.name, 63499@debbugs.gnu.org Received: via spool by 63499-submit@debbugs.gnu.org id=B63499.168417989616847 (code B ref 63499); Mon, 15 May 2023 19:45:02 +0000 Received: (at 63499) by debbugs.gnu.org; 15 May 2023 19:44:56 +0000 Received: from localhost ([127.0.0.1]:44487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pye7s-0004Ne-15 for submit@debbugs.gnu.org; Mon, 15 May 2023 15:44:56 -0400 Received: from mail-qv1-f42.google.com ([209.85.219.42]:47471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pye7n-0004NQ-UH for 63499@debbugs.gnu.org; Mon, 15 May 2023 15:44:55 -0400 Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-61b2f654b54so63365466d6.3 for <63499@debbugs.gnu.org>; Mon, 15 May 2023 12:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684179886; x=1686771886; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=RGjxBYIm7x8xsKm8S4gKCFz33EHp7xW4GeSLqJR1yIE=; b=Ij/rSx5NAolegMlupgB8SjWK9ffoXpKx3FX+w93f5aJZEDOxtmd6Uv/Mpmyixscu59 PiyStGoVBiIQyNSoo4PSMP3KbXttYgN886lTgqeSS5GC1nFuSRr11tipbQ4vhrnHoPVJ ja8apppFFbyuWOQI409oVS3hOUmouC+vKUlCRSETcex2VRMEz51wHZyNjzXMyy8zEiTf 4bUBbkZ5bujLT4zTD9X5rVFSuZKQdMJQ6CRyDq4EIvRcBLe2WRf+lsQHNmh6ZLae9UeF X1AUR8SZ0NEXqai24wPghoxUEW8qTBH1X7M0U4aT0n4F+sYm8EdgwCCIfAeGLzNYb/HK ml4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684179886; x=1686771886; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RGjxBYIm7x8xsKm8S4gKCFz33EHp7xW4GeSLqJR1yIE=; b=TShg0A0MPO8qH7uTyj/k2T9DGmscwUtxXBt6kcpZL6T9KRJ5Q4J4zDwd7XzDCBhN26 L2HEDbzlX3Vpt1OwnTZwIxoHA7rPsOCZyuPW0fXrjE10jvaxusCHzrtYTjktOCo9ijGd RTxunvsHDPaHv+oA9Ub5OIl1aV/XVIIUXUPluhx+lFA8kTtZ/uQ1Lcutz0EHPIh+VqVA 2tq7VLOhiM8ax5shWyNbr8cCwhyzrfodhd7PQt8CkJ7R0/vQBZWa3cYzHjpSU09zPs0n jQFDsPPXnl3KOEqk87d2fHwSmIhBd5xig2TggUKkeYQsR69S6R7uzdfkCxJ2opkUAUe7 z95Q== X-Gm-Message-State: AC+VfDyQuhXc+ll51ElLOSMVIXmbzH0PMRvIl9tx0AMa/2JRewdNE250 naWMS+Em301QnKmEaBXivmY= X-Google-Smtp-Source: ACHHUZ5NS8UyGu6Lr6ZS5PYXMzoA3LQAUrbpFx0gDfxRVLc215i8KoUHHGnrHdlVCK8myoiuTYytVA== X-Received: by 2002:ad4:5bcc:0:b0:623:6b1a:c5f1 with SMTP id t12-20020ad45bcc000000b006236b1ac5f1mr4032519qvt.4.1684179886119; Mon, 15 May 2023 12:44:46 -0700 (PDT) Received: from hurd (dsl-205-236-230-106.b2b2c.ca. [205.236.230.106]) by smtp.gmail.com with ESMTPSA id p11-20020ae9f30b000000b0074d3233487dsm20435qkg.114.2023.05.15.12.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 12:44:45 -0700 (PDT) From: Maxim Cournoyer References: <3e89f7f30708b5702e1283534348cfc486ec0c61.1684060546.git.liliana.prikler@gmail.com> <87o7mlvh5m.fsf@gmail.com> <0ad9996e83f9116f505ba4498f8629bdf06f5b13.camel@gmail.com> Date: Mon, 15 May 2023 15:44:44 -0400 In-Reply-To: <0ad9996e83f9116f505ba4498f8629bdf06f5b13.camel@gmail.com> (Liliana Marie Prikler's message of "Mon, 15 May 2023 20:27:36 +0200") Message-ID: <87bkiltm4z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684179919; a=rsa-sha256; cv=none; b=IOzG58PxzWS2i6E4GnxbQXpsNJfC/8NiQIkeikZeg5JYnRyFBNXTTu0UBiRFpNNLEGKZUO R6R0kUMzFUBAp3qHvVEEjkuOKC4ddLnuJm1HOwVJE6RY8lrILO5zVU5fzew8eEp+FaznmX SdnVDapro9tXlBgmSY7VO/FiG9K/pZ6Fk2T+PQGCOzShxdrk8UDwMO1TrKFO6pbn21cwSC AdLzOjspYYdF8pWlp4nPww+VlgRMjWQFOx86pzl4prk7sFBPZlcI0l29L13taQqO9SChPc uvWq7UayLi/WExWTJmMZN7/gmAiWIUA6cL86LU8Hb6V15tmdLszUZMDK3xUiww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="Ij/rSx5N"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684179919; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RGjxBYIm7x8xsKm8S4gKCFz33EHp7xW4GeSLqJR1yIE=; b=VjbFd7VY+icEdlgliGLJM8LbXeVde3z2AzG2ouso6Uy/PwyP5UEgwtHqkpNT+XEYbettX2 0A+J6rqmesNUgfZFg/XiZL1cLSRgngAzIh554xh4kYT67wuEByDdhzCNm4OxjpeHNI6Bf+ fEIXMaDNVvVRBfgy1D5CdKQy3iOd0sCJPFDJeAGs6Y5TkMNYiffHXeCNpstuU6qi+ek+Da H2N5knx7+dGwkcYZ3V+IhU2F8RD67p6pcaBiyxpiawJXCZt3YAvJqZWtDhk5J0nnapj58Y 2UaxwMv1Q9XmwbJfXzhleXdwBv7JNtu68V6OZSWpprvATDfs9tgvRYejI6JVoQ== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="Ij/rSx5N"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.31 X-Spam-Score: 7.31 X-Migadu-Queue-Id: 2DDB0379EE X-TUID: 0/+N1ylW286U Hi, Liliana Marie Prikler writes: > Am Montag, dem 15.05.2023 um 09:49 -0400 schrieb Maxim Cournoyer: >> Hello, >>=20 >> Liliana Marie Prikler writes: >>=20 >> > * gnu/packages/gtk.scm (gtksourceview)[#:phases]: Set >> > =E2=80=9CGDK_BACKEND=E2=80=9D >> > and =E2=80=9CGTK_A11Y=E2=80=9D. >> > --- >> > =C2=A0gnu/packages/gtk.scm | 3 +++ >> > =C2=A01 file changed, 3 insertions(+) >> >=20 >> > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm >> > index de45eb3870..7d76610293 100644 >> > --- a/gnu/packages/gtk.scm >> > +++ b/gnu/packages/gtk.scm >> > @@ -616,6 +616,9 @@ (define-public gtksourceview >> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ;; Tests require a running X server. >> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 (system (string-append Xvfb " :1 &")) >> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 (setenv "DISPLAY" ":1") >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 ;; For GTK >>=20 >> Nitpick: Add a full stop (period) for standalone comments.=C2=A0 Perhaps >> expound how these environment variables are useful to set ('For GTK' >> leaves me wondering, as 'gtksourceview' already seems GTK-focused). > Full disclosure, I don't quite understand what's wrong here myself, but > with the upgrade to GTK 4.10, tests fail > - due to GDK_BACKEND not being said for ??? reason > - due to GTK_A11Y because GTK tries to spawn dbus and fails to connect. > >>=20 > If there's a better wording for that, I'm all ears :) Perhaps above setenv "GTK_BACKEND" mention "XXX: To avoid failures in tests." and then above GTK_A11Y mention "Otherwise, GTK tries to spawn D-Bus and fails to connect." This captures everything you know; I think it's an improvement. --=20 Thanks, Maxim