From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IN8qMNIne2RGLgEASxT56A (envelope-from ) for ; Sat, 03 Jun 2023 13:45:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YNLeL9Ine2QyQwEAauVa8A (envelope-from ) for ; Sat, 03 Jun 2023 13:45:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 838EA26A66 for ; Sat, 3 Jun 2023 13:45:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5Pgv-0004Yx-3q; Sat, 03 Jun 2023 07:45:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5Pgs-0004Yd-1U for guix-patches@gnu.org; Sat, 03 Jun 2023 07:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5Pgr-0000ac-Pc for guix-patches@gnu.org; Sat, 03 Jun 2023 07:45:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5Pgr-0005LG-Lb for guix-patches@gnu.org; Sat, 03 Jun 2023 07:45:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#61363] [PATCH v3] self: Apply grafts to the outputs of the guix derivation. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Jun 2023 11:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61363 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: 61363@debbugs.gnu.org Received: via spool by 61363-submit@debbugs.gnu.org id=B61363.168579265120444 (code B ref 61363); Sat, 03 Jun 2023 11:45:01 +0000 Received: (at 61363) by debbugs.gnu.org; 3 Jun 2023 11:44:11 +0000 Received: from localhost ([127.0.0.1]:41688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5Pg3-0005Jg-46 for submit@debbugs.gnu.org; Sat, 03 Jun 2023 07:44:11 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5Pg0-0005JX-Bh for 61363@debbugs.gnu.org; Sat, 03 Jun 2023 07:44:09 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id DB06C27BBE2; Sat, 3 Jun 2023 12:44:07 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id e36f618a; Sat, 3 Jun 2023 11:44:07 +0000 (UTC) References: <871qn08uo7.fsf@cbaines.net> <20230417145928.16693-1-mail@cbaines.net> <86353w76i6.fsf@gmail.com> User-agent: mu4e 1.10.2; emacs 28.2 From: Christopher Baines Date: Sat, 03 Jun 2023 12:41:57 +0100 In-reply-to: <86353w76i6.fsf@gmail.com> Message-ID: <87bkhw6a9k.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685792722; a=rsa-sha256; cv=none; b=f/uItZCaYhIAfXlqKnZMkQVReBiOPt+LKNp3CgCYvI9sAr454p3+k4pA6OuC8M5GaWlnh5 7jz+tZkFTAKS/LL/MwLkMEiE7StFSkxW7NPosdXjE8Vcc4ecD8FIUsd63TcFOrIKpAd3Iq pCzYY3M89A/PuoTKy08q4dyszVYZ18CphkaeriAA+5lrx4sxZOH2dJRdulFP5a7e0m0VLj ljLS+muv+WWIUD7rlRes8/ZcNc0k3FU/lFoSR0Tpacu9/mG4SGCyb7p35XylnGXnusgrrI ntS0djuy2G72qvSKiJIV02iQqvoJkOgNm9CldZireG/eYuiFx0/simZXhbIYWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685792722; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=uhLzHPoEiOrOYK2tMwaZjt+gRJg3nWFxaZPyb4iiB0I=; b=JbfvyuMx2EdrOgoXFndZY+BQhV053hpdseVzEhTEUZKzHsn1d6e4saaMc//q3eYRNzkaAE esNGQEmhzibQnH2I2aqAgFq/DFugzmY+w7Ef5Xn+RxcFAtPT2/U7E/R6L0louZDaHmlWJR tzGMeqBlxlOHaYY6cmAgzSFOCn6zXO9Cqoj4kzPK1y9TS3TflQTH1LP5w6gLhHBK8l831g wal1W9FIMzMJkVTFEuT09IWP0k8ZAgOhHj/vH50GquzVX30YOIc+Z/8egAhV7C8HavahMV pW+QZyFysiLcX/pNfpa4Rdx/Rk3/dDAHyoq40oa3QIlnhX4JdPQlb1GzWdSC6g== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -7.18 X-Spam-Score: -7.18 X-Migadu-Queue-Id: 838EA26A66 X-TUID: Q6Dgh3GtgeTx --=-=-= Content-Type: text/plain Simon Tournier writes: > Hi Chris, > > I am late to the party and probably do not well understand all that > part. Just a quick comment in the same direction as Ludo. > > On Mon, 17 Apr 2023 at 15:59, Christopher Baines wrote: > >> diff --git a/guix/self.scm b/guix/self.scm >> index 74c953bd50..bbc0beaca8 100644 >> --- a/guix/self.scm >> +++ b/guix/self.scm > > [...] > >> + (if graft? >> + (explicit-grafting obj >> + (map (compose force cdr) %packages)) >> + obj))) > > [...] > >> + (if graft? >> + (explicit-grafting obj >> + (map (compose force cdr) %packages)) >> + obj))) > > It means that the grafts are only applied to %packages, right? > > Other said, defined by: > > (define %packages > (let ((ref (lambda (module variable) > (delay > (module-ref (resolve-interface > `(gnu packages ,module)) > variable))))) > `(("guile" . ,(ref 'guile 'guile-3.0-latest)) > ("guile-avahi" . ,(ref 'guile-xyz 'guile-avahi)) > ("guile-json" . ,(ref 'guile 'guile-json-4)) > ("guile-ssh" . ,(ref 'ssh 'guile-ssh)) > ("guile-git" . ,(ref 'guile 'guile-git)) > ("guile-semver" . ,(ref 'guile-xyz 'guile-semver)) > ("guile-lib" . ,(ref 'guile-xyz 'guile-lib)) > ("guile-sqlite3" . ,(ref 'guile 'guile-sqlite3)) > ("guile-zlib" . ,(ref 'guile 'guile-zlib)) > ("guile-lzlib" . ,(ref 'guile 'guile-lzlib)) > ("guile-zstd" . ,(ref 'guile 'guile-zstd)) > ("guile-gcrypt" . ,(ref 'gnupg 'guile-gcrypt)) > ("guile-gnutls" . ,(ref 'tls 'guile-gnutls)) > ("guix-daemon" . ,(ref 'package-management 'guix-daemon)) > ("disarchive" . ,(ref 'backup 'disarchive)) > ("guile-lzma" . ,(ref 'guile 'guile-lzma)) > ("gzip" . ,(ref 'compression 'gzip)) > ("bzip2" . ,(ref 'compression 'bzip2)) > ("xz" . ,(ref 'compression 'xz)) > ("po4a" . ,(ref 'gettext 'po4a)) > ("gettext-minimal" . ,(ref 'gettext 'gettext-minimal)) > ("gcc-toolchain" . ,(ref 'commencement 'gcc-toolchain)) > ("glibc-utf8-locales" . ,(ref 'base 'glibc-utf8-locales)) > ("graphviz" . ,(ref 'graphviz 'graphviz)) > ("texinfo" . ,(ref 'texinfo 'texinfo))))) > > tweaked by e5c33837cbee98d460d9ae09b463501de6f15d97. And there is a > slippery slope: the manual addition. These had been added with > e5c33837cbee98d460d9ae09b463501de6f15d97: > > + ("glibc-utf8-locales" . ,(ref 'base 'glibc-utf8-locales)) > + ("graphviz" . ,(ref 'graphviz 'graphviz)) > + ("guix-daemon" . ,(ref 'package-management 'guix-daemon)) > + ("texinfo" . ,(ref 'texinfo 'texinfo))))) > > Other said, what does it happen if we forget to manually update this > list? Well, specification->package in (guix self) won't work for the missing packages. It's possible to use packages outside of this list, but that doesn't happen currently. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmR7J4dfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdA9Q//dkxQkEFKMrfuSmaL04m90ysfEDI1pa8e ZPAXcD4UaEwHOPq/uKjmyAmUdsFnzRdsMIZjWJZkGh1UVJiGmA+g55h46F6Zf5Pb jTHHvZeonmMSoi/YP5cLif4W0mvRpRoGRgtjdhBbHMEbfR3ww3AYoU8CrYs0AhHD 8C+pgnw6p+muWXQ4qVtaoXvN6EsyMzh++C4LrhMH7uTJp+C4Ki87LmAESTa8f7vl 4ti2k/Geawu/ENIouA8jG9SFOBOAGnGMacxd36XgpHBJs70e/oug5tkA/u9MwA20 pEXBXCDaZJiu1WkX3iLdiaQuRvE78pG8TJ2afl1iGIrG7HZ1E33kTXJqTYyYMcaH 8mBtar22hmRvvmQWLHUDchgA+wBeWWcuJZMLGQHrwV0zRyBPqD5HfQlKWRU4NFg+ PD+svkV9O1VkCVCqJ4Azm8CNE6FIyp+AuY+gdETZtWk+srkIC3yUD/30n3rssrKI PqhfftkVQQNi4Ehdzt5ck7h+lIYBXXHv+nqitD1QtRVy1DCc+U9wAHRdMhbjBxYN 5Bp3xXOH4v/0+kLzx3GqfupU/8E7ik4xYAly6QlBUrIS7yiuOl7ktM/6uZkrJ3iM UWIQCexXpQTXkrT7y1FIHPtTcPExgdLsotKj7LwCZlhPP6BlqvMeFIIoQDV8cKU2 xlwMQWIfyqw= =0LsZ -----END PGP SIGNATURE----- --=-=-=--