From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AF2YLcRN+2TKHAEAG6o9tA:P1 (envelope-from ) for ; Fri, 08 Sep 2023 18:37:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AF2YLcRN+2TKHAEAG6o9tA (envelope-from ) for ; Fri, 08 Sep 2023 18:37:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C16CD6A865 for ; Fri, 8 Sep 2023 18:37:23 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pWyTDTud; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694191044; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7y5EklrcBD+XMh3Qg1ab02aiWGzTXjDpUt78Zkht64s=; b=ZIMXion8+b21pdKuhfjjffQHMrYcWXRqc1Bn1GhSiJUxbKXQDjFqhoSi4laeNbRsUpzXPN VQjejssh7i5fhtbY/e5eI0l7/0M6xawJr7xC1W7jv8hC00uyIlp7k86po3badFvZa7j3sy w7BCuTsKW6gbHPtJ1D5JZkkvLiMMTZxQSRwyfAb3CkoD73Ht6Ky9mKsy+Fe2onE2hqOfqf fQ/XT8p+eHoZF30FjRNmFZkUOrULx2YTwUrxoOoTpnN1N+G9cwGkjUxdxkOaHJ278+i4ZX t2bJ//isvjaBfFebjaB0xLUmAfTfq9BYVfppKu7S7CCuIoeRkTHUNVHuHVqxWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pWyTDTud; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694191044; a=rsa-sha256; cv=none; b=KqdRx72GlvnEwE9G5gBbEdAl4rzOAI7VNNp5wGhypOB/HszBB4XOYdsfBwZuolrViDKrPP Kohp72uqE5GALkD7tNy+lugiaW9jJ3WwvQBhMY4sHW9OXc25hOlEX/Lb9MdVStOGksQR2B Lqi92dXGLcABvttWS+DcIxTVxw/AXwJ+vWcsZbml50mzNEIJn14/0o1ozmuwCYf0TKM4L+ sWIoOpzO4vFyJ/wrftUQs4v0zyI/9WbHBoyAFthjtJpjsbpHqM1TIVuHMYPN9wW5yDD6P5 TlDeMfSqFrIWG6oBSdAwM85XpaprAB8/STG5zs2ZYcfbNTk+COqzNNYWN+NtmA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeeTe-0004c0-8F; Fri, 08 Sep 2023 12:37:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeeTc-0004bb-IV for guix-patches@gnu.org; Fri, 08 Sep 2023 12:37:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeeTc-0002J2-9X for guix-patches@gnu.org; Fri, 08 Sep 2023 12:37:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeeTe-0001ap-JL for guix-patches@gnu.org; Fri, 08 Sep 2023 12:37:02 -0400 Subject: bug#65426: [PATCH v2] lint: Check that (cc-for-target) and friends are used. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 08 Sep 2023 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65426 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 65426-done@debbugs.gnu.org, Christopher Baines Mail-Followup-To: 65426@debbugs.gnu.org, ludo@gnu.org, maximedevos@telenet.be Received: via spool by 65426-done@debbugs.gnu.org id=D65426.16941910206104 (code D ref 65426); Fri, 08 Sep 2023 16:37:02 +0000 Received: (at 65426-done) by debbugs.gnu.org; 8 Sep 2023 16:37:00 +0000 Received: from localhost ([127.0.0.1]:45356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeeTb-0001aN-TQ for submit@debbugs.gnu.org; Fri, 08 Sep 2023 12:37:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeeTY-0001a9-Kz for 65426-done@debbugs.gnu.org; Fri, 08 Sep 2023 12:36:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeeTO-0002Hv-80; Fri, 08 Sep 2023 12:36:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=7y5EklrcBD+XMh3Qg1ab02aiWGzTXjDpUt78Zkht64s=; b=pWyTDTudAavdujQKDK0a hlgFVN/RYHA7oPWeTjLdUDGKkqP5+45W6hVej5aaDCpcsS2grA8fS5P5inlhVIXmV2avg4F3O6sXB 46PUajLZUoTVfCn6DJm/bpoNLbdkW4kXZ6D212a+uYAcvbeGJEkUANLYa0eSJp/IZIyBeBeVDbkqi eiDGPrTsWraaM2KiyaX0NmQE8OH0WUy+i5Q1jV1TVYZwLN+AbnSHT5lgyJnmsh3eZtsLkRd/EfyW9 JohjNmsdH+68Rfdrb1L9RmjrtuhE9qAVq9LVD7hywRDjd0DMLxVz3h165G+9i6irX/7W0WpB/z9yN V7/+iLcukSqYRw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <79bb8251f2c668c1af68b6fc5362149e3987f7e5.1692623240.git.maximedevos@telenet.be> <025525cb01ccce0a9e7a07bc9338423961eaa355.1692626393.git.maximedevos@telenet.be> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 22 Fructidor an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la Noisette X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 08 Sep 2023 18:36:43 +0200 In-Reply-To: <025525cb01ccce0a9e7a07bc9338423961eaa355.1692626393.git.maximedevos@telenet.be> (Maxime Devos's message of "Mon, 21 Aug 2023 15:59:53 +0200") Message-ID: <87bkec4o6c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: C16CD6A865 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -5.33 X-Spam-Score: -5.33 X-TUID: zXVoa7t/5wpS Hi Maxime, Maxime Devos skribis: > "CC=3Dgcc" is almost always incorrect; people often just don't > notice the incorrectness because they are compiling natively. > For an exception, see tzdata. > > "guix style" partially made things worse, so I partially ignored it. > > * guix/lint.scm (check-compiler-for-target): New linter. > * tests/lint.scm > ("compiler-for-target: unconditional CC=3Dgcc is unacceptable") > ("compiler-for-target: looks through G-expressions") > ("compiler-for-target: (cc-for-target) is acceptable") > ("compiler-for-target: CC=3Dgcc is acceptable when target=3D#false"): > Test it. Finally applied, thanks! It=E2=80=99s a much welcome improvement. Ludo=E2=80=99.