From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id IMCXN8iC0mWfRwAAe85BDQ:P1 (envelope-from ) for ; Sun, 18 Feb 2024 23:20:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id IMCXN8iC0mWfRwAAe85BDQ (envelope-from ) for ; Sun, 18 Feb 2024 23:20:57 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jsPYKuUg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708294856; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OkUSHiEHHVcRWAHrQkbEufgV4pZZqRWcdzoDEcDagcM=; b=lhX0rKR0BCWr5Wx0U++57c307/tvoff3bLRWvjJ3qogslMzlXcGlq90H8DvVJgCA0C8Qq8 QRbPUNFr9bNK8szO+RQj4c5N9f35CwjjvQK4ZxzR76Yhd8lT2p7wKeAHV0ri+DJs1mZaHM sgzA2r0EN0rw7ZsWuuoOXR5EBsebYpwkxmCZefFfDEBr1gUyycVF4bvoBIXGz8+r4Lmstq /SwcVEy1VWhjkeqz2vPOepnTiV8A/wXF1aIbwXXVkWDoXtwZoSoRfeVSM60RH18J/8JOVc Hdkcd2P+H0Ncd2jHSEzBQg4m5Gjr8CTUOap3v9eAw2259gJ4FzL7qRF9mKOSCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jsPYKuUg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708294856; a=rsa-sha256; cv=none; b=e/xu4ffEHmKXSmHpI+Q25KSQs+NSPViIYcsowXHwLgf3y0K9AFnzxqYXJkt+OYUZB5Nryy YYSMWtng8V0LLs6Edrio2U9QWVqeoSUPPOkBLvFtBHHsaL4oHoUe/dXK2505g2Woofdvkb wYyg069QA/60MrXfSRuSCORnrw/zxgtE2nVFy7UqqmZslF7jH3WD2q2FXjy0TzY+nkExd4 aZnfLuSypXCTExsSNJgDGjXzXZd6h9oaHU6n1rgjfkjn0yd0gp530R11fN04sdiID267Vj UKg4ue3EsJtjXSE+dxi1GOCmnpXbrb6ux4sp6oo2jtER8VYVe1RP98Ohq6xO+A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9875447DA8 for ; Sun, 18 Feb 2024 23:20:56 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rbpWd-0003yw-BL; Sun, 18 Feb 2024 17:20:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbpWb-0003yD-N9 for guix-patches@gnu.org; Sun, 18 Feb 2024 17:20:41 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rbpWb-0003HX-BK for guix-patches@gnu.org; Sun, 18 Feb 2024 17:20:41 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rbpWw-0000Gv-17 for guix-patches@gnu.org; Sun, 18 Feb 2024 17:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68946] [PATCH v2] guix: Add logging module. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Feb 2024 22:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 68946@debbugs.gnu.org, Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Josselin Poiret , Ricardo Wurmus , Christopher Baines Received: via spool by 68946-submit@debbugs.gnu.org id=B68946.17082948371006 (code B ref 68946); Sun, 18 Feb 2024 22:21:01 +0000 Received: (at 68946) by debbugs.gnu.org; 18 Feb 2024 22:20:37 +0000 Received: from localhost ([127.0.0.1]:39870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbpWW-0000GA-KY for submit@debbugs.gnu.org; Sun, 18 Feb 2024 17:20:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbpWT-0000Fu-0u for 68946@debbugs.gnu.org; Sun, 18 Feb 2024 17:20:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbpTv-0002Zf-PX; Sun, 18 Feb 2024 17:17:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=OkUSHiEHHVcRWAHrQkbEufgV4pZZqRWcdzoDEcDagcM=; b=jsPYKuUgze5pocBPdWGy b70XGyaCenx0aWxeOrSlxjq8PAk1bwA+CADm05jSNk7CPtdsZlcN+fNqDskBHWIEnn+2O9jCe8MHp JphjxgQDfUPA1fOjKw+knTSBykHUNVOMEyO/UVCrxbM5EznpbozTRbmBeLSnZT+IUX706V1Bd3gVq 04Rlcq/6unKtjgDDJN7WxRYOnxtFZBvqwZVq+ST2xkDMzbgCL+OxzscogRjkDzvOdyHq8EriTsPJa +yvTDrjd17VAa8Gk5dzFCGUrdutZqdB8reJWNhuIZpJGCQcdtSB9uXHDCDEcp5y2mg40DTDlwYDEN 0aAU/ADOZGP9Bw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <0b81168e693a21f7fb08bd7677a5cc3120418fc9.1707626620.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sat, 10 Feb 2024 23:43:41 -0500") References: <0b81168e693a21f7fb08bd7677a5cc3120418fc9.1707626620.git.maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?UTF-8?Q?D=C3=A9cadi?= 30 =?UTF-8?Q?Pluvi=C3=B4se?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du =?UTF-8?Q?Tra=C3=AEneau?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 18 Feb 2024 23:17:53 +0100 Message-ID: <87bk8dl8mm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.88 X-Spam-Score: -5.88 X-Migadu-Queue-Id: 9875447DA8 X-Migadu-Scanner: mx11.migadu.com X-TUID: NyXMtEVWCZNq Hi! Maxim Cournoyer skribis: > * configure.ac: Require Guile-Lib. > * guix/logging.scm: New module. > * Makefile.am (MODULES): Register it. > * guix/ui.scm (show-guix-help): Document --log-level global option. > (%log-level): New parameter. > (run-guix-command): Init logging. > (run-guix): Parse new --log-level option. > > Change-Id: I5026a0d62119615fec3cd0131309f9bcc346a7e9 Two quick notes: I think it=E2=80=99s be best to avoid depending on Guile-L= ib =E2=80=9Cjust=E2=80=9D for this (it=E2=80=99s not clear to me what it=E2=80= =99s maintenance status is), and it=E2=80=99d be great to have concrete use case. My concern with logging is that it=E2=80=99s not a good fit for the functio= nal parts (unless it has a functional interface like =E2=80=98pk=E2=80=99, but = that=E2=80=99s still sorta =E2=80=9Ccluttering=E2=80=9D otherwise functional code), and I=E2=80= =99m not sure which imperative part it could be used for (I don=E2=80=99t doubt there=E2=80=99s= such a thing, but I lack imagination). Thanks, Ludo=E2=80=99.