From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id EL4TCppbKWaMxgAAqHPOHw:P1 (envelope-from ) for ; Wed, 24 Apr 2024 21:20:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id EL4TCppbKWaMxgAAqHPOHw (envelope-from ) for ; Wed, 24 Apr 2024 21:20:58 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b="Y9IMKs//"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713986458; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=22VhqsXhc+5TODlVZKSUx/iE4+0FKG7FHUh9hMg+1P0=; b=BGB5PpyfArx7wmn8E24KTDZ/PwTQz1wt3VA8vRQha8fJ0aoqlgYLaLG7QHaUCoUtIFru/5 4l6s+OLTXt1xVdG/3DSIMjRyquwLMLV02OY10C/tl+Tag34daDwJHW8mIE+SVh0JaSEhCc h3+rDH4Rac1/5LVLqx4b9ZwhEavmYXbf9+U3sa116JV1vj2C0N3g1eM+aKSkmUKyK2Uue+ XNa1PXs4a4vQj19u9vAlaJalvltyyZFG2UUFauZQ3eSmSCeC0X/0uI7ttewZcCxOt3NjZv +8iHaqj3tdNRIcrF1eSvNVbQngievR0FhFa+1Cc+c+EIm1SMzaRpKmhfQu9IpA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713986458; a=rsa-sha256; cv=none; b=WJmxpzeIKdpAy/RHiJJWfDuNaHBxWB2R6Rv2dKHeKstUsUR7lDzC1hmuQAZM76V//W4avR 5B096zTUvfUSG7mAW+4RzUZT2sMqEJPcdBQ/g4iWJUByO7XaJam84eyGcm6Txghd69R+cZ gBjRYGFny8TQE+oPo6PtxqcKH6VoltECZL5gnoc2eM3rJngSjxf9Z8GkGReuCYkKE05jpW f3JKURIRxmdc2iUXtRLw9kzl+mvudR6yGJMDke4Km7rCw5UafmSSFWQU7gMe7XKXq/hX96 BQsCgh4F+bo064TfFW5Yt7spxP0N+tt7TITbet8SUJcAiJo9EgNVr7dkz/pRbg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b="Y9IMKs//"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B18B660FE6 for ; Wed, 24 Apr 2024 21:20:57 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rziAi-0000B6-TI; Wed, 24 Apr 2024 15:20:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rziAh-0000AL-9C for guix-patches@gnu.org; Wed, 24 Apr 2024 15:20:47 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rziAh-00020h-0u for guix-patches@gnu.org; Wed, 24 Apr 2024 15:20:47 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rziAx-0003Hn-Rh for guix-patches@gnu.org; Wed, 24 Apr 2024 15:21:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70542] [PATCH 3/4] file-systems: Add support for mounting CIFS file systems Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Apr 2024 19:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70542 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 70542@debbugs.gnu.org Received: via spool by 70542-submit@debbugs.gnu.org id=B70542.171398640612029 (code B ref 70542); Wed, 24 Apr 2024 19:21:03 +0000 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 19:20:06 +0000 Received: from localhost ([127.0.0.1]:60024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rziA0-00037v-Qk for submit@debbugs.gnu.org; Wed, 24 Apr 2024 15:20:06 -0400 Received: from mail-108-mta251.mxroute.com ([136.175.108.251]:39771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzi9w-00036b-AU for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 15:20:02 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta251.mxroute.com (ZoneMTA) with ESMTPSA id 18f118c9a4d0008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 24 Apr 2024 19:19:38 +0000 X-Zone-Loop: 10a5bc91988afd54e811d49d53afa427803ad5e85ebe X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=22VhqsXhc+5TODlVZKSUx/iE4+0FKG7FHUh9hMg+1P0=; b=Y9IMKs//BLnQxZFn1bUvC3xbif GnkAjmtLtBTMONYaUI2xKitbXoU40BZXnJM+JK0URDDT1HI+FG6ozTgFpcEj4YjW22ZxTrBSBqEVi 0sHeQx0Kvips97nCEzu/sdFPTvFGdJ3GunvAPXpeuYS9HwS5DpyfD9BImEPqDe+wwR3nO+7/772GE Kx3U0ryJL6CsIZHpCubPW9P6Gzfj/kpDVdKRi41cIrk9vA8Z+f/AViJuNIj5nf4yzuGXoE5SlPUpg SFdspsccrvbOChMV+pTQObZbkSJ5BBYTNhpv8w1BQ+N34xWszB0veNkzBbCY5FrtLfTHFLjw/UNTo 4WC+s/iw==; From: Richard Sent In-Reply-To: <9e56714d2d48b006be519a1c03de5e37bd8af4c2.camel@gmail.com> (Liliana Marie Prikler's message of "Wed, 24 Apr 2024 20:47:21 +0200") References: <036dbbe1dc78d8c1e36f70caa5e5f2b6b21abc56.camel@gmail.com> <87frvazklw.fsf@freakingpenguin.com> <9e56714d2d48b006be519a1c03de5e37bd8af4c2.camel@gmail.com> Date: Wed, 24 Apr 2024 15:19:34 -0400 Message-ID: <87bk5yzhyx.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: richard@freakingpenguin.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.26 X-Spam-Score: -4.26 X-Migadu-Queue-Id: B18B660FE6 X-Migadu-Scanner: mx13.migadu.com X-TUID: LFj+yGfk/C8q > I'm rarely that deep in our interaction with file systems Haha, join the club! > do we go through mount or do directly talk to the kernel driver? If we > do mount.cifs under the hood, this should not be an issue. Otherwise, > we should do our best to document this behaviour. mount-file-system uses the mount system call under the hood, no userspace tooling as far as I can tell. See mount in (guix build syscalls). Unfortunately this means we need to replicate the userspace mount.cifs program's behavior for handling the guest option. This would definitely be easier (and probably compatible with more file systems) if we used the standard userspace tools, but I don't think there's a good way to do that at present. My hope is that if we match mount.cifs's behavior in how we handle the guest option (adding user=,pass=), we won't need extra documentation explaining CIFS file system options. Users would just follow mount.cifs's documentation (which is probably what they'd find first). To my knowledge the patch's current behavior w.r.t. guest matches mount.cifs. If we were to implement our own divergent behavior from mount.cifs, then we would need to document that divergence. But I don't think we need to document that our behavior matches the mount.cifs program's behavior. (Or, if we do, it should probably be a more general statement like "File system options are passed to the mount system call, with slight adjustments to match the userspace mount. equivalent program's behavior." Something akin to that, but it's not specifically a CIFS thing.) > I assume that specifying neither user nor guest would result in an > error, but you're welcome to discover bugs^Wfresh new features. I think I'd be content with calling that "user error". If mount.cifs doesn't do anything special, neither should we. ;) -- Take it easy, Richard Sent Making my computer weirder one commit at a time.